Re: [PATCHES] Rename latestCompletedXid to latestCommittedXid

2007-09-12 Thread Tom Lane
Florian G. Pflug [EMAIL PROTECTED] writes: Per my post to the hackers list, here is a patch that renamed latestCompletedXid to latestCommittedXid, and updates it only on commits. This is wrong --- it will break early detection of aborted subtransactions. regards, tom

Re: [PATCHES] Rename latestCompletedXid to latestCommittedXid

2007-09-12 Thread Florian G. Pflug
Tom Lane wrote: Florian G. Pflug [EMAIL PROTECTED] writes: Per my post to the hackers list, here is a patch that renamed latestCompletedXid to latestCommittedXid, and updates it only on commits. This is wrong --- it will break early detection of aborted subtransactions. I don't see how -

Re: [PATCHES] Rename latestCompletedXid to latestCommittedXid

2007-09-12 Thread Tom Lane
Florian G. Pflug [EMAIL PROTECTED] writes: Tom Lane wrote: This is wrong --- it will break early detection of aborted subtransactions. I don't see how - TransactionIdIsInProgress doesn't even touch latestCompletedXid. Nah, I take that back --- I was worried that XidInMVCCSnapshot might say