Re: [PATCHES] Reviewers Guide to Deferred Transactions/TransactionGuarantee
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- ITAGAKI Takahiro wrote: > "Simon Riggs" <[EMAIL PROTECTED]> wrote: > > > > transaction_guarantee.v11.patch > > correct files attached > > This is a small fix to transaction_guarantee patch. > WAL writer needs PGSharedMemoryReAttach() on EXEC_BACKEND platforms. > Other changes are only for suppressing warnings. > > We might also need to increase NUM_AUXILIARY_PROCS (=3) for WAL writer, > but I didn't change it in the patch. (I don't know why the value is 3 > -- bgwriter, autovacuum launcher and ... what?) > > > BTW, the following TODO item comes to my mind: > | Allow WAL traffic to be streamed to another server for stand-by replication > We have to open sockets to another server when we want to stream WAL. > If there were WAL writer, we can save the number of those sockets. > > Regards, > --- > ITAGAKI Takahiro > NTT Open Source Software Center > [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 9: In versions below 8.0, the planner will ignore your desire to >choose an index scan if your joining column's datatypes do not >match -- Bruce Momjian <[EMAIL PROTECTED]> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 6: explain analyze is your friend
Re: [PATCHES] Reviewers Guide to Deferred Transactions/TransactionGuarantee
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Simon Riggs wrote: > On Thu, 2007-04-05 at 22:56 +0100, Simon Riggs wrote: > > transaction_guarantee.v11.patch > > correct files attached > > > Open Questions > > -- > > > > 1. Should the DFC use a standard hash table? Custom code allows both > > additional speed and the ability to signal when it fills. > > > > 2. Should tqual.c update the LSN of a heap page with the LSN of the > > transaction commit that it can read from the DF cache? > > I now think we should update the LSN of the page, but not changed yet. > > > 3. Should the WALWriter also do the wal_buffers half-full write at the > > start of XLogInsert() ? > > Not that important > > > 4. The recent changes to remove CheckpointStartLock haven't changed the > > code path for deferred transactions, so a similar solution might be > > possible there also. > > Some further discussion required here, I think. That change may actually > have introduced a slight risk into the patch. Will raise at review. > > > 5. Is it correct to do WAL-before-flush for clog only, or should this > > be multixact also? > > Not necessary > > -- > Simon Riggs > EnterpriseDB http://www.enterprisedb.com > [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 5: don't forget to increase your free space map settings -- Bruce Momjian <[EMAIL PROTECTED]> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [PATCHES] Reviewers Guide to Deferred Transactions/TransactionGuarantee
"Simon Riggs" <[EMAIL PROTECTED]> wrote: > > transaction_guarantee.v11.patch > correct files attached This is a small fix to transaction_guarantee patch. WAL writer needs PGSharedMemoryReAttach() on EXEC_BACKEND platforms. Other changes are only for suppressing warnings. We might also need to increase NUM_AUXILIARY_PROCS (=3) for WAL writer, but I didn't change it in the patch. (I don't know why the value is 3 -- bgwriter, autovacuum launcher and ... what?) BTW, the following TODO item comes to my mind: | Allow WAL traffic to be streamed to another server for stand-by replication We have to open sockets to another server when we want to stream WAL. If there were WAL writer, we can save the number of those sockets. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center transaction_guarantee.v11fix.patch Description: Binary data ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [PATCHES] Reviewers Guide to Deferred Transactions/TransactionGuarantee
"Simon Riggs" <[EMAIL PROTECTED]> writes: >> 4. The recent changes to remove CheckpointStartLock haven't changed the >> code path for deferred transactions, so a similar solution might be >> possible there also. > Some further discussion required here, I think. That change may actually > have introduced a slight risk into the patch. Will raise at review. Given that you're going to be gone for the next two weeks, I'm wondering when you think that discussion will happen. regards, tom lane ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
Re: [PATCHES] Reviewers Guide to Deferred Transactions/TransactionGuarantee
On Thu, 2007-04-05 at 22:56 +0100, Simon Riggs wrote: > transaction_guarantee.v11.patch correct files attached > Open Questions > -- > > 1. Should the DFC use a standard hash table? Custom code allows both > additional speed and the ability to signal when it fills. > > 2. Should tqual.c update the LSN of a heap page with the LSN of the > transaction commit that it can read from the DF cache? I now think we should update the LSN of the page, but not changed yet. > 3. Should the WALWriter also do the wal_buffers half-full write at the > start of XLogInsert() ? Not that important > 4. The recent changes to remove CheckpointStartLock haven't changed the > code path for deferred transactions, so a similar solution might be > possible there also. Some further discussion required here, I think. That change may actually have introduced a slight risk into the patch. Will raise at review. > 5. Is it correct to do WAL-before-flush for clog only, or should this > be multixact also? Not necessary -- Simon Riggs EnterpriseDB http://www.enterprisedb.com tg.tar.gz Description: application/compressed-tar ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
