Re: [PATCHES] SECURITY DEFINER not being propagated...

2004-04-29 Thread Sean Chittenden
I think the attached patch addresses both of your concerns. Perhaps something like this will work, but the patch as given can't possibly be right (or have been tested with any care): Not tested in the slightest, actually. The attached has been, however is commented and tested. A larger problem i

Re: [PATCHES] SECURITY DEFINER not being propagated...

2004-04-29 Thread Tom Lane
Sean Chittenden <[EMAIL PROTECTED]> writes: > I think the attached patch addresses both of your concerns. Perhaps something like this will work, but the patch as given can't possibly be right (or have been tested with any care): > + aclresult = pg_namespace_aclcheck(MyDatabaseId, Ge

Re: [PATCHES] SECURITY DEFINER not being propagated...

2004-04-29 Thread Sean Chittenden
Without any rationale as to why CREATE TEMP TABLEs checks the session user in the archives, could we open this up for discussion again? Well, let me put it this way: if you want to change the behavior you're going to have to work much harder than just reverting the prior patch. IIRC the fundamental

Re: [PATCHES] SECURITY DEFINER not being propagated...

2004-04-28 Thread Tom Lane
Sean Chittenden <[EMAIL PROTECTED]> writes: > Without any rationale as to why CREATE TEMP TABLEs checks the session > user in the archives, could we open this up for discussion again? Well, let me put it this way: if you want to change the behavior you're going to have to work much harder than ju

Re: [PATCHES] SECURITY DEFINER not being propagated...

2004-04-28 Thread Sean Chittenden
This one's simple enough to reproduce (see SQL script below), but, there are some comments in src/backend/catalog/namespace.c that seem questionable and incorrect: The proposed patch reverts a change deliberately applied in namespace.c rev 1.15 (4/29/02). I think you need to go back and consult th

Re: [PATCHES] SECURITY DEFINER not being propagated...

2004-04-27 Thread Tom Lane
Sean Chittenden <[EMAIL PROTECTED]> writes: > This one's simple enough to reproduce (see SQL script below), but, > there are some comments in src/backend/catalog/namespace.c that seem > questionable and incorrect: The proposed patch reverts a change deliberately applied in namespace.c rev 1.15 (