Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-07-11 Thread Tom Lane
Christopher Kings-Lynne [EMAIL PROTECTED] writes: Attached is an updated ALTER TABLE ... SET TABLESPACE patch. Does this patch allow setting the tablespace of sequences as well? If so, then you will need to modify pg_dump of SERIAL sequences. Perhaps output a ALTER TABLE/SET TABLESPACE

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-07-11 Thread Bruce Momjian
Applied by Tom. --- Gavin Sherry wrote: Hi all, Attached is an updated ALTER TABLE ... SET TABLESPACE patch. It uses the block by block copy mechanism proposed by Tom and handles i) ALTER TABLE index and ii)

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-07-11 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Added to TODO; * Allow moving sequences and toast tables to other tablespaces in case no one does it. Please remove that; if I thought either one was a good idea, I would have allowed it in the committed patch. Sequences are too small to be worth

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-07-11 Thread Bruce Momjian
Tom Lane wrote: Christopher Kings-Lynne [EMAIL PROTECTED] writes: Attached is an updated ALTER TABLE ... SET TABLESPACE patch. Does this patch allow setting the tablespace of sequences as well? If so, then you will need to modify pg_dump of SERIAL sequences. Perhaps output a ALTER

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-07-11 Thread Bruce Momjian
OK, removed. --- Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Added to TODO; * Allow moving sequences and toast tables to other tablespaces in case no one does it. Please remove that; if I thought

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-07-11 Thread Christopher Kings-Lynne
Please remove that; if I thought either one was a good idea, I would have allowed it in the committed patch. Sequences are too small to be worth moving around, and may someday be reimplemented in a fashion that doesn't use up a separate disk file for each one. If we allow SET TABLESPACE on them

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-07-11 Thread Christopher Kings-Lynne
Does this patch allow setting the tablespace of sequences as well? If so, then you will need to modify pg_dump of SERIAL sequences. Perhaps output a ALTER TABLE/SET TABLESPACE command after the CREATE TABLE definition to move the SERIAL sequence. The same argument applies if it allows moving

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-07-11 Thread Bruce Momjian
Christopher Kings-Lynne wrote: Please remove that; if I thought either one was a good idea, I would have allowed it in the committed patch. Sequences are too small to be worth moving around, and may someday be reimplemented in a fashion that doesn't use up a separate disk file for

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-07-11 Thread Bruce Momjian
Will toast go in the same tablespace as the base table? I can see some advantages to splitting that to another drive for extreme cases (think heap/toast lookups over and over again). --- Tom Lane wrote: Christopher

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-07-11 Thread Gavin Sherry
On Mon, 12 Jul 2004, Christopher Kings-Lynne wrote: I had forgotten that the original patch allowed that. Personally I'd vote for taking it out, for the above-stated reasons --- any objections? I vote for taking it out. Pull it. I added it intentionally but now I'm questioning my

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-07-11 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Will toast go in the same tablespace as the base table? That is the current design, and I'd prefer to keep it that way because anything else adds great complexity for unclear gain. Two examples of pain points: 1. That pending patch to report a table's

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-07-11 Thread Tom Lane
Gavin Sherry [EMAIL PROTECTED] writes: On Mon, 12 Jul 2004, Christopher Kings-Lynne wrote: I vote for taking it out. Pull it. I added it intentionally but now I'm questioning my reasoning (which was, sequences might be accessed lots, people might want to put them somewhere intentionally).

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-07-11 Thread Tom Lane
Christopher Kings-Lynne [EMAIL PROTECTED] writes: Otherwise, we need to extend the ADD CONSTRAINT syntax. Yeah, I was wondering if there was some minimal-impact way to do that. regards, tom lane ---(end of broadcast)---

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-07-11 Thread Christopher Kings-Lynne
In fact, now that I think of it, the patch-as-committed already introduces some serious headaches for pg_dump: it can't know for sure what name will be assigned to constraint indexes (pkey and unique indexes) so it has no good way to emit ALTER TABLE SET TABLESPACE commands for those indexes. I

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-07-11 Thread Christopher Kings-Lynne
Otherwise, we need to extend the ADD CONSTRAINT syntax. Yeah, I was wondering if there was some minimal-impact way to do that. Oh, or we create ALTER CONSTRAINT :) Chris ---(end of broadcast)--- TIP 7: don't forget to increase your free space map

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-07-11 Thread Christopher Kings-Lynne
Otherwise, we need to extend the ADD CONSTRAINT syntax. Yeah, I was wondering if there was some minimal-impact way to do that. Shall I hold off on doing any pg_dump changes then? Chris ---(end of broadcast)--- TIP 1: subscribe and unsubscribe

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-07-10 Thread Bruce Momjian
I realize this still need WAL work, but we should get this in. Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours.

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-07-08 Thread Christopher Kings-Lynne
Attached is an updated ALTER TABLE ... SET TABLESPACE patch. It uses the block by block copy mechanism proposed by Tom and handles i) ALTER TABLE index and ii) Copying of TOAST tables and the TOAST table's index. It doesn't handle copying of system tables (pg_largeobject) and, in the

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-06-30 Thread Gavin Sherry
On Thu, 1 Jul 2004, Gavin Sherry wrote: Hi all, Attached is an updated ALTER TABLE ... SET TABLESPACE patch. It uses the block by block copy mechanism proposed by Tom and handles i) ALTER TABLE index and ii) Copying of TOAST tables and the TOAST table's index. It doesn't handle

Re: [PATCHES] Updated ALTER TABLE ... SET TABLESPACE patch

2004-06-30 Thread Simon Riggs
On Wed, 2004-06-30 at 22:29, Gavin Sherry wrote: On Thu, 1 Jul 2004, Gavin Sherry wrote: Oh, and it doesn't handle WAL. Tom mentioned/agreed that btree's method of dumping whole pages into WAL would be the best/most efficient way to journaling this and that the btree code should be