Re: [PATCHES] WIP: CREATE TABLE AS / WITH DATA

2004-09-22 Thread Gavin Sherry
On Thu, 23 Sep 2004, Tom Lane wrote: > Neil Conway <[EMAIL PROTECTED]> writes: > > On Wed, 2004-09-22 at 23:00, Alvaro Herrera wrote: > >> Could that include supporting SELECT INTO as well as both types of > >> CREATE TABLE AS? > > > Right; my thinking is to have the parser construct SELECT INTO

Re: [PATCHES] WIP: CREATE TABLE AS / WITH DATA

2004-09-22 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > On Wed, 2004-09-22 at 23:00, Alvaro Herrera wrote: >> Could that include supporting SELECT INTO as well as both types of >> CREATE TABLE AS? > Right; my thinking is to have the parser construct SELECT INTO as a > CreateTableAsStmt. That way all the code fo

Re: [PATCHES] WIP: CREATE TABLE AS / WITH DATA

2004-09-22 Thread Neil Conway
On Wed, 2004-09-22 at 23:00, Alvaro Herrera wrote: > Could that include supporting SELECT INTO as well as both types of > CREATE TABLE AS? Right; my thinking is to have the parser construct SELECT INTO as a CreateTableAsStmt. That way all the code for creating the "into" relation is centralized in

Re: [PATCHES] WIP: CREATE TABLE AS / WITH DATA

2004-09-22 Thread Alvaro Herrera
On Wed, Sep 22, 2004 at 06:48:12PM +1000, Neil Conway wrote: > P.S. I'm beginning to think that rather than applying this patch as-is > when we branch for 8.1, it might be a better idea to just bite the > bullet and restructure CREATE TABLE AS as suggested above. Thoughts? Could that include supp