Re: [PATCHES] autovauum integration patch: Attempt #4

2004-08-03 Thread Tom Lane
Matthew T. O'Connor [EMAIL PROTECTED] writes: I agree. The thought had crossed my mind that autovac should shut down first, but I'm really not sure how to make that happen. You have to issue the kill() when the postmaster first receives the shutdown signal, rather than waiting till after all

Re: [PATCHES] autovauum integration patch: Attempt #4

2004-08-02 Thread Tom Lane
Matthew T. O'Connor [EMAIL PROTECTED] writes: Please apply to CVS or tell me what I need to change to get it applied. I looked over this patch (sorry for the delay), and found a number of problems. Bigger problems: * I don't think you've thought through system shutdown at all. The postmaster

Re: [PATCHES] autovauum integration patch: Attempt #4

2004-08-02 Thread Bruce Momjian
Tom Lane wrote: I'm not sure what we do now. I can't apply this in its current state, and I do not have time to fix it. I don't really want to push it in and assume we can fix the problems during beta ... I see. :-( I know Matthew just got back from being away so perhaps he has time to

Re: [PATCHES] autovauum integration patch: Attempt #4

2004-08-02 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: As far as libpq, can't pg_autovacuum dynamically load libpq like dblink does? Hmm, make the bulk of the autovac daemon be a shlib that is dynamically linked by just that subprocess? Yeah, that might work. On the password issue, can't we use .pgpass in

Re: [PATCHES] autovauum integration patch: Attempt #4

2004-08-02 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: As far as libpq, can't pg_autovacuum dynamically load libpq like dblink does? Hmm, make the bulk of the autovac daemon be a shlib that is dynamically linked by just that subprocess? Yeah, that might work. We certainly don't want to

Re: [PATCHES] autovauum integration patch: Attempt #4

2004-08-02 Thread Matthew T. O'Connor
On Mon, 2004-08-02 at 21:36, Bruce Momjian wrote: Tom Lane wrote: I'm not sure what we do now. I can't apply this in its current state, and I do not have time to fix it. I don't really want to push it in and assume we can fix the problems during beta ... I see. :-( I know Matthew

Re: [PATCHES] autovauum integration patch: Attempt #4

2004-08-02 Thread Matthew T. O'Connor
On Mon, 2004-08-02 at 21:53, Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: As far as libpq, can't pg_autovacuum dynamically load libpq like dblink does? Hmm, make the bulk of the autovac daemon be a shlib that is dynamically linked by just that subprocess? Yeah, that might

Re: [PATCHES] autovauum integration patch: Attempt #4

2004-08-02 Thread Matthew T. O'Connor
On Mon, 2004-08-02 at 19:26, Tom Lane wrote: I looked over this patch (sorry for the delay), and found a number of problems. Thanks for the feedback, hopefully we can still get something in place for 7.5. Bigger problems: * I don't think you've thought through system shutdown at all. The

Re: [PATCHES] autovauum integration patch: Attempt #4

2004-07-24 Thread Bruce Momjian
Patch applied. Thanks. --- Matthew T. O'Connor wrote: On Fri, 2004-07-23 at 23:25, Tom Lane wrote: Matthew T. O'Connor [EMAIL PROTECTED] writes: Peter Eisentraut wrote: I'm not sure whether we can allow int8

Re: [PATCHES] autovauum integration patch: Attempt #4

2004-07-24 Thread Bruce Momjian
[ Oops, I mean added, not applied. ] Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it.

Re: [PATCHES] autovauum integration patch: Attempt #4

2004-07-24 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Patch applied. Thanks. What happened to the review part? regards, tom lane ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send

Re: [PATCHES] autovauum integration patch: Attempt #4

2004-07-24 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: What happened to the review part? See correction email. I put the wrong header on the email. Right, I saw that a bit later. Sorry for the noise. regards, tom lane ---(end of

Re: [PATCHES] autovauum integration patch: Attempt #4

2004-07-24 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Patch applied. Thanks. What happened to the review part? See correction email. I put the wrong header on the email. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610)

Re: [PATCHES] autovauum integration patch: Attempt #4

2004-07-23 Thread Peter Eisentraut
Matthew T. O'Connor wrote: As before, to apply this patch: 1) Move pg_autovacuum.c and .h get from contrib to src/backend/postmaster and src/include/postmaster respectively. Trivial comment: maybe we can drop the pg_ prefix on the file names. 2) Place the attached pg_autovacuum.h in

Re: [PATCHES] autovauum integration patch: Attempt #4

2004-07-23 Thread Matthew T. O'Connor
Peter Eisentraut wrote: Matthew T. O'Connor wrote: As before, to apply this patch: 1) Move pg_autovacuum.c and .h get from contrib to src/backend/postmaster and src/include/postmaster respectively. Trivial comment: maybe we can drop the pg_ prefix on the file names. Ok, that's not a problem.

Re: [PATCHES] autovauum integration patch: Attempt #4

2004-07-23 Thread Bruce Momjian
Matthew T. O'Connor wrote: Peter Eisentraut wrote: Matthew T. O'Connor wrote: As before, to apply this patch: 1) Move pg_autovacuum.c and .h get from contrib to src/backend/postmaster and src/include/postmaster respectively. Trivial comment: maybe we can drop the pg_ prefix on the

Re: [PATCHES] autovauum integration patch: Attempt #4

2004-07-23 Thread Bruce Momjian
Peter Eisentraut wrote: Matthew T. O'Connor wrote: As before, to apply this patch: 1) Move pg_autovacuum.c and .h get from contrib to src/backend/postmaster and src/include/postmaster respectively. Trivial comment: maybe we can drop the pg_ prefix on the file names. 2) Place the