Re: [PATCHES] boolean = text explicit casts

2007-06-19 Thread Jim Nasby
On May 30, 2007, at 3:40 PM, Neil Conway wrote: On Wed, 2007-30-05 at 21:23 +0200, Peter Eisentraut wrote: I'm not sure what your rationale was for creating lower-case words instead of upper case, except for it looks nicer. Is there a technical reason? There's no real technical reason:

Re: [PATCHES] boolean = text explicit casts

2007-05-30 Thread Neil Conway
On Mon, 2007-28-05 at 15:38 -0400, Tom Lane wrote: More generally, I'm really hoping to get rid of bespoke text-whatever cast functions in favor of using datatypes' I/O functions. To what extent can we make the boolean I/O functions serve for this? It seems relatively painless on the input

Re: [PATCHES] boolean = text explicit casts

2007-05-30 Thread Peter Eisentraut
Neil Conway wrote: Attached is a revised version of this patch that modifies boolin() to ignore leading and trailing whitespace. This makes text = boolean trivial, but boolean = text is still distinct from boolout(). I'm not sure what your rationale was for creating lower-case words instead

Re: [PATCHES] boolean = text explicit casts

2007-05-30 Thread Neil Conway
On Wed, 2007-30-05 at 21:23 +0200, Peter Eisentraut wrote: I'm not sure what your rationale was for creating lower-case words instead of upper case, except for it looks nicer. Is there a technical reason? There's no real technical reason: the standard says upper-case, but PG's general

Re: [PATCHES] boolean = text explicit casts

2007-05-28 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: (2) The spec also requires that boolean::varchar(n) should raise an error if n is not large enough to accomodate the textual representation of the boolean value. Really? That's in direct contradiction to the normal spec-required behavior of casting to

Re: [PATCHES] boolean = text explicit casts

2007-05-28 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: On Mon, 2007-28-05 at 15:38 -0400, Tom Lane wrote: More generally, I'm really hoping to get rid of bespoke text-whatever cast functions in favor of using datatypes' I/O functions. I don't object, but I'm curious: is there a benefit to this other than