"Neil Conway" <[EMAIL PROTECTED]> wrote
>
> Other inconsistencies:
>
> - the patch prints a trailing comma when remote->port is the empty
> string
>
> - the patch separates the elements of the ereport() line with commas,
> whereas the original behavior was to use a single space as a separator
>
>
On Mon, 2005-03-10 at 12:28 -0400, Qingqing Zhou wrote:
> Ooops, this wording change is inconsistent with Log_connections, so I
> reverted it. Updated patch is attached.
Other inconsistencies:
- the patch prints a trailing comma when remote->port is the empty
string
- the patch separates the ele
On Mon, 2005-03-10 at 12:28 -0400, Qingqing Zhou wrote:
> Ooops, this wording change is inconsistent with Log_connections, so I
> reverted it. Updated patch is attached.
Barring any objections, I'll apply this to HEAD tomorrow.
-Neil
---(end of broadcast)---
On Mon, 3 Oct 2005, Neil Conway wrote:
> Why does the patch change behavior when
>
> - port->remote_port is the empty string
Ooops, this wording change is inconsistent with Log_connections, so I
reverted it. Updated patch is attached.
> - or, when end.tv_sec is negative
>
I can only imagine end
On Mon, 2005-03-10 at 00:37 -0400, Qingqing Zhou wrote:
> Trivial patch to cleanup log_disconnections() function.
Why does the patch change behavior when
- port->remote_port is the empty string
- or, when end.tv_sec is negative
I'm not adamant that the old behavior is better, but I'd like to see
