Re: [PATCHES] create or replace language

2008-05-15 Thread Andreas 'ads' Scherbaum
On Sat, 10 May 2008 09:36:26 +0200 Andreas 'ads' Scherbaum wrote: On Sat, 3 May 2008 21:12:51 +0200 Andreas 'ads' Scherbaum wrote: On Sat, 03 May 2008 13:34:05 -0400 Tom Lane wrote: So maybe the right thing is that CREATE OR REPLACE LANGUAGE can change inessential properties of an

Re: [PATCHES] create or replace language

2008-05-15 Thread Heikki Linnakangas
Andreas 'ads' Scherbaum wrote: Attached is another version of the patch (still missing documentation), which changes the language owner on update (the owner can still be changed in pg_pltemplate). The other CREATE OR REPLACE commands don't change the owner, so CREATE OR REPLACE LANGUAGE

Re: [PATCHES] create or replace language

2008-05-15 Thread Andreas 'ads' Scherbaum
On Thu, 15 May 2008 12:29:11 +0100 Heikki Linnakangas wrote: Andreas 'ads' Scherbaum wrote: Attached is another version of the patch (still missing documentation), which changes the language owner on update (the owner can still be changed in pg_pltemplate). The other CREATE OR REPLACE

Re: [PATCHES] create or replace language

2008-05-10 Thread Andreas 'ads' Scherbaum
On Sat, 3 May 2008 21:12:51 +0200 Andreas 'ads' Scherbaum wrote: On Sat, 03 May 2008 13:34:05 -0400 Tom Lane wrote: So maybe the right thing is that CREATE OR REPLACE LANGUAGE can change inessential properties of an existing language, but not the core properties --- which might only be

Re: [PATCHES] create or replace language

2008-05-05 Thread Gregory Stark
Tom Lane [EMAIL PROTECTED] writes: The equivalent problem for views and functions is handled by restricting CREATE OR REPLACE to not change the output column set of a view or the type signature of a function, independently of whether there are any actual references to the object. So maybe

Re: [PATCHES] create or replace language

2008-05-05 Thread Tom Lane
Gregory Stark [EMAIL PROTECTED] writes: Tom Lane [EMAIL PROTECTED] writes: ... So maybe the right thing is that CREATE OR REPLACE LANGUAGE can change inessential properties of an existing language, but not the core properties --- which might only be the handler function, though you could

Re: [PATCHES] create or replace language

2008-05-03 Thread Andreas 'ads' Scherbaum
On Sat, 29 Mar 2008 22:35:21 -0400 Tom Lane wrote: The key argument seems to be that it's quite unclear what the state following CREATE IF NOT EXISTS (CINE) should be, if the object does exist but not with the same properties specified in the CINE command. CREATE OR REPLACE resolves that by

Re: [PATCHES] create or replace language

2008-05-03 Thread Tom Lane
Andreas 'ads' Scherbaum [EMAIL PROTECTED] writes: Attached is a first version for the CREATE OR REPLACE LANGUAGE patch. It's still missing some functionality (especially the update part is far away from being complete) and it's also missing documentation. It strikes me that if there are any

Re: [PATCHES] create or replace language

2008-05-03 Thread Andreas 'ads' Scherbaum
Hello, On Sat, 03 May 2008 13:34:05 -0400 Tom Lane wrote: So maybe the right thing is that CREATE OR REPLACE LANGUAGE can change inessential properties of an existing language, but not the core properties --- which might only be the handler function, though you could make a case for the