Re: [PATCHES] cygwin 8.0.0beta1 postmaster/syslogger.c, port/dirmod.c,

2004-08-31 Thread Bruce Momjian
OK, patch attached and applied that casts _timezone to (int) on Cygwin. --- Reini Urban wrote: > Bruce Momjian schrieb: > > Should I apply this change? > > > > #define TIMEZONE_GLOBAL ((int)_timezone) > > yes, please.

Re: [PATCHES] cygwin 8.0.0beta1 postmaster/syslogger.c, port/dirmod.c,

2004-08-30 Thread Reini Urban
Bruce Momjian schrieb: Should I apply this change? #define TIMEZONE_GLOBAL ((int)_timezone) yes, please. I have no time yet, to come up with the better patch. It's already monday. --- Reini Urban wrote: Bruce Momjian schr

Re: [PATCHES] cygwin 8.0.0beta1 postmaster/syslogger.c, port/dirmod.c,

2004-08-29 Thread Bruce Momjian
Should I apply this change? #define TIMEZONE_GLOBAL ((int)_timezone) --- Reini Urban wrote: > Bruce Momjian schrieb: > > Your patch highlighted several bugs in our code. First, I wasn't > > testing for CYGWIN in the

Re: [PATCHES] cygwin 8.0.0beta1 postmaster/syslogger.c, port/dirmod.c,

2004-08-29 Thread Reini Urban
Bruce Momjian schrieb: Your patch highlighted several bugs in our code. First, I wasn't testing for CYGWIN in the backend pgport_palloc code. Second, I added an #undef to prevent compiler warnings. Third I added your Cygwin includes with an #ifdef. These will appear in beta2. On the timezone is

Re: [PATCHES] cygwin 8.0.0beta1 postmaster/syslogger.c, port/dirmod.c,

2004-08-28 Thread Bruce Momjian
Your patch highlighted several bugs in our code. First, I wasn't testing for CYGWIN in the backend pgport_palloc code. Second, I added an #undef to prevent compiler warnings. Third I added your Cygwin includes with an #ifdef. These will appear in beta2. On the timezone issue, I see this in dt

Re: [PATCHES] cygwin 8.0.0beta1 postmaster/syslogger.c, port/dirmod.c, timezone/pgtz.c

2004-08-24 Thread Jason Tishler
On Tue, Aug 24, 2004 at 09:49:51PM +0200, Reini Urban wrote: > There's on remaining issue for the cygwin build: > ../../src/port/libpgport.a(dirmod.o)(.text+0x5ee):dirmod.c: undefined > reference to `__imp__CurrentMemoryContext' > ../../src/port/libpgport.a(dirmod.o)(.text+0x64b):dirmod.c: undefin