Re: [PATCHES] error report on slru.c
Tom Lane wrote: Peter Eisentraut <[EMAIL PROTECTED]> writes: Tom Lane wrote: This violates the message style guidelines, IMHO. My first impression is that it should be swapped. The error is that the file could not be opened. The detail is that the files is related to transaction status information. No, the error is that the transaction status couldn't be accessed. The fact that it is stored in a file is implementation detail, and primary messages should not focus on implementation detail. Right, so the only way a DBA have is to look the details! Is there another way to know the file and the offset a transaction belong to ? Regards Gaetano Mendola ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs/FAQ.html
Re: [PATCHES] error report on slru.c
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> This violates the message style guidelines, IMHO. > My first impression is that it should be swapped. The error is that the > file could not be opened. The detail is that the files is related to > transaction status information. No, the error is that the transaction status couldn't be accessed. The fact that it is stored in a file is implementation detail, and primary messages should not focus on implementation detail. regards, tom lane ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [PATCHES] error report on slru.c
Tom Lane wrote: > Gaetano Mendola <[EMAIL PROTECTED]> writes: > > here a patch that > > 1) Rise the information about the file missing on pg_clog from > > detail to error > > This violates the message style guidelines, IMHO. My first impression is that it should be swapped. The error is that the file could not be opened. The detail is that the files is related to transaction status information. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org
Re: [PATCHES] error report on slru.c
Tom Lane wrote: Gaetano Mendola <[EMAIL PROTECTED]> writes: here a patch that 1) Rise the information about the file missing on pg_clog from detail to error This violates the message style guidelines, IMHO. Tom, your opinion is not humble but is is really appreciated, however I think that a missing file is not a "detail" information. 2) Insert the offset information also for a missing file It's hardly necessary, since the transaction number tells you everything you need to know if you really need it, and the offset is certainly not relevant to a file-open failure. Good to know, how is possible then retrive the informations about the file needed and the offset without rise the logs detail ? Regards Gaetano Mendola ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])
Re: [PATCHES] error report on slru.c
Gaetano Mendola <[EMAIL PROTECTED]> writes: > here a patch that > 1) Rise the information about the file missing on pg_clog from > detail to error This violates the message style guidelines, IMHO. > 2) Insert the offset information also for a missing file It's hardly necessary, since the transaction number tells you everything you need to know if you really need it, and the offset is certainly not relevant to a file-open failure. regards, tom lane ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org
