Re: [PATCHES] initdb of regression test failed.

2007-10-04 Thread Hiroshi Saito
Hi Tom-san. This may be mere information... In 8.3, when it has different encoding for every database, a locale requires C. Therefore, I am the reason which desires C by regression test. -- ininitdb -E EUC_JP -D../data --locale=Japanese_Japan.20932 The files belonging to this database system

Re: [PATCHES] initdb of regression test failed.

2007-10-04 Thread ITAGAKI Takahiro
Tom Lane [EMAIL PROTECTED] wrote: initdb -E UTF8 --locale=Japanese_Japan.932 -- CP932 is SJIS in nature Hmm, but does that really work safely? I think varstr_cmp() does work, because it forces our data into wchar format and then calls wcscoll(). The thing that scares me is that various

Re: [PATCHES] initdb of regression test failed.

2007-10-04 Thread Tom Lane
ITAGAKI Takahiro [EMAIL PROTECTED] writes: The attached is the second plan. It uses UTF-8 and locale=C when the default locale encoding is not supported and none of encoding and locale are passed to initdb. It would help users who use the default settings (including regression test). I'm not

Re: [PATCHES] initdb of regression test failed.

2007-10-03 Thread ITAGAKI Takahiro
Hiroshi Saito [EMAIL PROTECTED] wrote: Ah Ok, Please check it. Your patch looks useful to prevent mismatch of encoding and locale on Windows, but I found there is a limitation that user will not able to specify locale. I added an alternative of nl_langinfo(CODESET) for Win32. Please check

Re: [PATCHES] initdb of regression test failed.

2007-10-03 Thread Hiroshi Saito
Hi. - Original Message - From: ITAGAKI Takahiro [EMAIL PROTECTED] Hiroshi Saito [EMAIL PROTECTED] wrote: Ah Ok, Please check it. Your patch looks useful to prevent mismatch of encoding and locale on Windows, but I found there is a limitation that user will not able to specify

Re: [PATCHES] initdb of regression test failed.

2007-10-03 Thread Tom Lane
ITAGAKI Takahiro [EMAIL PROTECTED] writes: Your patch looks useful to prevent mismatch of encoding and locale on Windows, but I found there is a limitation that user will not able to specify locale. I added an alternative of nl_langinfo(CODESET) for Win32. Applied with small correction --- it

Re: [PATCHES] initdb of regression test failed.

2007-10-03 Thread Hiroshi Saito
Hi. regression test surely goes wrong.! hedule --multibyte=SQL_ASCII --load-language=plpgsql == creating temporary installation== == initializing database system == pg_regress: initdb failed Examine ./log/initdb.log for the

Re: [PATCHES] initdb of regression test failed.

2007-10-03 Thread Hiroshi Saito
Oops, patch of pg_regress.c should be disregarded. Sorry, I think this is desirable. Hi. regression test surely goes wrong.! hedule --multibyte=SQL_ASCII --load-language=plpgsql == creating temporary installation== == initializing database system

Re: [PATCHES] initdb of regression test failed.

2007-10-03 Thread ITAGAKI Takahiro
Hiroshi Saito [EMAIL PROTECTED] wrote: regression test surely goes wrong.! This fix does nothing against the regression failure. It is probably reasonable to choose UTF-8 as a server encoding when we cannot support the encoding of the current locale. A remaining issue is which we should use

Re: [PATCHES] initdb of regression test failed.

2007-10-03 Thread ITAGAKI Takahiro
I wrote: I'll suggest to use UTF8 if the encoding is UTF-8 or NOT specified and we don't support the locale encoding on Windows, i.e. locale is always enabled on regression tests. Here is a patch to do it on Windows. 1. Use UTF-8 if the locale encoding is not available for server. 2.

Re: [PATCHES] initdb of regression test failed.

2007-10-03 Thread Hiroshi Saito
Hi. Um, I thinks the examination material of 8.4 by the reason for changing the feature. Of course, your proposal can be considered to obtain one solution. Then, discussion is required more. I feel that it is dangerous for 8.3 Regards, Hiroshi Saito I wrote: I'll suggest to use UTF8

Re: [PATCHES] initdb of regression test failed.

2007-10-03 Thread Tom Lane
ITAGAKI Takahiro [EMAIL PROTECTED] writes: In fact, we can accept options like: initdb -E UTF8 --locale=Japanese_Japan.932 -- CP932 is SJIS in nature Hmm, but does that really work safely? I think varstr_cmp() does work, because it forces our data into wchar format and then calls wcscoll().

Re: [PATCHES] initdb of regression test failed.

2007-10-02 Thread Tom Lane
Hiroshi Saito [EMAIL PROTECTED] writes: The database cluster will be initialized with locale Japanese_Japan.932. initdb: could not find suitable encoding for locale Japanese_Japan.932 So, what encoding *should* we use for that locale? I think this is required We are certainly not going

Re: [PATCHES] initdb of regression test failed.

2007-10-02 Thread Hiroshi Saito
Hi. From: Tom Lane [EMAIL PROTECTED] Hiroshi Saito [EMAIL PROTECTED] writes: The database cluster will be initialized with locale Japanese_Japan.932. initdb: could not find suitable encoding for locale Japanese_Japan.932 So, what encoding *should* we use for that locale? I think this is

Re: [PATCHES] initdb of regression test failed.

2007-10-02 Thread ITAGAKI Takahiro
Hiroshi Saito [EMAIL PROTECTED] wrote: The database cluster will be initialized with locale Japanese_Japan.932. initdb: locale Japanese_Japan.932 requires unsupported encoding SJIS Encoding SJIS is not allowed as a server-side encoding. - I think that the check of this server side is the

Re: [PATCHES] initdb of regression test failed.

2007-10-02 Thread Hiroshi Saito
Hi. From: ITAGAKI Takahiro [EMAIL PROTECTED] Hiroshi Saito [EMAIL PROTECTED] wrote: The database cluster will be initialized with locale Japanese_Japan.932. initdb: locale Japanese_Japan.932 requires unsupported encoding SJIS Encoding SJIS is not allowed as a server-side encoding. - I think