Re: [PATCHES] make use of ld --as-needed

2005-05-04 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: The easiest fix is to make use of GNU ld's --as-needed flag, which ignores linker arguments that are not actually needed by the specified object files. The attached patch modifies configure to check for this flag (when using GNU ld), Minor gripe ---

Re: [PATCHES] make use of ld --as-needed

2005-05-04 Thread Neil Conway
Tom Lane wrote: Minor gripe --- what's the motivation for moving this down as you did? What do you mean by this? I moved the AC_MSG_NOTICEs for CPPFLAGS and LDFLAGS down below the --as-needed check, since the --as-needed check may modify LDFLAGS. Also, please s/same platforms/some platforms/

Re: [PATCHES] make use of ld --as-needed

2005-05-04 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: Tom Lane wrote: Minor gripe --- what's the motivation for moving this down as you did? What do you mean by this? I moved the AC_MSG_NOTICEs for CPPFLAGS and LDFLAGS down below the --as-needed check, since the --as-needed check may modify LDFLAGS.

Re: [PATCHES] make use of ld --as-needed

2005-05-04 Thread Neil Conway
Tom Lane wrote: Well, I guess the question is why you put the --as-needed check where you did, rather than above the existing AC_MSG_NOTICE displays. If it has an interaction with the intervening tests, what is that exactly? PGAC_PROG_LD needs to be invoked to figure out if we're using gnu ld.