-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Bruce Momjian
Sent: 07 January 2005 05:33
To: Andrew Dunstan
Cc: Patches (PostgreSQL)
Subject: Re: [PATCHES] pg_config MSVC makefile
This has been saved for the 8.1 release:
http
Dave Page wrote:
Err, I missed this earlier - we had discussed getting rid of all
the VC++ Borland makefiles for 8.1. With Mingw now working they
are a little redundant now, and Bruce I (and probably others) had
to jump through hoops to keep them working this release. Admittedley
that
As far as I know, there have been no real benchmarks done, however,
pgAdmin now ships with a Mingw compiled libpq where previous versions
used a (static) VC++ one and I've neither noticed any difference myself,
or had any reports of poor performance on the pgAdmin lists (or
privately) from other
Dave Page wrote:
Attached is a makefile I hacked up to build pg_config under
MSVC - the
reason is that it's required (more or less) in order to
build the latest
DBD::Pg code and I was testing that out under MSVC.
Err, I missed this earlier - we had discussed getting rid of all
-Original Message-
From: Bruce Momjian [mailto:[EMAIL PROTECTED]
Sent: 07 January 2005 15:14
To: Dave Page
Cc: Andrew Dunstan; Patches (PostgreSQL)
Subject: Re: [PATCHES] pg_config MSVC makefile
I am not in favor of removing those makefiles in 8.1 unless
they become
more
Bruce Momjian pgman@candle.pha.pa.us writes:
Dave Page wrote:
Err, I missed this earlier - we had discussed getting rid of all the
VC++ Borland makefiles for 8.1. With Mingw now working they are a
little redundant now,
I am not in favor of removing those makefiles in 8.1 unless they become
-Original Message-
From: Tom Lane [mailto:[EMAIL PROTECTED]
Sent: 07 January 2005 16:25
To: Bruce Momjian
Cc: Dave Page; Andrew Dunstan; Patches (PostgreSQL)
Subject: Re: [PATCHES] pg_config MSVC makefile
more of a pain. If people are submitting patches it means
Dave Page dpage@vale-housing.co.uk writes:
From: Tom Lane [mailto:[EMAIL PROTECTED]
I recall proposing a couple months ago that we kill those makefiles,
but there was at least one objection at the time.
My main concern is that they don't end up suffering terminal bit-rot
because I stop
-Original Message-
From: Tom Lane [mailto:[EMAIL PROTECTED]
Sent: 07 January 2005 17:07
To: Dave Page
Cc: Bruce Momjian; Andrew Dunstan; Patches (PostgreSQL)
Subject: Re: [PATCHES] pg_config MSVC makefile
Don't feel that it's on your head to keep them working. The project's
Dave Page wrote:
-Original Message-
From: Bruce Momjian [mailto:[EMAIL PROTECTED]
Sent: 07 January 2005 15:14
To: Dave Page
Cc: Andrew Dunstan; Patches (PostgreSQL)
Subject: Re: [PATCHES] pg_config MSVC makefile
I am not in favor of removing those makefiles in 8.1
This has been saved for the 8.1 release:
http:/momjian.postgresql.org/cgi-bin/pgpatches2
---
Andrew Dunstan wrote:
Attached is a makefile I hacked up to build pg_config under MSVC - the
reason is that it's
Zhenbang Wei wrote:
All messages translated
Installed.
--
Peter Eisentraut
http://developer.postgresql.org/~petere/
---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster
Euler Taveira de Oliveira wrote:
Here is a patch to available the first translation of pg_config. The
files attached needs to be in src/bin/pg_config. Basically, it is two
files (nls.mk, pt_BR.po) and one directory (po/).
Installed.
--
Peter Eisentraut
Patch applied. Thanks.
---
Euler Taveira de Oliveira wrote:
Hi,
This simple patch fixes a typo, ensure pg_config is removed in win32
and correct some splitted message mistake.
Please apply.
PS I'll send the
OK, addition made, and I added documentation for -pgxs.
---
Andrew Dunstan wrote:
Peter Eisentraut wrote:
Bruce Momjian wrote:
Oops, sorry, done.
The --pgxs option seems to have gotten lost in the
Patch applied. Thanks.
I made all the changes you suggested and the additions to path.c for the
new parameters.
---
Andrew Dunstan wrote:
There are a couple of things that need adjustment:
1. typo in the makefile -
Bruce Momjian wrote:
Patch applied. Thanks.
I made all the changes you suggested and the additions to path.c for
the new parameters.
I think you forgot to commit the new source files.
--
Peter Eisentraut
http://developer.postgresql.org/~petere/
---(end of
Bruce Momjian wrote:
Oops, sorry, done.
The --pgxs option seems to have gotten lost in the conversion.
--
Peter Eisentraut
http://developer.postgresql.org/~petere/
---(end of broadcast)---
TIP 7: don't forget to increase your free space map
Peter Eisentraut wrote:
Bruce Momjian wrote:
Oops, sorry, done.
The --pgxs option seems to have gotten lost in the conversion.
It wasn't there when I did the conversion. Usual problem of duelling
patches. Can you fix it, or do you need me to send in a patch?
cheers
andrew
Bruce Momjian wrote:
Andrew Dunstan wrote:
2. these cases need to be fixed:
else if (strcmp(argv[i],--includedir-server) ==0)
get_pkginclude_path(mypath,otherpath);
else if (strcmp(argv[i],--libdir) == 0)
Andrew Dunstan wrote:
I don't see a function there to report the libdir at all (only
pkglibdir), and for includedir-server we would need either to append
/server or to have a function in path.c that reported it for us
correctly.
These paths can all be more or less independently (or at least
Andrew Dunstan wrote:
There are a couple of things that need adjustment:
1. typo in the makefile - ((X) should be $(X)
OK.
2. these cases need to be fixed:
else if (strcmp(argv[i],--includedir-server) ==0)
get_pkginclude_path(mypath,otherpath);
There are a couple of things that need adjustment:
1. typo in the makefile - ((X) should be $(X)
2. these cases need to be fixed:
else if (strcmp(argv[i],--includedir-server) ==0)
get_pkginclude_path(mypath,otherpath);
else if
23 matches
Mail list logo
