Re: [PATCHES] pg_dump: fix crash on error

2005-07-26 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> [ scratches head... ] Did this code change recently? It's a tad hard >> to believe that such a thing could have gone unnoticed for long. > Seems the problem was introduced here: > http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bi

Re: [PATCHES] pg_dump: fix crash on error

2005-07-26 Thread Neil Conway
Tom Lane wrote: I'd go with reverting it to using PQdb, myself. Fair enough; reverted to using PQdb(), and applied to HEAD and REL8_0_STABLE. -Neil ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster

Re: [PATCHES] pg_dump: fix crash on error

2005-07-26 Thread Neil Conway
Tom Lane wrote: [ scratches head... ] Did this code change recently? It's a tad hard to believe that such a thing could have gone unnoticed for long. Seems the problem was introduced here: http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_backup_db.c.diff?r1=1.58;r2=1.59 (

Re: [PATCHES] pg_dump: fix crash on error

2005-07-26 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > If pg_dump fails to connect to Postgres, it attempts to print an error > message in ConnectDatabase(): > ... > But if no database is explicitly specified, `dbname' is NULL, and libc > is entitled to crash if you pass a NULL pointer to it for a %s > forma

Re: [PATCHES] pg_dump fix

2003-07-25 Thread Bruce Momjian
Patch applied. Thanks. --- Rod Taylor wrote: -- Start of PGP signed section. > Seems my check constraint change did break stuff. > > Alias the appropriate columns back to their original name. > > Fixed formatting of a f

Re: [PATCHES] pg_dump fix

2003-07-19 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --- Rod Taylor wrote: -- Start of PGP signed