Re: [PATCHES] remove unused "caller" arg from stringToQualifiedNameList

2007-06-25 Thread Tom Lane
"Jaime Casanova" <[EMAIL PROTECTED]> writes: > On 6/25/07, Alvaro Herrera <[EMAIL PROTECTED]> wrote: >> In any case, this is an exported symbol so maybe it's not a good idea to >> mess with it. OTOH I checked PL/R and PL/php and neither uses it, so >> this may not be a problem at all. > FWIW, we

Re: [PATCHES] remove unused "caller" arg from stringToQualifiedNameList

2007-06-25 Thread Jaime Casanova
On 6/25/07, Alvaro Herrera <[EMAIL PROTECTED]> wrote: Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > This function seems to have an argument that is no longer used (probably > > leftover from when it used to report an error message?). > > Yeah, I recall having left the argument

Re: [PATCHES] remove unused "caller" arg from stringToQualifiedNameList

2007-06-25 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > This function seems to have an argument that is no longer used (probably > > leftover from when it used to report an error message?). > > Yeah, I recall having left the argument in place because it seemed like > we might want it agai

Re: [PATCHES] remove unused "caller" arg from stringToQualifiedNameList

2007-06-25 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > This function seems to have an argument that is no longer used (probably > leftover from when it used to report an error message?). Yeah, I recall having left the argument in place because it seemed like we might want it again someday. But that was for