Re: [PATCHES] return_next for plperl

2005-06-04 Thread Bruce Momjian
Patch applied. Thanks. --- Abhijit Menon-Sen wrote: > At 2005-06-04 17:27:10 -0500, [EMAIL PROTECTED] wrote: > > > > > OK, would you please submit a patch to fix it. Thanks. > > > > I will unless someone beats me to it in

Re: [PATCHES] return_next for plperl

2005-06-04 Thread Abhijit Menon-Sen
At 2005-06-04 17:27:10 -0500, [EMAIL PROTECTED] wrote: > > > OK, would you please submit a patch to fix it. Thanks. > > I will unless someone beats me to it in the next 2 weeks Here's a patch to do the following: 1. Rename spi_return_next to return_next. 2. Add a new test for return_next. 3. Upda

Re: [PATCHES] return_next for plperl (was Re: call for help)

2005-06-04 Thread Andrew Dunstan
Bruce Momjian said: > Andrew Dunstan wrote: >> >> >> This has broken the regression tests for plperl - see for example >> >> http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=panda&dt=2005-06-04%2021:20:01>> That's because, as Abhijit noted in point 4 below, select foo_srf() no >> longer works. >>

Re: [PATCHES] return_next for plperl (was Re: call for help)

2005-06-04 Thread Bruce Momjian
Andrew Dunstan wrote: > > > This has broken the regression tests for plperl - see for example > > http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=panda&dt=2005-06-04%2021:20:01 > That's because, as Abhijit noted in point 4 below, select foo_srf() no > longer works. > > At a minimum those call

Re: [PATCHES] return_next for plperl (was Re: call for help)

2005-06-04 Thread Andrew Dunstan
This has broken the regression tests for plperl - see for example http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=panda&dt=2005-06-04%2021:20:01 That's because, as Abhijit noted in point 4 below, select foo_srf() no longer works. At a minimum those calls need to be removed from the regression

Re: [PATCHES] return_next for plperl (was Re: call for help)

2005-06-04 Thread Bruce Momjian
Mega-patch version applied. Thanks. --- Abhijit Menon-Sen wrote: > At 2005-05-21 20:18:50 +0530, [EMAIL PROTECTED] wrote: > > > > > The second issue is where plperl returns a large result set. > > I have attached the foll

Re: [Plperlng-devel] Re: [PATCHES] return_next for plperl (was Re: call

2005-06-02 Thread Andrew Dunstan
Neil Conway said: > On Sun, 2005-05-22 at 21:25 +0530, Abhijit Menon-Sen wrote: >> I have attached the following seven patches to address this problem: > > Does anyone with the skills to review this (i.e. someone other than me) > have any comments on this patch? > > Otherwise I'll apply it in a day

Re: [PATCHES] return_next for plperl (was Re: call for help)

2005-06-02 Thread Neil Conway
On Sun, 2005-05-22 at 21:25 +0530, Abhijit Menon-Sen wrote: > I have attached the following seven patches to address this problem: Does anyone with the skills to review this (i.e. someone other than me) have any comments on this patch? Otherwise I'll apply it in a day or two. -Neil --