Re: [PATCHES] rmtree cleanup
Tom Lane wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: The attached patch cleans up src/port/dirmod.c::rmtree() a bit. It moves the filename finding portion into its own function, and in that function only scans the directory once instead of twice. Applied, along with some further hacking to reduce the #ifdef clutter by providing palloc substitute routines. Nice. It's actually readable now :-) I checked it still works on Unix, would you check I didn't break the Windows cases? Yes, it works. Thanks. andrew ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs/FAQ.html
Re: [PATCHES] rmtree cleanup
Andrew Dunstan <[EMAIL PROTECTED]> writes: > The attached patch cleans up src/port/dirmod.c::rmtree() a bit. It moves > the filename finding portion into its own function, and in that function > only scans the directory once instead of twice. Applied, along with some further hacking to reduce the #ifdef clutter by providing palloc substitute routines. I checked it still works on Unix, would you check I didn't break the Windows cases? regards, tom lane ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
