Re: [PATCHES] suggested warning about perl nested named subroutines

2005-10-23 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 One more annoyance, while I'm here: what's with spi_exec_query()? Is that the best name we could come up with? How about something short and simple, in the same vein as elog(), such as sql() ? :) I don't much like it either. But it's there from

Re: [PATCHES] suggested warning about perl nested named subroutines

2005-10-12 Thread Bruce Momjian
Patch applied. Thanks. --- Andrew Dunstan wrote: I propose to add the following to the plperl docs, following recent problems. comments? cheers andrew Index: plperl.sgml

Re: [PATCHES] suggested warning about perl nested named subroutines

2005-10-12 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 If this were a Postgres problem I'd agree with you. But it isn't, really - it's a Perl problem, which is properly documented in the Perl docs, to which this note refers. Well, it's really a problem with our implementation of pl/perl. I don't

Re: [PATCHES] suggested warning about perl nested named subroutines

2005-10-12 Thread Andrew Dunstan
Greg Sabino Mullane wrote: If this were a Postgres problem I'd agree with you. But it isn't, really - it's a Perl problem, which is properly documented in the Perl docs, to which this note refers. Well, it's really a problem with our implementation of pl/perl. I don't think it's

Re: [PATCHES] suggested warning about perl nested named subroutines

2005-10-11 Thread David Fetter
On Tue, Oct 11, 2005 at 08:40:21PM -0400, Andrew Dunstan wrote: I propose to add the following to the plperl docs, following recent problems. comments? Examples of each and how they'd break would be good. Cheers, D cheers andrew Index: plperl.sgml

Re: [PATCHES] suggested warning about perl nested named subroutines

2005-10-11 Thread Neil Conway
On Tue, 2005-11-10 at 18:36 -0700, David Fetter wrote: Examples of each and how they'd break would be good. Is that needed? Seems like overkill to me. -Neil ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings

Re: [PATCHES] suggested warning about perl nested named subroutines

2005-10-11 Thread Andrew Dunstan
David Fetter wrote: On Tue, Oct 11, 2005 at 09:58:22PM -0400, Neil Conway wrote: On Tue, 2005-11-10 at 18:36 -0700, David Fetter wrote: Examples of each and how they'd break would be good. Is that needed? Seems like overkill to me. IMHO, yes, and no, respectively. If

Re: [PATCHES] suggested warning about perl nested named subroutines

2005-10-11 Thread Neil Conway
On Tue, 2005-11-10 at 18:55 -0700, David Fetter wrote: IMHO, yes, and no, respectively. If there's an example, there's fewer frustrated people pestering lists about it. There is something to be said for brevity: spending a lot of prose on an example of an obscure problem means the

Re: [PATCHES] suggested warning about perl nested named subroutines

2005-10-11 Thread David Fetter
On Tue, Oct 11, 2005 at 10:01:02PM -0400, Andrew Dunstan wrote: David Fetter wrote: On Tue, Oct 11, 2005 at 09:58:22PM -0400, Neil Conway wrote: On Tue, 2005-11-10 at 18:36 -0700, David Fetter wrote: Examples of each and how they'd break would be good. Is that needed? Seems like