Re: [PATCHES] vacuum hint on elog

2005-01-22 Thread Neil Conway
Alvaro Herrera wrote: Hmm ... I think you should rather use a PG_TRY/PG_CATCH block. Thanks for the suggestion, Alvaro -- I think that's a better way to go. It means we can keep vacuum-specific stuff in vacuum.c, rather than adding to AbortTransaction(). I'll post a revised patch tomorrow.

Re: [PATCHES] vacuum hint on elog

2005-01-22 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: It occurred to me that if we elog(ERROR) during VACUUM, the vacuum activity hint will not be reset. The code beginning at freelist.c line 645 is intended to deal with this. Attached is a patch which resets the vacuum activity hint in

Re: [PATCHES] vacuum hint on elog

2005-01-22 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: Tom Lane wrote: The code beginning at freelist.c line 645 is intended to deal with this. Ah, good point -- sorry, I missed that. The code as-is should be fine, then. Well, one point is that the flag bit is checked elsewhere in the same file without

Re: [PATCHES] vacuum hint on elog

2005-01-22 Thread Neil Conway
Tom Lane wrote: The code beginning at freelist.c line 645 is intended to deal with this. Ah, good point -- sorry, I missed that. The code as-is should be fine, then. -Neil ---(end of broadcast)--- TIP 2: you can get off all lists at once with the