Re: [PATCHES] vcbuild bison check

2006-10-04 Thread Bruce Momjian
Magnus Hagander wrote: > > >>> Attached patch adds a version check for bison when running the > > vc++ > > >>> build. > > >> > > >> Shouldn't it be looking for 2.1 as well? > > > > > 2.1 is the broken one. > > > > Exactly. So we should reject it. > > We do. The code as-is *only* accepts 1.875.

Re: [PATCHES] vcbuild bison check

2006-10-04 Thread Magnus Hagander
> >>> Attached patch adds a version check for bison when running the > vc++ > >>> build. > >> > >> Shouldn't it be looking for 2.1 as well? > > > 2.1 is the broken one. > > Exactly. So we should reject it. We do. The code as-is *only* accepts 1.875. Thus it rejects 2.1. //Magnus -

Re: [PATCHES] vcbuild bison check

2006-10-03 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: >>> Attached patch adds a version check for bison when running the vc++ >>> build. >> >> Shouldn't it be looking for 2.1 as well? > 2.1 is the broken one. Exactly. So we should reject it. > It seemd it was fixed in 2.2, but 2.2 isn't > realeased f

Re: [PATCHES] vcbuild bison check

2006-10-03 Thread Magnus Hagander
> > Attached patch adds a version check for bison when running the vc++ > > build. > > Shouldn't it be looking for 2.1 as well? 2.1 is the broken one. It seemd it was fixed in 2.2, but 2.2 isn't realeased for win32 from what I cna tell. //Magnus ---(end of broadcast)---

Re: [PATCHES] vcbuild bison check

2006-10-03 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > Attached patch adds a version check for bison when running the vc++ > build. Shouldn't it be looking for 2.1 as well? regards, tom lane ---(end of broadcast)--- TIP 6: explain