Re: [PATCHES] vcbuild bison check
Magnus Hagander wrote: > > >>> Attached patch adds a version check for bison when running the > > vc++ > > >>> build. > > >> > > >> Shouldn't it be looking for 2.1 as well? > > > > > 2.1 is the broken one. > > > > Exactly. So we should reject it. > > We do. The code as-is *only* accepts 1.875. Thus it rejects 2.1. I think Tom's point is that we should reject only 2.1. Isn't that the only version that fails? -- Bruce Momjian [EMAIL PROTECTED] EnterpriseDBhttp://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [PATCHES] vcbuild bison check
> >>> Attached patch adds a version check for bison when running the > vc++ > >>> build. > >> > >> Shouldn't it be looking for 2.1 as well? > > > 2.1 is the broken one. > > Exactly. So we should reject it. We do. The code as-is *only* accepts 1.875. Thus it rejects 2.1. //Magnus ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster
Re: [PATCHES] vcbuild bison check
"Magnus Hagander" <[EMAIL PROTECTED]> writes: >>> Attached patch adds a version check for bison when running the vc++ >>> build. >> >> Shouldn't it be looking for 2.1 as well? > 2.1 is the broken one. Exactly. So we should reject it. > It seemd it was fixed in 2.2, but 2.2 isn't > realeased for win32 from what I cna tell. What's that got to do with rejecting 2.1? regards, tom lane ---(end of broadcast)--- TIP 6: explain analyze is your friend
Re: [PATCHES] vcbuild bison check
> > Attached patch adds a version check for bison when running the vc++ > > build. > > Shouldn't it be looking for 2.1 as well? 2.1 is the broken one. It seemd it was fixed in 2.2, but 2.2 isn't realeased for win32 from what I cna tell. //Magnus ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [PATCHES] vcbuild bison check
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > Attached patch adds a version check for bison when running the vc++ > build. Shouldn't it be looking for 2.1 as well? regards, tom lane ---(end of broadcast)--- TIP 6: explain analyze is your friend
