Re: [PATCHES] win32 readline

2004-08-02 Thread Bruce Momjian
Where are we on this? Right now readline is disabled on Win32. psql works fine for me. In fact it is more native because the delete key deletes, and control-d doesn't exit. I am inclined to leave the code unchanged and we can revisit this later after we figure out why readline doesn't work on

Re: [PATCHES] win32 readline

2004-08-02 Thread Marc G. Fournier
On Mon, 2 Aug 2004, Bruce Momjian wrote: Where are we on this? Right now readline is disabled on Win32. psql works fine for me. In fact it is more native because the delete key deletes, and control-d doesn't exit. I am inclined to leave the code unchanged and we can revisit this later after we

Re: [PATCHES] win32 readline

2004-08-02 Thread Peter Eisentraut
Marc G. Fournier wrote: Stupid question, but for Windows ... how many will actually use psql, vs something like PgAdmin? I don't see any reason to believe that it would be significantly less than now. I'd say revisit it later myself ... it isn't critical to the operation of the server, only

Re: [PATCHES] win32 readline

2004-07-23 Thread Magnus Hagander
Magnus Hagander wrote: Just for reference, what features are we losing without readline. Tab completion, but what more? Command history, customizable key bindings, cut and paste, cursor keys come to mind. Command history, cut-and-paste and cursor keys definitly work in my build

Re: [PATCHES] win32 readline

2004-07-22 Thread Magnus Hagander
Hmm. And this is a cvs pull that was before Bruce actually disabled readline? What locale are you in? Actually, I just just typed away in the bash shell, which uses readline as well. Ok, then we're testing completely different things. I'm talking about the psql client when running under

Re: [PATCHES] win32 readline

2004-07-22 Thread Peter Eisentraut
Magnus Hagander wrote: Ok, then we're testing completely different things. I'm talking about the psql client when running under CMD.EXE, *not* in the msys shell. (backslash works fine in the bash shell) OK, I'll try that later. As an additional data point, running sh.exe from within cmd.exe

Re: [PATCHES] win32 readline

2004-07-22 Thread Magnus Hagander
Magnus Hagander wrote: Ok, then we're testing completely different things. I'm talking about the psql client when running under CMD.EXE, *not* in the msys shell. (backslash works fine in the bash shell) OK, I'll try that later. As an additional data point, running sh.exe from within cmd.exe

Re: [PATCHES] win32 readline

2004-07-22 Thread Peter Eisentraut
Magnus Hagander wrote: Just for reference, what features are we losing without readline. Tab completion, but what more? Command history, customizable key bindings, cut and paste, cursor keys come to mind. -- Peter Eisentraut http://developer.postgresql.org/~petere/

Re: [PATCHES] win32 readline

2004-07-21 Thread Magnus Hagander
Hmm. And this is a cvs pull that was before Bruce actually disabled readline? What locale are you in? Peter - what OS are you on, and what mingw version? And what locale? I've done my tests on Win XP, and it elcearly does not work (locale = Swedish). I've also talked to Merlin, and he had the

Re: [PATCHES] win32 readline

2004-07-21 Thread Mark Cave-Ayland
: [PATCHES] win32 readline Hmm. And this is a cvs pull that was before Bruce actually disabled readline? What locale are you in? Peter - what OS are you on, and what mingw version? And what locale? I've done my tests on Win XP, and it elcearly does not work (locale = Swedish). I've also

Re: [PATCHES] win32 readline

2004-07-21 Thread Magnus Hagander
has been fixed by the disabling of readline) //Magnus -Original Message- From: Mark Cave-Ayland [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 21, 2004 12:38 PM To: Magnus Hagander; 'Mark Kirkwood'; 'Peter Eisentraut' Cc: [EMAIL PROTECTED] Subject: RE: [PATCHES] win32 readline

Re: [PATCHES] win32 readline

2004-07-21 Thread Mark Cave-Ayland
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Magnus Hagander Sent: 21 July 2004 11:49 To: Mark Cave-Ayland Cc: [EMAIL PROTECTED] Subject: Re: [PATCHES] win32 readline The locale that's interesting is the Windows locale, not the pg one

Re: [PATCHES] win32 readline

2004-07-21 Thread Mark Kirkwood
- CVS HEAD from approx 19 Jul - locale is 'English_New Zealand.1252' Magnus Hagander wrote: Hmm. And this is a cvs pull that was before Bruce actually disabled readline? What locale are you in? ---(end of broadcast)--- TIP 5: Have you checked our

Re: [PATCHES] win32 readline

2004-07-21 Thread Mark Kirkwood
Sorry - I have done it too: Windows Locale is : English (New Zealand) Mark Kirkwood wrote: - CVS HEAD from approx 19 Jul - locale is 'English_New Zealand.1252' Magnus Hagander wrote: Hmm. And this is a cvs pull that was before Bruce actually disabled readline? What locale are you in?

Re: [PATCHES] win32 readline

2004-07-21 Thread Peter Eisentraut
Magnus Hagander wrote: Hmm. And this is a cvs pull that was before Bruce actually disabled readline? What locale are you in? Actually, I just just typed away in the bash shell, which uses readline as well. Peter - what OS are you on, and what mingw version? And what locale? Windows XP Pro,

Re: [PATCHES] win32 readline

2004-07-20 Thread Bruce Momjian
Magnus Hagander wrote: Readline is pretty badly broken under mingw. Basically, it disables the alt-gr key, which renders psql almost useless on most locales (no way to type backslash, and a whole lot of other characters, for example). This patch disables readline on win32. (meaning it's back

Re: [PATCHES] win32 readline

2004-07-20 Thread Peter Eisentraut
Magnus Hagander wrote: Readline is pretty badly broken under mingw. Basically, it disables the alt-gr key, which renders psql almost useless on most locales (no way to type backslash, and a whole lot of other characters, for example). I can't reproduce that. It works perfectly fine here. --

Re: [PATCHES] win32 readline

2004-07-20 Thread Bruce Momjian
Peter Eisentraut wrote: Magnus Hagander wrote: Readline is pretty badly broken under mingw. Basically, it disables the alt-gr key, which renders psql almost useless on most locales (no way to type backslash, and a whole lot of other characters, for example). I can't reproduce that. It

Re: [PATCHES] win32 readline

2004-07-20 Thread Mark Kirkwood
To add to the confusion it works for me as well - Windows 2003 with Mingw 3.1.0 Peter Eisentraut wrote: Magnus Hagander wrote: Readline is pretty badly broken under mingw. Basically, it disables the alt-gr key, which renders psql almost useless on most locales (no way to type backslash, and