Re: [PATCHES] zic with msvc

2006-10-20 Thread Tom Lane 
Magnus Hagander [EMAIL PROTECTED] writes:
 + #ifdef WIN32
 + #define _WIN32_WINNT 0x0400
 + #endif

Hmm ... in pg_ctl.c I see

#define _WIN32_WINNT 0x0500

Is there a reason for these to be different?  Are there other places
that will need this (ie, maybe it should be in c.h instead?)

regards, tom lane

---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster

Re: [PATCHES] zic with msvc

2006-10-20 Thread Magnus Hagander 
  + #ifdef WIN32
  + #define _WIN32_WINNT 0x0400
  + #endif
 
 Hmm ... in pg_ctl.c I see
 
 #define _WIN32_WINNT 0x0500
 
 Is there a reason for these to be different?  Are there other 
 places that will need this (ie, maybe it should be in c.h instead?)

Not really. The default appears to be 0x0400 for MingW (or it wouldn't
have worked before), but 0x0350 or so for Visual C++.
If we define it to 0x0500 we pull in headers that will only work on 2000
or newer. But I don't really see that as a problem - I think we said
that we don't care about earlier ones anyway. in which case it's
definitly not a problem to stick it in c.h.

//Magnus

---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster