Patch applied. Thanks.
---
Dave Page wrote:
Tom Lane wrote:
Dave Page [EMAIL PROTECTED] writes:
OK, updated patch attached. This has
-E dbname or --default-database=dbname
Not sure that default database is a
Tom Lane wrote:
Dave Page [EMAIL PROTECTED] writes:
OK, updated patch attached. This has
-E dbname or --default-database=dbname
Not sure that default database is a particularly helpful adjective;
why shouldn't the switch just be --database?
Other than that, looks fine.
Updated to -l,
Am Montag, 15. Januar 2007 14:44 schrieb Dave Page:
Per discussion on -hackers, the attached patch allow the default
database to be specified on the pg_dumpall command line, eg.
pg_dumpall [options...] [dbname]
I think this should be a separate option. Otherwise it would be too easy to
Peter Eisentraut wrote:
Am Montag, 15. Januar 2007 14:44 schrieb Dave Page:
Per discussion on -hackers, the attached patch allow the default
database to be specified on the pg_dumpall command line, eg.
pg_dumpall [options...] [dbname]
I think this should be a separate option. Otherwise it
On Mon, 2007-01-15 at 17:07 +, Dave Page wrote:
You're thinking the user might expect it dump all of that database? Not
sure I agree with that, but I'm not wedded to the syntax. Any other
opinions?
I agree with Peter: specifying the database name as implemented seems
like it would be prone
Dave Page [EMAIL PROTECTED] writes:
OK, updated patch attached. This has
-E dbname or --default-database=dbname
Not sure that default database is a particularly helpful adjective;
why shouldn't the switch just be --database?
Other than that, looks fine.
regards, tom
Dave Page wrote:
I agree with Peter: specifying the database name as implemented seems
like it would be prone to confusion.
OK, updated patch attached. This has
-E dbname or --default-database=dbname
Ouch. This calls for confusion with the -E flag of pg_dump,
which means 'encoding'.
