Re: Domain check taking place unnecessarily?

2023-02-08 Thread Laurenz Albe
On Wed, 2023-02-08 at 18:01 +, Mark Hills wrote: > I've ruled out waiting on a lock; nothing is reported with > log_lock_waits=on. This is a test database with exclusive access (2.5 > million rows): > > This is PostgreSQL 14.5 on Alpine Linux. Thanks. > > CREATE DOMAIN hash AS text >    

max_wal_senders

2023-02-08 Thread Rick Otten
I've been thinking about the max_wal_senders parameter lately and wondering if there is any harm in setting it too high. I'm wondering if I should try to shave a few senders off, perhaps to match my logical replicas + 1, instead of just leaving it at the default of 10. Or vice-versa, can clients

Window Functions & Table Partitions

2023-02-08 Thread Benjamin Tingle
Hell postgres people! This is not an issue report so much as a gripe. I'm on postgres 12.2, so it is entirely possible that the issue I describe is fixed in a later version. If so, it is not described in the docs or any posts I can find archived on pgsql-performance. (I am not brave enough to

Re: Window Functions & Table Partitions

2023-02-08 Thread David Rowley
On Thu, 9 Feb 2023 at 10:45, Benjamin Tingle wrote: > Basically- window partition functions don't take advantage of existing table > partitions. I use window functions as a more powerful GROUP BY clause that > preserves row-by-row information- super handy for a lot of things. > > In particular,

Re: max_wal_senders

2023-02-08 Thread Andres Freund
Hi, On 2023-02-09 06:59:53 +0100, Laurenz Albe wrote: > On Wed, 2023-02-08 at 18:07 -0500, Rick Otten wrote: > > I've been thinking about the max_wal_senders parameter lately and wondering > > if there > > is any harm in setting it too high. > > No, there isn't, except that if you end up having

Re: max_wal_senders

2023-02-08 Thread Laurenz Albe
On Wed, 2023-02-08 at 18:07 -0500, Rick Otten wrote: > I've been thinking about the max_wal_senders parameter lately and wondering > if there > is any harm in setting it too high. No, there isn't, except that if you end up having too many *actual* WAL senders, it will cause load. A high limit

Domain check taking place unnecessarily?

2023-02-08 Thread Mark Hills
I'm used to adding an empty column being instant in most cases, so my attention was drawn when it took a long lock. The timings below imply that each row is running the CHECK? I've come to expect addition of a NULL column to be fast, and what I'm seeing seems to contradict the docs [1]: >

Re: Domain check taking place unnecessarily?

2023-02-08 Thread David G. Johnston
On Wed, Feb 8, 2023 at 11:01 AM Mark Hills wrote: > > CREATE DOMAIN hash AS text > CHECK (VALUE ~ E'^[a-zA-Z0-9]{8,32}$'); > > devstats=> ALTER TABLE invite ADD COLUMN test hash; > ALTER TABLE > Time: 30923.380 ms (00:30.923) > Necessarily, I presume because if you decided that the check on