Re: [PERFORM] Memory leak tsearch2 VACUUM FULL VERBOSE ANALYZE

2004-12-23 Thread Tom Lane
Pailloncy Jean-Gerard [EMAIL PROTECTED] writes:
 I think I have a test case for 7.4.2

Try the attached patch.

It looked to me like there were some smaller leaks going on during COPY
and CREATE INDEX, which I will look into later --- but this seems to be
the problem for VACUUM FULL.

regards, tom lane

Index: vacuum.c
===
RCS file: /cvsroot/pgsql/src/backend/commands/vacuum.c,v
retrieving revision 1.263
diff -c -r1.263 vacuum.c
*** vacuum.c2 Oct 2003 23:19:44 -   1.263
--- vacuum.c23 Dec 2004 22:37:57 -
***
*** 2041,2046 
--- 2041,2047 
ExecStoreTuple(newtup, slot, 
InvalidBuffer, false);
ExecInsertIndexTuples(slot, 
(newtup.t_self),

  estate, true);
+   
ResetPerTupleExprContext(estate);
}
  
WriteBuffer(cur_buffer);
***
*** 2174,2179 
--- 2175,2181 
{
ExecStoreTuple(newtup, slot, InvalidBuffer, 
false);
ExecInsertIndexTuples(slot, (newtup.t_self), 
estate, true);
+   ResetPerTupleExprContext(estate);
}
}   /* walk along 
page */
  

---(end of broadcast)---
TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]


Re: [PERFORM] Memory leak tsearch2 VACUUM FULL VERBOSE ANALYZE

2004-12-22 Thread Tom Lane
Pailloncy Jean-Gerard [EMAIL PROTECTED] writes:
 I think I have a test case for 7.4.2

Can you send me the test data (off-list)?

regards, tom lane

---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster