[Pharo-dev] Re: Question about MethodDictionary in TraitedClass (methodDict/localMethodDict)

2022-05-12 Thread Marcus Denker
> On 12 May 2022, at 11:27, Andrei Chis wrote: > > Hi, > > We were profiling the loading of code that uses many Traits. We saw something > like this (this is a tally for > `TraitedMetaclass>>#addAndClassifySelector:withMethod:inProtocol:`): > > > From what we saw in >

[Pharo-dev] About Pull Request Reviews: Multiple Reviews are best!

2022-05-12 Thread Marcus Denker
Hi, If you see that a PR that you wanted to review already has a positive review, do not think “ah, nothing to be done for me”. Because imagine if the PR would be bad: you would add a comment how to improve in addition to the one already positive review. You should do the same even if you just