Re: [Pharo-dev] [Review needed] fix for Pharo2 text highlighting incorrect

2013-11-28 Thread Goubier Thierry
Le 27/11/2013 20:36, Stéphane Ducasse a écrit : That's me the solution provided doesn't work very well either. I would need to spend time on the code used to highlight the selection and reuse it for highlights, but I was on a tight schedule for a demo so I decided to use the selection

Re: [Pharo-dev] [Review needed] fix for Pharo2 text highlighting incorrect

2013-11-28 Thread Clément Bera
Are you talking about text highlighting in the debugger or is this not related ? 2013/11/28 Goubier Thierry thierry.goub...@cea.fr Le 27/11/2013 20:36, Stéphane Ducasse a écrit : That's me the solution provided doesn't work very well either. I would need to spend time on the code

Re: [Pharo-dev] [Review needed] fix for Pharo2 text highlighting incorrect

2013-11-28 Thread Stéphane Ducasse
That's sad; I was seriously interested in seeing what Igor has managed to do. Normally there is an up to dat configuration in the Athens and TextModel repository. Now he is back working on it. But please have a look we need clients pushing igor. Igor is overwhelmed by questions :) But the

[Pharo-dev] [Review needed] fix for Pharo2 text highlighting incorrect

2013-11-27 Thread Marcus Denker
12241 text highlighting incorrect https://pharo.fogbugz.com/f/cases/12241 What needs to be done? - does it fix the bug? - Is the fix plausibly ok? - Is this a problem in Pharo3, too? If yes — add issue for back porting, - make

Re: [Pharo-dev] [Review needed] fix for Pharo2 text highlighting incorrect

2013-11-27 Thread Goubier Thierry
That's me the solution provided doesn't work very well either. I would need to spend time on the code used to highlight the selection and reuse it for highlights, but I was on a tight schedule for a demo so I decided to use the selection instead (and gave up for now on refactoring that code

Re: [Pharo-dev] [Review needed] fix for Pharo2 text highlighting incorrect

2013-11-27 Thread Stéphane Ducasse
That's me the solution provided doesn't work very well either. I would need to spend time on the code used to highlight the selection and reuse it for highlights, but I was on a tight schedule for a demo so I decided to use the selection instead (and gave up for now on refactoring that