Re: [Pharo-dev] Commenting the Session Manager

2017-04-27 Thread Guillermo Polito
I meant to change the comment and leave the code as is... On Wed, Apr 26, 2017 at 6:25 PM, Ben Coman wrote: > eh! sorry, thats way too confusing to leave alone. > I meant... I'm not sure I properly understand. > > > On Thu, Apr 27, 2017 at 12:17 AM, Ben Coman

Re: [Pharo-dev] Commenting the Session Manager

2017-04-26 Thread Ben Coman
eh! sorry, thats way too confusing to leave alone. I meant... I'm not sure I properly understand. On Thu, Apr 27, 2017 at 12:17 AM, Ben Coman wrote: > I'm sure I properly understand, you mean to change the behaviour rather > than the comment? > My naive understanding and

Re: [Pharo-dev] Commenting the Session Manager

2017-04-26 Thread Ben Coman
I'm sure I properly understand, you mean to change the behaviour rather than the comment? My naive understanding and intuition is the current behaviour is fine. What do you see wrong with it? cheers -ben On Wed, Apr 26, 2017 at 11:46 PM, Guillermo Polito < guillermopol...@gmail.com> wrote: > Hi

Re: [Pharo-dev] Commenting the Session Manager

2017-04-26 Thread Guillermo Polito
Hi Ben, true. This happens because of this line: "create a new session object if we're booting" isImageStarting ifTrue: [ self installNewSession ]. in SessionManager>>snapshot:andQuit: I'd say we should not change this now, but we should fix it for pharo 7. On Tue, Apr 18, 2017 at 6:15 PM,

Re: [Pharo-dev] Commenting the Session Manager

2017-04-18 Thread Ben Coman
hi Guille, Thanks very much for that detailed write up. I have one concern about the [bracketed] text... A new session starts when the image starts [or when the image is saved]. A session ends when the image quits [or it is saved]. Doing the following in a playground... s1 :=

Re: [Pharo-dev] Commenting the Session Manager

2017-04-17 Thread Juraj Kubelka
I like it! :-) Maybe it could also goes to the Help Browser, because it is quite extensive. Juraj > On Apr 13, 2017, at 06:41, Guillermo Polito wrote: > > Hi all, > > I took some minutes to write down a class comment for the SessionManager > class. There was an