Re: [Pharo-dev] Fwd: [GitHub] Deprecation Notice

2020-01-22 Thread ducasse
Thanks pablo. This is the typical example that even if we do not want to do things the world is pushing us. So good code always pays because change is the only constant. S > On 22 Jan 2020, at 09:59, teso...@gmail.com wrote: > > Yes, it is the PR creation API. I have started to add support

Re: [Pharo-dev] Fwd: [GitHub] Deprecation Notice

2020-01-22 Thread Alistair Grant
Hi Stef & Guille, I received the same deprecation notice as Stef on 13 December. I've also just seen an `IceGitHubError: Not Found` error: IceGitHubAPI>>responseWithValidationDo: IceGitHubAPI>>contentsWithValidationDo: IceGitHubAPI>>jsonContentsWithValidationDo: IceGitHubAPI>>get:

Re: [Pharo-dev] Fwd: [GitHub] Deprecation Notice

2020-01-22 Thread teso...@gmail.com
Yes, it is the PR creation API. I have started to add support to tokens in a nice way. I can push it to the next version. On Wed, Jan 22, 2020 at 9:55 AM ducasse wrote: > > > > > On 22 Jan 2020, at 09:48, Guillermo Polito > > wrote: > > > > Did you re-clone your repository? I don’t think so… >

Re: [Pharo-dev] Fwd: [GitHub] Deprecation Notice

2020-01-22 Thread ducasse
> On 22 Jan 2020, at 09:48, Guillermo Polito wrote: > > Did you re-clone your repository? I don’t think so… no > Did you create a PR using Pharo’s github integration? Yes I did this. > Those are the only points we use Github’s API :/ Ok we found it :) > >> El 22 ene 2020, a las 9:13,

Re: [Pharo-dev] Fwd: [GitHub] Deprecation Notice

2020-01-22 Thread Guillermo Polito
Did you re-clone your repository? I don’t think so… Did you create a PR using Pharo’s github integration? Those are the only points we use Github’s API :/ > El 22 ene 2020, a las 9:13, ducasse escribió: > > I was just committing to my pharo fork “….using Zinc HTTP Components 1.0 > (Pharo/9.0)

Re: [Pharo-dev] Fwd: [GitHub] Deprecation Notice

2020-01-22 Thread ducasse
I was just committing to my pharo fork “….using Zinc HTTP Components 1.0 (Pharo/9.0) ...” so I do not get fully get it. If I’m the only one to receive this mail then this is ok Guille apparently I used password else it would have failed? Can it be that my password is not well set? I have

Re: [Pharo-dev] Fwd: [GitHub] Deprecation Notice

2020-01-21 Thread Guillermo Polito
Hi, I believe that when cloning a repository using the Github tab from iceberg, iceberg makes a request to ask github for that project’s meta-data. This query identifies if the cloned repository is a fork of another repository or not, and in case it is a fork, correctly pre-configure the

Re: [Pharo-dev] Fwd: [GitHub] Deprecation Notice

2020-01-21 Thread Sven Van Caekenberghe
We probably have to change something. Do you know which operation (GitHub API access from Pharo code) is responsible for this ? > On 21 Jan 2020, at 21:05, ducasse wrote: > > what will be the implication? > > >> Begin forwarded message: >> >> From: GitHub >> Subject: [GitHub] Deprecation

Re: [Pharo-dev] Fwd: [GitHub] Deprecation Notice

2020-01-21 Thread Gabriel Cotelli
You can create a personal access token and use it instead of the password. For example when setting the iceberg credentials. So, I think there's no problem per se. On Tue, Jan 21, 2020, 17:06 ducasse wrote: > what will be the implication? > > > Begin forwarded message: > > *From: *GitHub >

[Pharo-dev] Fwd: [GitHub] Deprecation Notice

2020-01-21 Thread ducasse
what will be the implication? > Begin forwarded message: > > From: GitHub > Subject: [GitHub] Deprecation Notice > Date: 21 January 2020 at 21:03:28 CET > To: StéphaneDucasse > > Hi @Ducasse, > > You recently used a password to access an endpoint through the GitHub API > using Zinc HTTP