Re: [Pharo-dev] ZdcAbstractSocketStream>>peekFor:?

2019-03-22 Thread Sven Van Caekenberghe
I accepted it, thanks for the PR! > On 17 Mar 2019, at 08:45, Alistair Grant wrote: > > Hi Sven, > > > On Sat, 16 Mar 2019 at 20:28, Sven Van Caekenberghe wrote: >> >> Here please, https://github.com/svenvc/zodiac > > Done. The changes were made in Pharo 8 and it's added lots of >

Re: [Pharo-dev] ZdcAbstractSocketStream>>peekFor:?

2019-03-17 Thread Alistair Grant
Hi Sven, On Sat, 16 Mar 2019 at 20:28, Sven Van Caekenberghe wrote: > > Here please, https://github.com/svenvc/zodiac Done. The changes were made in Pharo 8 and it's added lots of methodProperties.json files. I assume this is because you haven't had to make changes since Iceberg was

Re: [Pharo-dev] ZdcAbstractSocketStream>>peekFor:?

2019-03-16 Thread Sven Van Caekenberghe
Here please, https://github.com/svenvc/zodiac > On 16 Mar 2019, at 20:23, Alistair Grant wrote: > > Hi Sven, > > On Sat, 16 Mar 2019 at 20:16, Sven Van Caekenberghe wrote: >> >> Since there is #peek there is no reason not to add #peekFor: as >> >> peekFor: object >> "Answer false and do

Re: [Pharo-dev] ZdcAbstractSocketStream>>peekFor:?

2019-03-16 Thread Sven Van Caekenberghe
Since there is #peek there is no reason not to add #peekFor: as peekFor: object "Answer false and do not move over the next element if it is not equal to object, or if the receiver is at the end. Answer true and move over the next element when it is equal to object." ^ self peek =

Re: [Pharo-dev] ZdcAbstractSocketStream>>peekFor:?

2019-03-16 Thread Alistair Grant
Hi Esteban, On Sat, 16 Mar 2019 at 19:37, Esteban Maringolo wrote: > > I don't know the answer but how could you peek for data that has yet not come > through the socket? In the buffer? Should it block? >From memory: It depends on the mode of the stream: If synchronous: peeking will block

Re: [Pharo-dev] ZdcAbstractSocketStream>>peekFor:?

2019-03-16 Thread Esteban Maringolo
I don't know the answer but how could you peek for data that has yet not come through the socket? In the buffer? Should it block? Regards. El sáb., 16 de mar. de 2019 12:23, Alistair Grant escribió: > Hi Sven, > > Unlike most streams that support #peek, ZdcAbstractSocketStream > doesn't

[Pharo-dev] ZdcAbstractSocketStream>>peekFor:?

2019-03-16 Thread Alistair Grant
Hi Sven, Unlike most streams that support #peek, ZdcAbstractSocketStream doesn't support #peekFor:. Is this intentional, or an oversight? Thanks, Alistair