Re: [Pharo-dev] ensure: and assignments RB Rule

Sent from my iPhone > On Sep 7, 2015, at 2:16 PM, Nicolai Hess wrote: > > *Now* I understand this rule. Hi Nicolai, points to the need for some very good doc for these rules :-) > > 2015-09-02 3:40 GMT+02:00 Eliot Miranda : >> >> >>> On Tue,

Re: [Pharo-dev] ensure: and assignments RB Rule

*Now* I understand this rule. 2015-09-02 3:40 GMT+02:00 Eliot Miranda : > > > On Tue, Sep 1, 2015 at 1:29 PM, Nicolai Hess wrote: > >> Thank you all for your response, >> now the interesting question is, what should this rule recommend to use >>

Re: [Pharo-dev] ensure: and assignments RB Rule

On Tue, Sep 1, 2015 at 1:29 PM, Nicolai Hess wrote: > Thank you all for your response, > now the interesting question is, what should this rule recommend to use > instead? First assign to a block local variable and > add a nil check in the unwind block? > No. I think the

Re: [Pharo-dev] ensure: and assignments RB Rule

Thank you all for your response, now the interesting question is, what should this rule recommend to use instead? First assign to a block local variable and add a nil check in the unwind block? And maybe we should improve that rule, because in Pharo 5.0 there are 5 methods catched by this rule: 3

Re: [Pharo-dev] ensure: and assignments RB Rule

Anyone? We may remove this rule if no one understands for what this is good for. (if anyone knows, please comment that class). 2014-12-14 11:22 GMT+01:00 Nicolai Hess : > > 2014-11-30 20:54 GMT+01:00 stepharo : >> >> thanks we should open a bug entry to

Re: [Pharo-dev] ensure: and assignments RB Rule

2014-11-30 20:54 GMT+01:00 stepharo steph...@free.fr: thanks we should open a bug entry to improve the class comment of this rule. Any taker? Stef Le 30/11/14 12:10, Thierry Goubier a écrit : done 14618 https://pharo.fogbugz.com/default.asp?14618 Add a comment describing RBFileBlocksRule

Re: [Pharo-dev] ensure: and assignments RB Rule

The code would look like this: [ | file | file := StandardFileStream forceNewFileNamed: ‘foo’. file nextPutAll: ‘bar’ ] ensure: [ file close ]. Why that is considered bad practice however, I can’t tell. On 29.11.2014, at 23:01, Yuriy Tymchuk

Re: [Pharo-dev] ensure: and assignments RB Rule

Le 30/11/2014 11:06, Max Leske a écrit : The code would look like this: [ | file | file := StandardFileStream forceNewFileNamed: ‘foo’. file nextPutAll: ‘bar’ ] ensure: [ file close ]. Why that is considered bad practice however, I can’t tell. This one would

Re: [Pharo-dev] ensure: and assignments RB Rule

This is how it should be done: readStreamDo: aBlock | stream | stream := self readStream. ^ [ aBlock value: stream ] ensure: [ stream close ] Errors while opening or closing are still signalled, which is good IMO. On 30 Nov 2014, at 11:18, Thierry

Re: [Pharo-dev] ensure: and assignments RB Rule

On 30.11.2014, at 11:18, Thierry Goubier thierry.goub...@gmail.com wrote: Le 30/11/2014 11:06, Max Leske a écrit : The code would look like this: [ | file | file := StandardFileStream forceNewFileNamed: ‘foo’. file nextPutAll: ‘bar’ ] ensure: [ file close ].

Re: [Pharo-dev] ensure: and assignments RB Rule

Le 30/11/2014 12:01, Max Leske a écrit : On 30.11.2014, at 11:18, Thierry Goubier thierry.goub...@gmail.com wrote: Le 30/11/2014 11:06, Max Leske a écrit : The code would look like this: [ | file | file := StandardFileStream forceNewFileNamed: ‘foo’. file nextPutAll: ‘bar’ ]

Re: [Pharo-dev] ensure: and assignments RB Rule

thanks we should open a bug entry to improve the class comment of this rule. Any taker? Stef Le 30/11/14 12:10, Thierry Goubier a écrit : Le 30/11/2014 12:01, Max Leske a écrit : On 30.11.2014, at 11:18, Thierry Goubier thierry.goub...@gmail.com wrote: Le 30/11/2014 11:06, Max Leske a

[Pharo-dev] ensure: and assignments RB Rule

Hi guys I'm revisiting all the RB rule and I'm puzzled by this one. Checks assignment to a variable that is the first statement inside the value block that is also used in the unwind block. [| `@temps | `var := `@object. `@.statements] ensure: [`var

Re: [Pharo-dev] ensure: and assignments RB Rule

As the class of this rule is named RBFileBlocksRule, I guess it comes from some practice used when working with files. I’m not a file guru, but maybe others can tell more. Stef, as you are working on rules, can we merge category and group of the rule? I understand that one was added later by