Re: [Pharo-dev] [COTDC] 108 - NewValueHolder

2014-01-21 Thread Benjamin
On 21 Jan 2014, at 04:53, Stéphane Ducasse stephane.duca...@inria.fr wrote: Since nobody looks at it: here are the issue (they contain class comments). https://pharo.fogbugz.com/default.asp?12572 is a print case of the following, so will not be checked until the child case is

Re: [Pharo-dev] [COTDC] 108 - NewValueHolder

2014-01-20 Thread Benjamin
On 20 Jan 2014, at 15:36, Sean P. DeNigris s...@clipperadams.com wrote: I had some questions about NewValueHolder and I figured, why not revive COTDC?! I loved it :) The current comment is: A NewValueHolder is a new implementation of ValueHolder based on Announcements. Of course,

Re: [Pharo-dev] [COTDC] 108 - NewValueHolder

2014-01-20 Thread Stéphane Ducasse
I commented the code in a slice that apparently was not integrated. But yes this is a good idea. - to have more code review - to revive the COTDC I had some questions about NewValueHolder and I figured, why not revive COTDC?! The current comment is: A NewValueHolder is a

Re: [Pharo-dev] [COTDC] 108 - NewValueHolder

2014-01-20 Thread Nicolas Cellier
NewValueHolder? the name sounds like a Squeak strategy: keep backward compatibility as long as possible. Since Pharo values cleanlyDesigned backwardCompatible, I would expect ValueHolder-LegacyValueHolder and NewValueHolder-ValueHolder. We had too many NewParagraph, etc... in the past, history

Re: [Pharo-dev] [COTDC] 108 - NewValueHolder

2014-01-20 Thread Benjamin
It is the history of a prototype ending in the system :) Ben On 20 Jan 2014, at 18:02, Nicolas Cellier nicolas.cellier.aka.n...@gmail.com wrote: NewValueHolder? the name sounds like a Squeak strategy: keep backward compatibility as long as possible. Since Pharo values cleanlyDesigned

Re: [Pharo-dev] [COTDC] 108 - NewValueHolder

2014-01-20 Thread Nicolai Hess
2014/1/20 Benjamin benjamin.vanryseghem.ph...@gmail.com On 20 Jan 2014, at 15:36, Sean P. DeNigris s...@clipperadams.com wrote: I had some questions about NewValueHolder and I figured, why not revive COTDC?! I loved it :) The current comment is: A NewValueHolder is a new

Re: [Pharo-dev] [COTDC] 108 - NewValueHolder

2014-01-20 Thread Benjamin
On 20 Jan 2014, at 19:24, Nicolai Hess nicolaih...@web.de wrote: we should distinguish between storing a object and change a value. At the moment, NewValueHolder announces every time we store into this value holder regardless wether the value changed. That’s true. It was not clear enough :)

Re: [Pharo-dev] [COTDC] 108 - NewValueHolder

2014-01-20 Thread Sean P. DeNigris
Benjamin Van Ryseghem-2 wrote In addition, infinite loops of propagation are prevented. Is that what lock is all about? I was wondering... - Cheers, Sean -- View this message in context: http://forum.world.st/COTDC-108-NewValueHolder-tp4738066p4738129.html Sent from the Pharo Smalltalk

Re: [Pharo-dev] [COTDC] 108 - NewValueHolder

2014-01-20 Thread Benjamin
On 20 Jan 2014, at 19:31, Sean P. DeNigris s...@clipperadams.com wrote: Benjamin Van Ryseghem-2 wrote In addition, infinite loops of propagation are prevented. Is that what lock is all about? I was wondering... Yes :) Ben

Re: [Pharo-dev] [COTDC] 108 - NewValueHolder

2014-01-20 Thread Sean P. DeNigris
I made an issue summarizing this thread. I'll take care of it when comments die down here… https://pharo.fogbugz.com/default.asp?12684 - Cheers, Sean -- View this message in context: http://forum.world.st/COTDC-108-NewValueHolder-tp4738066p4738150.html Sent from the Pharo Smalltalk

Re: [Pharo-dev] [COTDC] 108 - NewValueHolder

2014-01-20 Thread Stéphane Ducasse
Hi nicolas. I do not remember but it seems that I did a slice to move NewValueHolder out of Spec inside their own package. Then we should rename and remove the old one but it takes time and if somebody does it will go faster. Stef NewValueHolder? the name sounds like a Squeak strategy:

Re: [Pharo-dev] [COTDC] 108 - NewValueHolder

2014-01-20 Thread Stéphane Ducasse
Since nobody looks at it: here are the issue (they contain class comments). https://pharo.fogbugz.com/default.asp?12572 https://pharo.fogbugz.com/default.asp?12486 Apparently all the work I did around Spec is not reviewed. May be I should push them without waiting from any