Re: [Pharo-dev] [Issue tracker] Help needed for reviews

2014-01-03 Thread Marcus Denker
On 03 Jan 2014, at 00:04, Hilaire Fernandes hilaire.fernan...@gmail.com wrote: Le 02/01/2014 20:37, Marcus Denker a écrit : I always use “merge”. “Changes” will e.g. show all the changes towards everything changed in between, too. For me this is weird, I can't understand the logic.

Re: [Pharo-dev] [Issue tracker] Help needed for reviews

2014-01-03 Thread Esteban Lorenzano
On 03 Jan 2014, at 10:32, Marcus Denker marcus.den...@inria.fr wrote: On 03 Jan 2014, at 01:01, Sebastian Sastre sebast...@flowingconcept.com wrote: Changes reads Merge writes In order to make safe a potentially dangerous operation, the write is done in two steps so the user can

Re: [Pharo-dev] [Issue tracker] Help needed for reviews

2014-01-03 Thread Hilaire Fernandes
Le 03/01/2014 10:31, Marcus Denker a écrit : From then the change was made *other* changes have been done. “Change” will show *all* differences, both the ones other integrations did to the package as well as the changes of the slice. In addition, there is still some bug that when e.g

Re: [Pharo-dev] [Issue tracker] Help needed for reviews

2014-01-03 Thread Nicolai Hess
2014/1/3 Hilaire Fernandes hilaire.fernan...@gmail.com Le 03/01/2014 10:31, Marcus Denker a écrit : From then the change was made *other* changes have been done. “Change” will show *all* differences, both the ones other integrations did to the package as well as the changes of the slice.

Re: [Pharo-dev] [Issue tracker] Help needed for reviews

2014-01-03 Thread Marcus Denker
On 03 Jan 2014, at 12:04, Hilaire Fernandes hilaire.fernan...@gmail.com wrote: Le 03/01/2014 10:31, Marcus Denker a écrit : From then the change was made *other* changes have been done. “Change” will show *all* differences, both the ones other integrations did to the package as well as the

Re: [Pharo-dev] [Issue tracker] Help needed for reviews

2014-01-02 Thread Sven Van Caekenberghe
On 02 Jan 2014, at 15:25, Marcus Denker marcus.den...@inria.fr wrote: Hello, We have some issues ready that nevertheless need to be reviewed by humans: https://pharo.fogbugz.com/f/filters/45/Review We know that they do not make tests fail and even pass some code critic tests.

Re: [Pharo-dev] [Issue tracker] Help needed for reviews

2014-01-02 Thread Hilaire Fernandes
Ok, this new to me, so I may not understand clearly. I give a try and pointed Pharo 3.0 to a Slice I know about, SLICE 12495 on PolygonMoprh. I asked for the changes implication and see a lot not related to PolygonMorph. Is it normal? Hilaire Le 02/01/2014 15:25, Marcus Denker a écrit : Hello,

Re: [Pharo-dev] [Issue tracker] Help needed for reviews

2014-01-02 Thread Stephan Eggermont
Hilaire wrote: I asked for the changes implication and see a lot not related to PolygonMorph. Is it normal? The first comment is mainly cleaning deadcode. That should serve as a warning. Most slices have a better focus, but there are a few only describing the most important fix. Finer

Re: [Pharo-dev] [Issue tracker] Help needed for reviews

2014-01-02 Thread Marcus Denker
On 02 Jan 2014, at 17:47, Hilaire Fernandes hilaire.fernan...@gmail.com wrote: Ok, this new to me, so I may not understand clearly. I give a try and pointed Pharo 3.0 to a Slice I know about, SLICE 12495 on PolygonMoprh. I asked for the changes implication and see a lot not related to

Re: [Pharo-dev] [Issue tracker] Help needed for reviews

2014-01-02 Thread Stéphane Ducasse
Hi sven We got an internal discussion on this topic with the same concerns. Komitter was pushed because it does not touch existing code and because people like mariano where starting to code it in parallel. So we thought it was important for people. The idea is that we have some bugs to fix

Re: [Pharo-dev] [Issue tracker] Help needed for reviews

2014-01-02 Thread Hilaire Fernandes
Le 02/01/2014 20:37, Marcus Denker a écrit : I always use “merge”. “Changes” will e.g. show all the changes towards everything changed in between, too. For me this is weird, I can't understand the logic. Merge: shows you the changes then let your merge Change: shows some other sort of

Re: [Pharo-dev] [Issue tracker] Help needed for reviews

2014-01-02 Thread Sebastian Sastre
Changes reads Merge writes In order to make safe a potentially dangerous operation, the write is done in two steps so the user can confirm what is going to be written (or have a chance to check if changes are the ones expected or not and abort without modifying the code). It's functionally