Thanks Nicolai, that's great! I'll merge in your changes. Which files do I need to look at?
On Sat, Sep 12, 2015 at 8:00 AM, Nicolai Hess <nicolaih...@web.de> wrote: > > > > 2015-09-10 21:31 GMT+02:00 Eliot Miranda <eliot.mira...@gmail.com>: > >> >> Hi Nicolai, >> >> I'm a bit concerned that this is creating drift with the "official" >> Cog source base at http://www.squeakvm.org/svn/squeak/branches/Cog. >> Long filename support for win32 was recently added by Marcel Taumel in May >> of this year. Are you tracking that? How can we keep the sources >> harmonized? >> > > Ok, I removed all of my code again and merged with sqWin32Directory.c and > sqWin32FilePrims.c from the official cog source. > I left only pharos additions for the fileattributes (posixpermissions) > this should make it easier to merge which the > squeak vm main branch (wrapped with pharo vm ifdefs). > > github branch: > https://github.com/nicolaihess/pharo-vm/tree/harmonize_win_file_plugin > I'll create a push request. > > > nicolai > > > >> >> On Sun, Aug 23, 2015 at 4:44 AM, Nicolai Hess <nicolaih...@web.de> wrote: >> >>> For those who had problems with pharo on windows and github based >>> repositories, >>> I built a windows vm with support for long paths: >>> >>> >>> https://drive.google.com/file/d/0B8yEahnuIem2bmxwdzJuUXFxVGM/view?usp=sharing >>> >>> >>> For browsing directories with large paths (FileList or Inspect), >>> you may need one additional change in the image (But I am not really >>> sure about that) : >>> >>> DiskStore>>initialize >>> super initialize. >>> maxFileNameLength := Smalltalk vm maxFilenameLength ifNil: [ 32767 ]. >>> >>> >>> please test and give feedback. >>> >>> This wasn't as easy as I thought, and I had to make some more changes >>> for the file permissions (the stat-functions don't work for files with >>> long paths). >>> Please test other file/folder operations. >>> >>> >>> nicolai >>> >>> >>> >>> >> >> >> -- >> _,,,^..^,,,_ >> best, Eliot >> >> > > -- _,,,^..^,,,_ best, Eliot