Re: [Pharo-dev] [Pharo 7.0-dev] Build #593: 21390-Do-not-store-any-non-literals-in-the-literal-array
> Am 25.02.2018 um 22:02 schrieb Stephane Ducasse : > > I really like this idea of read only literals :) > Tx for pushing it. +1 > >> On Thu, Feb 22, 2018 at 11:52 AM, Marcus Denker >> wrote: >> This fixes the Reflectivity compiler to not store normal objects in the >> literalArray… so instead of “pushLiteral:” is now uses >> “pushLiteralVariable:”. >> >> This is needed as we do now have a compiler option to compile methods with >> read-only literals. >> >>Marcus >> >>> On 22 Feb 2018, at 11:45, ci-pharo-ci-jenki...@inria.fr wrote: >>> >>> There is a new Pharo build available! >>> >>> The status of the build #593 was: SUCCESS. >>> >>> The Pull Request #932 was integrated: >>> "21390-Do-not-store-any-non-literals-in-the-literal-array" >>> Pull request url: https://github.com/pharo-project/pharo/pull/932 >>> >>> Issue Url: https://pharo.fogbugz.com/f/cases/21390 >>> Build Url: >>> https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/development/593/ >> >>
Re: [Pharo-dev] [Pharo 7.0-dev] Build #593: 21390-Do-not-store-any-non-literals-in-the-literal-array
I really like this idea of read only literals :) Tx for pushing it. On Thu, Feb 22, 2018 at 11:52 AM, Marcus Denker wrote: > This fixes the Reflectivity compiler to not store normal objects in the > literalArray… so instead of “pushLiteral:” is now uses > “pushLiteralVariable:”. > > This is needed as we do now have a compiler option to compile methods with > read-only literals. > > Marcus > >> On 22 Feb 2018, at 11:45, ci-pharo-ci-jenki...@inria.fr wrote: >> >> There is a new Pharo build available! >> >> The status of the build #593 was: SUCCESS. >> >> The Pull Request #932 was integrated: >> "21390-Do-not-store-any-non-literals-in-the-literal-array" >> Pull request url: https://github.com/pharo-project/pharo/pull/932 >> >> Issue Url: https://pharo.fogbugz.com/f/cases/21390 >> Build Url: >> https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/development/593/ > >
Re: [Pharo-dev] [Pharo 7.0-dev] Build #593: 21390-Do-not-store-any-non-literals-in-the-literal-array
This fixes the Reflectivity compiler to not store normal objects in the literalArray… so instead of “pushLiteral:” is now uses “pushLiteralVariable:”. This is needed as we do now have a compiler option to compile methods with read-only literals. Marcus > On 22 Feb 2018, at 11:45, ci-pharo-ci-jenki...@inria.fr wrote: > > There is a new Pharo build available! > > The status of the build #593 was: SUCCESS. > > The Pull Request #932 was integrated: > "21390-Do-not-store-any-non-literals-in-the-literal-array" > Pull request url: https://github.com/pharo-project/pharo/pull/932 > > Issue Url: https://pharo.fogbugz.com/f/cases/21390 > Build Url: > https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20and%20branch%20Pipeline/job/development/593/
