Re: [Pharo-dev] Pull requests ready to be reviewed

2017-08-10 Thread Serge Stinckwich 
This is great to see the workflow start to emerge.
I guess all PRs tagged with human-review-needed are the one to take care ?

https://github.com/pharo-project/pharo/pulls?q=is%3Apr+is%3Aopen+label%3Ahuman-review-needed

On Wed, Aug 9, 2017 at 10:09 AM, Pavel Krivanek 
wrote:

> We have several pull requests validated successfully by the
> infrastructure. They need to be reviewed by humans:
>
> https://github.com/pharo-project/pharo/pull/75
>
> https://github.com/pharo-project/pharo/pull/66
>
> https://github.com/pharo-project/pharo/pull/175
>
> https://github.com/pharo-project/pharo/pull/172
>
> https://github.com/pharo-project/pharo/pull/169
>
> https://github.com/pharo-project/pharo/pull/168
>
> https://github.com/pharo-project/pharo/pull/134
>
> Cheers,
> -- Pavel
>
>
>


-- 
Serge Stinckwich
UCN & UMI UMMISCO 209 (IRD/UPMC)
Every DSL ends up being Smalltalk
http://www.doesnotunderstand.org/

Re: [Pharo-dev] Pull requests ready to be reviewed

2017-08-09 Thread Alistair Grant 
On Wed, Aug 09, 2017 at 12:20:17PM +0200, Guillermo Polito wrote:
> On Wed, Aug 9, 2017 at 11:09 AM, Pavel Krivanek 
> wrote:
> 
> We have several pull requests validated successfully by the 
> infrastructure.
> They need to be reviewed by humans:
> 
> https://github.com/pharo-project/pharo/pull/75
> 
> 
> This one has a merge coflict.

This is also the subject of a current discussion, see subject
"FileSystem fix integration"

Cheers,
Alistair


> https://github.com/pharo-project/pharo/pull/66
> 
> 
> I made a little review there :)
>  
> 
> 
> 
> https://github.com/pharo-project/pharo/pull/175
> 
> https://github.com/pharo-project/pharo/pull/172
> 
> https://github.com/pharo-project/pharo/pull/169
> 
> https://github.com/pharo-project/pharo/pull/168
> 
> https://github.com/pharo-project/pharo/pull/134

Re: [Pharo-dev] Pull requests ready to be reviewed

2017-08-09 Thread Guillermo Polito 
On Wed, Aug 9, 2017 at 11:09 AM, Pavel Krivanek 
wrote:

> We have several pull requests validated successfully by the
> infrastructure. They need to be reviewed by humans:
>
> https://github.com/pharo-project/pharo/pull/75
>

This one has a merge coflict.


>
>
> https://github.com/pharo-project/pharo/pull/66
>

I made a little review there :)


>
>
> https://github.com/pharo-project/pharo/pull/175
>
> https://github.com/pharo-project/pharo/pull/172
>
> https://github.com/pharo-project/pharo/pull/169
>
> https://github.com/pharo-project/pharo/pull/168
>
> https://github.com/pharo-project/pharo/pull/134
>
> Cheers,
> -- Pavel
>
>
>


-- 



Guille Polito


Research Engineer

French National Center for Scientific Research - *http://www.cnrs.fr*




*Web:* *http://guillep.github.io* 

*Phone: *+33 06 52 70 66 13