[Pharo-users] AST visualization with Roassal

2015-07-30 Thread Mark Rizun
Hi, everyone! First of all, using Roassal is fun and effective :) But while working on AST visualization I found that sometimes Roassal builds wrong tree layout (or maybe I'm just doing something wrong). For instance, try two following scripts in playground: * #1 | ast

Re: [Pharo-users] AST visualization with Roassal

2015-07-30 Thread Peter Uhnák
I think it's because somewhere in roassal objects (in this case ast nodes) are compared by value. Pretty much; there is test for equality RTGroupelementFromModel: anObject ^ self detect: [ :el | el model = anObject ] ifNone: [ nil ] and equality is more often than not wanted. So

Re: [Pharo-users] AST visualization with Roassal

2015-07-30 Thread Alexandre Bergel
Hi Mark, I have introduced a class RTIdentityGroup. You can do: -=-=-= -=-=-= -=-=-= -=-=-= ast := RBParser parseExpression: 'self foo. self foo'. builder := RTMondrian new. builder shape ellipse size: 15. nodes := builder nodes: ast allChildren.

Re: [Pharo-users] AST visualization with Roassal

2015-07-30 Thread Marcus Denker
On 30 Jul 2015, at 16:47, Mark Rizun mri...@gmail.com wrote: Pretty much; there is test for equality RTGroupelementFromModel: anObject ^ self detect: [ :el | el model = anObject ] ifNone: [ nil ] and equality is more often than not wanted. So solution might be to tell Mondrian

Re: [Pharo-users] AST visualization with Roassal

2015-07-30 Thread Marcus Denker
On 30 Jul 2015, at 17:26, Alexandre Bergel alexandre.ber...@me.com wrote: Hi Mark, I have introduced a class RTIdentityGroup. You can do: -=-=-= -=-=-= -=-=-= -=-=-= ast := RBParser parseExpression: 'self foo. self foo'. builder := RTMondrian new. builder shape

Re: [Pharo-users] AST visualization with Roassal

2015-07-30 Thread Mark Rizun
Pretty much; there is test for equality RTGroupelementFromModel: anObject ^ self detect: [ :el | el model = anObject ] ifNone: [ nil ] and equality is more often than not wanted. So solution might be to tell Mondrian that you want to compare by identity and not equality? Exactly!

Re: [Pharo-users] AST visualization with Roassal

2015-07-30 Thread Alexandre Bergel
Frankly, I often find weird to override #= Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. On Jul 30, 2015, at 11:41 AM, Peter Uhnák i.uh...@gmail.com wrote: I think it's because

Re: [Pharo-users] AST visualization with Roassal

2015-07-30 Thread Mark Rizun
Great, everybody is happy ;) Thanks Alex ! 30 лип. 2015 5:40 пп Marcus Denker marcus.den...@inria.fr пише: On 30 Jul 2015, at 17:26, Alexandre Bergel alexandre.ber...@me.com wrote: Hi Mark, I have introduced a class RTIdentityGroup. You can do: -=-=-= -=-=-= -=-=-= -=-=-=

Re: [Pharo-users] AST visualization with Roassal

2015-07-30 Thread Alexandre Bergel
Excellent! Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. On Jul 30, 2015, at 12:40 PM, Marcus Denker marcus.den...@inria.fr wrote: Yes, we checked. This explains the strange “too