I need to double check it, for now I cannot access the issue tracker (probably
local internet issues).
As far as I remember, the problem was that SmallLint rules where checking
contexts and not classes and methods. I.e. you had to create a context, set
it’s “selected class or method, pass it
yuriy what was a context?
Stef
Le 18/8/15 22:39, Yuriy Tymchuk a écrit :
This may have happened when I was removing contexts from the rules.
Uko
On 18 Aug 2015, at 18:25, stepharo steph...@free.fr
mailto:steph...@free.fr wrote:
Hi marcus
do you get an idea why we got this slowdown?
This may have happened when I was removing contexts from the rules.
Uko
On 18 Aug 2015, at 18:25, stepharo steph...@free.fr wrote:
Hi marcus
do you get an idea why we got this slowdown?
Stef
Le 30/7/15 14:08, Marcus Denker a écrit :
I added an issue:
On 18 Aug 2015, at 22:39, Yuriy Tymchuk yuriy.tymc...@me.com wrote:
This may have happened when I was removing contexts from the rules.
I think the reason is that there was a cache in the context. But we need to
check.
Uko
On 18 Aug 2015, at 18:25, stepharo steph...@free.fr
Hi marcus
do you get an idea why we got this slowdown?
Stef
Le 30/7/15 14:08, Marcus Denker a écrit :
I added an issue:
https://pharo.fogbugz.com/f/cases/16074/Is-RBClassNotReferencedRule-200x-slower-in-Pharo-4-vs-Pharo-3
i think we need to put in some cashing… here if we would could all
I added an issue:
https://pharo.fogbugz.com/f/cases/16074/Is-RBClassNotReferencedRule-200x-slower-in-Pharo-4-vs-Pharo-3
https://pharo.fogbugz.com/f/cases/16074/Is-RBClassNotReferencedRule-200x-slower-in-Pharo-4-vs-Pharo-3
i think we need to put in some cashing… here if we would could all
Paul
I'm running out of town.
Could you open a bug entry with the information you have so that we do
not forget?
Stef
Le 29/7/15 17:33, Paul DeBruicker a écrit :
Hi Stef,
The slowdown is dependent upon the # of classes in the package. If you use
Fuel then you should see a slowdown of 20x.
Paul DeBruicker wrote
Hi Stef,
The slowdown is dependent upon the # of classes in the package. If you
use Fuel then you should see a slowdown of 20x. I just have a lot of
classes in this package. The source of the slowdown is in the changes to
RBSmallLintChecker#checkClass: and
Hi Stef,
The slowdown is dependent upon the # of classes in the package. If you use
Fuel then you should see a slowdown of 20x. I just have a lot of classes in
this package. The source of the slowdown is in the changes to
RBSmallLintChecker#checkClass: and RBClassNotReferencedRule#checkClass:
Thanks for the question.
It looks like we got a regression.
Le 29/7/15 06:04, Paul DeBruicker a écrit :
I think I'm setting this up wrong in Pharo 4 but am not sure. I use the
following code for the test:
rule:=RBClassNotReferencedRule new.
environment:=RBBrowserEnvironment new
Paul
I wanted to check on Pharo 50 but we need a comparison point. We should
get the same package.
Do you have an idea of a package that did not change much?
Setf
Le 29/7/15 06:04, Paul DeBruicker a écrit :
I think I'm setting this up wrong in Pharo 4 but am not sure. I use the
following
I think I'm setting this up wrong in Pharo 4 but am not sure. I use the
following code for the test:
rule:=RBClassNotReferencedRule new.
environment:=RBBrowserEnvironment new forPackageNames: #('MyPackage').
AndreasSystemProfiler spyOn:[RBSmalllintChecker runRule: rule
12 matches
Mail list logo
