Re: [Pharo-users] DictionaryValueHolder question

2017-09-13 Thread Stephane Ducasse 
Yes this is why I said that we should use them

On Wed, Sep 13, 2017 at 10:40 AM, Peter Uhnák  wrote:
>
>
> On Wed, Sep 13, 2017 at 9:45 AM, Stephane Ducasse 
> wrote:
>>
>> incomplete
>> I would use Announcement.
>
>
> ValueAdded/ValueChanged/ValueRemoved are all announcements.
>
> P

Re: [Pharo-users] DictionaryValueHolder question

2017-09-13 Thread Peter Uhnák 
On Wed, Sep 13, 2017 at 9:45 AM, Stephane Ducasse 
wrote:

> incomplete
> I would use Announcement.
>

ValueAdded/ValueChanged/ValueRemoved are all announcements.

P

Re: [Pharo-users] DictionaryValueHolder question

2017-09-13 Thread Stephane Ducasse 
incomplete
I would use Announcement.


On Tue, Sep 12, 2017 at 3:46 AM, Rob Rothwell  wrote:
> Hello,
>
> Unlike the CollectionValueHolder, the DictionaryValueHolder only notifies
> you that something has changed, rather than tell you what item has been
> added or removed.  Does anyone know if this is by design, or just
> incomplete?
>
> If incomplete, what do you think about using the
> ValueAdded/ValueChanged/ValueRemoved announcements and passing the
> association in newValue/oldValue?
>
> Thank you,
>
> Rob
>
>

Re: [Pharo-users] DictionaryValueHolder question

2017-09-12 Thread Rob Rothwell 
Hi Peter,

Thank you very much for the clarification; I'll see what I can come up with!

Take care,

Rob

On Tue, Sep 12, 2017 at 11:18 AM, Peter Uhnák  wrote:

> Hi Rob,
>
> this is by omission. Originally CollectionValueHolder didn't have it
> either until I've introduced ValueAdded/ValueRemoved. So feel free to
> incorporate it in a meaningful fashion to a DictionaryHolder.
>
> Peter
>
> On Tue, Sep 12, 2017 at 3:46 AM, Rob Rothwell 
> wrote:
>
>> Hello,
>>
>> Unlike the CollectionValueHolder, the DictionaryValueHolder only notifies
>> you that something has changed, rather than tell you what item has been
>> added or removed.  Does anyone know if this is by design, or just
>> incomplete?
>>
>> If incomplete, what do you think about using the
>> ValueAdded/ValueChanged/ValueRemoved announcements and passing the
>> association in newValue/oldValue?
>>
>> Thank you,
>>
>> Rob
>>
>>
>>
>

Re: [Pharo-users] DictionaryValueHolder question

2017-09-12 Thread Peter Uhnák 
Hi Rob,

this is by omission. Originally CollectionValueHolder didn't have it either
until I've introduced ValueAdded/ValueRemoved. So feel free to incorporate
it in a meaningful fashion to a DictionaryHolder.

Peter

On Tue, Sep 12, 2017 at 3:46 AM, Rob Rothwell 
wrote:

> Hello,
>
> Unlike the CollectionValueHolder, the DictionaryValueHolder only notifies
> you that something has changed, rather than tell you what item has been
> added or removed.  Does anyone know if this is by design, or just
> incomplete?
>
> If incomplete, what do you think about using the 
> ValueAdded/ValueChanged/ValueRemoved
> announcements and passing the association in newValue/oldValue?
>
> Thank you,
>
> Rob
>
>
>

[Pharo-users] DictionaryValueHolder question

2017-09-11 Thread Rob Rothwell 
Hello,

Unlike the CollectionValueHolder, the DictionaryValueHolder only notifies
you that something has changed, rather than tell you what item has been
added or removed.  Does anyone know if this is by design, or just
incomplete?

If incomplete, what do you think about using the
ValueAdded/ValueChanged/ValueRemoved announcements and passing the
association in newValue/oldValue?

Thank you,

Rob