In that code path, it's possible that idx == LONG_MAX+1. Casting that value
to a signed long is undefined behavior (since it overflows), which means
that the compiler can do bad things with that.
With this patch we will basically do the same operation, but over an
unsigned long, thus avoiding th
Hi!
Could you please explain this commit? idx is ulong, why this change
improves anything?
> Commit:91ce8041a3e85594e81466a528f8d55cdc164c1f
> Author:Nuno Lopes Mon, 2 Jul 2012 01:31:40 -0400
> Parents: be4053cea0462c9de5396641f4e4fa2f56f5a675
> Branches: PHP-5.4
>
> Link:
Commit:91ce8041a3e85594e81466a528f8d55cdc164c1f
Author:Nuno Lopes Mon, 2 Jul 2012 01:31:40 -0400
Parents: be4053cea0462c9de5396641f4e4fa2f56f5a675
Branches: PHP-5.4
Link:
http://git.php.net/?p=php-src.git;a=commitdiff;h=91ce8041a3e85594e81466a528f8d55cdc164c1f
Log:
fix
Commit:d80ff391899f7aead3b9b9c6c084adba8a8203ba
Author:Nuno Lopes Mon, 2 Jul 2012 01:31:40 -0400
Parents: 250393f92523fffe643df06a1de2101fd50a327e
Branches: PHP-5.3
Link:
http://git.php.net/?p=php-src.git;a=commitdiff;h=d80ff391899f7aead3b9b9c6c084adba8a8203ba
Log:
fix
Commit:f2bf98a589b63ea6e604036eb6ab02aba5fce5ef
Author:Nuno Lopes Mon, 2 Jul 2012 01:31:40 -0400
Parents: 8d81a03e434e5476c4c7832b8bcafcaa31fb474e
Branches: master
Link:
http://git.php.net/?p=php-src.git;a=commitdiff;h=f2bf98a589b63ea6e604036eb6ab02aba5fce5ef
Log:
fix (
Commit:be4053cea0462c9de5396641f4e4fa2f56f5a675
Author:Xinchen Hui Mon, 2 Jul 2012 11:33:38 +0800
Parents: ff41bfc87882440cfde0ed5673bd6c3f2347c892
Branches: PHP-5.4
Link:
http://git.php.net/?p=php-src.git;a=commitdiff;h=be4053cea0462c9de5396641f4e4fa2f56f5a675
Log:
Fix
Commit:ff41bfc87882440cfde0ed5673bd6c3f2347c892
Author:Nikita Popov Sun, 1 Jul 2012 17:05:19 +0200
Parents: b7903f9778a57fda71867f9661505f635d602067
Branches: PHP-5.4 master
Link:
http://git.php.net/?p=php-src.git;a=commitdiff;h=ff41bfc87882440cfde0ed5673bd6c3f2347c892
Commit:b7903f9778a57fda71867f9661505f635d602067
Author:Nikita Popov Sun, 1 Jul 2012 16:38:26 +0200
Parents: 9cbd7a24b6d1d61e51fd6d32669dcfa1df30c883
Branches: PHP-5.4 master
Link:
http://git.php.net/?p=php-src.git;a=commitdiff;h=b7903f9778a57fda71867f9661505f635d602067
Commit:250393f92523fffe643df06a1de2101fd50a327e
Author:Nikita Popov Sun, 1 Jul 2012 16:28:57 +0200
Parents: 5f31c81f0754ac031c2c5c056cb48ff4153fea81
Branches: PHP-5.3 PHP-5.4 master
Link:
http://git.php.net/?p=php-src.git;a=commitdiff;h=250393f92523fffe643df06a1de2101fd5