Re: [PHP-CVS] com php-src: fix (signed) integer overflow (part of bug #52550: Zend/zend_hash.h

2012-07-01 Thread Nuno Lopes
In that code path, it's possible that idx == LONG_MAX+1. Casting that value to a signed long is undefined behavior (since it overflows), which means that the compiler can do bad things with that. With this patch we will basically do the same operation, but over an unsigned long, thus avoiding th

Re: [PHP-CVS] com php-src: fix (signed) integer overflow (part of bug #52550: Zend/zend_hash.h

2012-07-01 Thread Stas Malyshev
Hi! Could you please explain this commit? idx is ulong, why this change improves anything? > Commit:91ce8041a3e85594e81466a528f8d55cdc164c1f > Author:Nuno Lopes Mon, 2 Jul 2012 01:31:40 -0400 > Parents: be4053cea0462c9de5396641f4e4fa2f56f5a675 > Branches: PHP-5.4 > > Link:

[PHP-CVS] com php-src: fix (signed) integer overflow (part of bug #52550: Zend/zend_hash.h

2012-07-01 Thread Nuno Lopes
Commit:91ce8041a3e85594e81466a528f8d55cdc164c1f Author:Nuno Lopes Mon, 2 Jul 2012 01:31:40 -0400 Parents: be4053cea0462c9de5396641f4e4fa2f56f5a675 Branches: PHP-5.4 Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=91ce8041a3e85594e81466a528f8d55cdc164c1f Log: fix

[PHP-CVS] com php-src: fix (signed) integer overflow (part of bug #52550: Zend/zend_hash.h

2012-07-01 Thread Nuno Lopes
Commit:d80ff391899f7aead3b9b9c6c084adba8a8203ba Author:Nuno Lopes Mon, 2 Jul 2012 01:31:40 -0400 Parents: 250393f92523fffe643df06a1de2101fd50a327e Branches: PHP-5.3 Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=d80ff391899f7aead3b9b9c6c084adba8a8203ba Log: fix

[PHP-CVS] com php-src: fix (signed) integer overflow (part of bug #52550: Zend/zend_hash.h

2012-07-01 Thread Nuno Lopes
Commit:f2bf98a589b63ea6e604036eb6ab02aba5fce5ef Author:Nuno Lopes Mon, 2 Jul 2012 01:31:40 -0400 Parents: 8d81a03e434e5476c4c7832b8bcafcaa31fb474e Branches: master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=f2bf98a589b63ea6e604036eb6ab02aba5fce5ef Log: fix (

[PHP-CVS] com php-src: Fixed bug #62433 (Inconsistent behavior of RecursiveDirectoryIterator to dot files).: NEWS ext/spl/spl_directory.c ext/spl/tests/bug62433.phpt

2012-07-01 Thread Xinchen Hui
Commit:be4053cea0462c9de5396641f4e4fa2f56f5a675 Author:Xinchen Hui Mon, 2 Jul 2012 11:33:38 +0800 Parents: ff41bfc87882440cfde0ed5673bd6c3f2347c892 Branches: PHP-5.4 Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=be4053cea0462c9de5396641f4e4fa2f56f5a675 Log: Fix

[PHP-CVS] com php-src: Fix accidential change of php_version.h: main/php_version.h

2012-07-01 Thread Nikita Popov
Commit:ff41bfc87882440cfde0ed5673bd6c3f2347c892 Author:Nikita Popov Sun, 1 Jul 2012 17:05:19 +0200 Parents: b7903f9778a57fda71867f9661505f635d602067 Branches: PHP-5.4 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=ff41bfc87882440cfde0ed5673bd6c3f2347c892

[PHP-CVS] com php-src: Revert JSON merges to 5.4: ext/json/JSON_parser.h ext/json/json.c ext/json/php_json.h ext/json/tests/003.phpt ext/json/tests/004.phpt ext/json/tests/007.phpt ext/json/tests/bug4

2012-07-01 Thread Nikita Popov
Commit:b7903f9778a57fda71867f9661505f635d602067 Author:Nikita Popov Sun, 1 Jul 2012 16:38:26 +0200 Parents: 9cbd7a24b6d1d61e51fd6d32669dcfa1df30c883 Branches: PHP-5.4 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=b7903f9778a57fda71867f9661505f635d602067

[PHP-CVS] com php-src: Revert JSON changes to PHP 5.3: ext/json/JSON_parser.h ext/json/json.c ext/json/tests/003.phpt ext/json/tests/004.phpt ext/json/tests/007.phpt ext/json/tests/bug54058.phpt ext/j

2012-07-01 Thread Nikita Popov
Commit:250393f92523fffe643df06a1de2101fd50a327e Author:Nikita Popov Sun, 1 Jul 2012 16:28:57 +0200 Parents: 5f31c81f0754ac031c2c5c056cb48ff4153fea81 Branches: PHP-5.3 PHP-5.4 master Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=250393f92523fffe643df06a1de2101fd5