Re: [PHP-CVS] cvs: php-src /ext/sockets sockets.c ZendEngine2 ZEND_CHANGES zend_API.c zend_execute_API.c

2003-10-24 Thread Marcus Börger
Hello Marcus, Friday, October 24, 2003, 8:24:29 PM, you wrote: FUCK cvs! -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php-src /main SAPI.c /main/streams streams.c userspace.c /tests/lang bug24054.phpt

2003-09-17 Thread Marcus Börger
Hello Jani, Wednesday, September 17, 2003, 2:23:46 PM, you wrote: On Sat, 13 Sep 2003, Ard Biesheuvel wrote: Sascha and me had a deeper check upon this and it is absolutley NON portable. This is one of the C99 extensions only a few systems support. If we want the prefix 'z' then we could do

Re: [PHP-CVS] cvs: php-src /main SAPI.c /main/streams streams.c userspace.c /tests/lang bug24054.phpt

2003-09-13 Thread Marcus Börger
Hello Zeev, Saturday, September 13, 2003, 5:54:45 PM, you wrote: I don't think %zd is portable. We need to come up with some alternative solution, or some check. Sascha and me had a deeper check upon this and it is absolutley NON portable. This is one of the C99 extensions only a few

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /main streams.c

2003-09-02 Thread Marcus Börger
Hello Stanislav, Tuesday, September 2, 2003, 12:21:03 PM, you wrote: SM stasTue Sep 2 06:21:03 2003 EDT SM Modified files: (Branch: PHP_4_3) SM /php-src/main streams.c SM Log: SM fix typo SM Index: php-src/main/streams.c SM diff -u

Re: [PHP-CVS] cvs: spl /examples tree.php

2003-08-14 Thread Marcus Börger
Hello Marcus, Thursday, August 14, 2003, 11:44:38 PM, you wrote: MB helly Thu Aug 14 17:44:38 2003 EDT MB Modified files: MB /spl/examples tree.php MB Log: MB Upds MB Index: spl/examples/tree.php MB diff -u spl/examples/tree.php:1.3

Re: [PHP-CVS] cvs: php-src /tests/lang foreach_with_references_001.phpt

2003-07-24 Thread Marcus Börger
Hello Zeev, Thursday, July 24, 2003, 3:21:54 PM, you wrote: ZS zeevThu Jul 24 09:21:54 2003 EDT ZS Added files: ZS /php-src/tests/lang foreach_with_references_001.phpt ZS Log: ZS Add foreach() test with references ZS Index:

Re[2]: [PHP-CVS] cvs: spl / spl_foreach.c

2003-07-09 Thread Marcus Börger
Hello Jason, Wednesday, July 9, 2003, 4:57:19 AM, you wrote: JG Actually, I double checked C99, and // was added, however C89 does not. JG -Jason JG On Tue, 2003-07-08 at 21:48, Jason Greene wrote: jason Tue Jul 8 22:48:25 2003 EDT Modified files: /spl

Re: [PHP-CVS] cvs: php-src / configure.in /sapi/cgi Makefile.frag config9.m4

2003-07-01 Thread Marcus Börger
Hello Jani, Tuesday, July 1, 2003, 7:01:21 PM, you wrote: JT sniper Tue Jul 1 13:01:21 2003 EDT JT Modified files: JT /php-srcconfigure.in JT /php-src/sapi/cgi Makefile.frag config9.m4 JT Log: JT - Separate CGI build from regular SAPI build JT #

Re[2]: [PHP-CVS] cvs: php-src /tests/classes clone_002.phpt

2003-07-01 Thread Marcus Börger
Hello Jani, Wednesday, July 2, 2003, 1:58:29 AM, you wrote: JT Why do all these test check the ZE version??? JT This branch uses ZE2 anyway? Maybe you edit them whit SED and remove those chacks all ? -- Best regards, Marcusmailto:[EMAIL PROTECTED]

Re[2]: [PHP-CVS] cvs: php4 /ext/dba dba_db4.c

2003-06-19 Thread Marcus Börger
Hello Thies, it would be possible, maybe. But it seems like there are coming more changes. Also the current layout is that every handler has it's own .c and .h files as well as a generic test. Since you can only have one of the db handler the source may be duplicated but only one generates code.

Re: [PHP-CVS] cvs: php4 /ext/standard info.c

2003-05-31 Thread Marcus Börger
At 23:23 30.05.2003, Jani Taskinen wrote: MFH? No need for, 4.3 only issue. marcus -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/exif exif.c

2003-05-31 Thread Marcus Börger
At 23:26 30.05.2003, Jani Taskinen wrote: MFH? If you insist then, yes, otherwise both versions are fine :-) marcus -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: spl / spl_functions.c

2003-05-30 Thread Marcus Börger
At 14:46 29.05.2003, Andrei Zmievski wrote: On Tue, 27 May 2003, Marcus Boerger wrote: helly Mon May 26 20:14:04 2003 EDT Modified files: /spl spl_functions.c Log: For now that works. # However some of the register stuff must be moved to the engine. # And inside

Re: [PHP-CVS] cvs: php4 / TODO

2003-04-12 Thread Marcus Börger
At 00:29 13.04.2003, Moriyoshi Koizumi wrote: moriyoshi Sat Apr 12 18:29:01 2003 EDT Modified files: /php4 TODO Log: Moved a controversial entry to the proper place # maybe it's time to replace output buffering facility with the streams? Repost to internals@ as RFC

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-04-03 Thread Marcus Börger
+ if (dstW 0 || dstH 0 || srcW 0 || srcH 0) { Why is that not = marcus -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /main main.c

2003-03-31 Thread Marcus Börger
At 15:54 31.03.2003, Andrei Zmievski wrote: On Sun, 30 Mar 2003, Marcus Boerger wrote: /* {{{ includes */ @@ -575,6 +575,8 @@ /* {{{ php_error_cb extended error handling function */ +#define NO_NULL_STR(x) (x?x:) + Why not use STR_PRINT()? good question? I'll change it -- PHP CVS

Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2003-03-24 Thread Marcus Börger
At 18:19 24.03.2003, Moriyoshi Koizumi wrote: Sorry for being a bit late, but this commit broke BC. I cannot override php.ini settings by -d options any more. Hm, not for me. [EMAIL PROTECTED] php4-HEAD]$ php -r 'var_dump(ini_get(html_errors));' string(0) [EMAIL PROTECTED] php4-HEAD]$ php -d

Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2003-03-24 Thread Marcus Börger
At 20:11 24.03.2003, Moriyoshi Koizumi wrote: [EMAIL PROTECTED] (Marcus Börger) wrote: At 18:19 24.03.2003, Moriyoshi Koizumi wrote: Sorry for being a bit late, but this commit broke BC. I cannot override php.ini settings by -d options any more. Hm, not for me. [EMAIL PROTECTED] php4-HEAD

Re: [PHP-CVS] cvs: php4 / php.ini-dist php.ini-recommended /main main.c

2003-03-16 Thread Marcus Börger
At 22:10 16.03.2003, Shane Caraveo wrote: Marcus Boerger wrote: helly Sun Mar 16 15:47:56 2003 EDT Modified files: /php4/main main.c /php4php.ini-dist php.ini-recommended Log: - disable html_errors per default as suggested by php.ini-xxx - new error format that

Re: [PHP-CVS] cvs: php4 /tests/classes interfaces_001.phpt interfaces_002.phpt type_hinting_001.phpt /tests/lang type_hints_001.phpt

2003-03-07 Thread Marcus Börger
At 16:56 07.03.2003, J Smith wrote: jay Fri Mar 7 10:56:31 2003 EDT Added files: /php4/tests/langtype_hints_001.phpt /php4/tests/classes interfaces_001.phpt interfaces_002.phpt type_hinting_001.phpt Log: Added tests for interfaces and class

Re: [PHP-CVS] cvs: php4(PHP_4_3) /main main.c

2003-03-03 Thread Marcus Börger
At 02:54 03.03.2003, Harald Radi wrote: phanto Sun Mar 2 20:54:29 2003 EDT Modified files: (Branch: PHP_4_3) /php4/main main.c Log: MFH: adding disable_classes ini directive Why was this *new functionality* MFHed? -- PHP CVS Mailing List (http://www.php.net/)

RE: [PHP-CVS] cvs: php4(PHP_4_3) /main main.c

2003-03-03 Thread Marcus Börger
At 12:13 03.03.2003, Harald Radi wrote: because it is a rather small manageable security fix ? Ah security is reason enough -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 / php.ini-dist php.ini-recommended /ext/filepro filepro.c /ext/session session.c /main main.c php_globals.h php_variables.c php_variables.h

2003-03-02 Thread Marcus Börger
At 11:19 02.03.2003, Zeev Suraski wrote: zeevSun Mar 2 05:19:17 2003 EDT Log: Add JIT initialization for _SERVER and _ENV (it's less important for the others, even though it should be fairly easy now too) argc/v foes no longer work for CLI for example you can no longer

Re: [PHP-CVS] cvs: php4 /ext/standard file.c /main php_streams.h /main/streams plain_wrapper.c

2003-02-26 Thread Marcus Börger
At 02:39 25.02.2003, Ilia Alshanetsky wrote: iliaa Mon Feb 24 20:39:07 2003 EDT Log: Added locking to streams. Allow PHP to automatically release locks on files when terminating the stream. Fixed bugs in the handling of the 3rd optional parameter to flock(). What about

Re: [PHP-CVS] cvs: php4 /sapi/cgi cgi_main.c

2003-02-13 Thread Marcus Börger
At 21:28 13.02.2003, Shane Caraveo wrote: MFH? Marcus Boerger wrote: helly Thu Feb 13 14:46:41 2003 EDT Modified files: /php4/sapi/cgi cgi_main.c Log: fix non FCGI build Sure - but i am trying to get my system fixed and reconfigured due to that bloody libtool

Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2003-02-11 Thread Marcus Börger
At 17:18 11.02.2003, Ilia Alshanetsky wrote: iliaa Tue Feb 11 11:18:43 2003 EDT Modified files: /php4/sapi/cli php_cli.c Log: Added -H option to CLI binary. This option can be used to hide any arguments including the script name passed to the CLI binary. Why will i

Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2003-02-11 Thread Marcus Börger
At 21:14 11.02.2003, Ilia A. wrote: real data is avaliable within the PHP script. The only purpose of this code is to hide argv/argc from being visible via the ps command. Ilia Ok, now i see the point - that makes sense and indeed a good catch. manpage update follows marcus -- PHP CVS

Re: [PHP-CVS] cvs: php4 /main SAPI.c

2003-02-11 Thread Marcus Börger
At 00:17 12.02.2003, Stefan Esser wrote: On Wed, Feb 12, 2003 at 08:13:49AM +0900, Moriyoshi Koizumi wrote: some clarification here so I can find snprintf related bugs elsewhere. As long as snprintf must not truncate it will return the number of written bytes (excluding '\0'). If sprintf must

Re: [PHP-CVS] cvs: php4 /main SAPI.c

2003-02-11 Thread Marcus Börger
At 00:19 12.02.2003, Sascha Schumann wrote: On Wed, 12 Feb 2003, Stefan Esser wrote: On Wed, Feb 12, 2003 at 08:13:49AM +0900, Moriyoshi Koizumi wrote: some clarification here so I can find snprintf related bugs elsewhere. As long as snprintf must not truncate it will return the number of

Re: [PHP-CVS] cvs: php4 /main SAPI.c

2003-02-11 Thread Marcus Börger
At 01:40 12.02.2003, Marcus Börger wrote: At 00:17 12.02.2003, Stefan Esser wrote: On Wed, Feb 12, 2003 at 08:13:49AM +0900, Moriyoshi Koizumi wrote: some clarification here so I can find snprintf related bugs elsewhere. As long as snprintf must not truncate it will return the number

Re: [PHP-CVS] cvs: php4 /main SAPI.c

2003-02-10 Thread Marcus Börger
At 21:18 10.02.2003, you wrote: moriyoshi Mon Feb 10 15:18:08 2003 EDT Modified files: /php4/main SAPI.c Log: Fixed possible snprintf problem # besides snprintf returns int value, not uint / size_t... Why not use spprintf before you make it even more complex?

Re: [PHP-CVS] cvs: php4 /main SAPI.c

2003-02-10 Thread Marcus Börger
At 21:40 10.02.2003, Moriyoshi Koizumi wrote: [EMAIL PROTECTED] (Marcus Börger) wrote: Why not use spprintf before you make it even more complex? Something like this: if(!strstr(lower_temp,realm)) { efree(result); spprintf(result, 0, %s realm=\%ld\,ptr, myuid); } Because

Re: [PHP-CVS] cvs: php4 /main SAPI.c

2003-02-10 Thread Marcus Börger
Have you looked at smart_strs? That's the way to go, if you want to get rid of nasty size calculations/checks and ugly memcpy calls. Basically spprintf was designed to be an easy replacement for all the other sprintf derivates. But perhaps i should have used the smart strings

Re: [PHP-CVS] cvs: php4 /ext/dba config.m4

2003-02-09 Thread Marcus Börger
At 20:57 09.02.2003, Jani Taskinen wrote: sniper Sun Feb 9 14:57:51 2003 EDT Modified files: /php4/ext/dba config.m4 Log: break: First one not needed, second missing. Thanks for the fix :-) marcus -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe,

Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2003-02-08 Thread Marcus Börger
At 15:56 08.02.2003, Jani Taskinen wrote: Just curious..but was there some agreement on keeping these obscure options?? I kinda missed the discussion.. --Jani Some few people were against and Edin liked the idea after playing around with it. So both maintainers of the cli sapi

Re: [PHP-CVS] cvs: php4 /ext/bcmath bcmath.c

2003-02-04 Thread Marcus Börger
At 22:07 04.02.2003, Andi Gutmans wrote: andiTue Feb 4 16:07:40 2003 EDT Modified files: /php4/ext/bcmathbcmath.c Log: - Please follow coding standards (this isn't java :) I only corrected this... -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe,

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-02-03 Thread Marcus Börger
At 12:25 03.02.2003, Jani Taskinen wrote: Isn't XPM support available with anything but our bundled GD lib?? --Jani Current code says it is only available with bundled version so i added a notice on that. The second reason i did it was that many people will look at the info and

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-02-03 Thread Marcus Börger
At 19:43 03.02.2003, Jani Taskinen wrote: On Mon, 3 Feb 2003, Marcus Börger wrote: At 19:26 03.02.2003, Jani Taskinen wrote: I hope you're not mixing Xpm with XBM ? Since Xpm funcs ARE available in the GD lib from Boutell too.. I hope so, too. I had a look into the source

Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2003-02-02 Thread Marcus Börger
At 08:41 03.02.2003, Sebastian Bergmann wrote: sebastian Mon Feb 3 02:41:06 2003 EDT Modified files: /php4/sapi/cli php_cli.c Log: Fix ZTS build. Thanks, i was sure i did latest changes before commit with a ZTS version...but it seems i have to many php source

Re: [PHP-CVS] cvs: php4 /ext/dba config.m4

2003-01-30 Thread Marcus Börger
Why? I thought when trying to link with only the new libraries i could test them alone. On which library did it fail for you? And if i reset LIBS what is the complete difference? marcus At 19:37 30.01.2003, Jani Taskinen wrote: configure: error: cannot find necessary library You need

Re: [PHP-CVS] cvs: php4 /ext/dba config.m4

2003-01-29 Thread Marcus Börger
At 11:55 28.01.2003, Jani Taskinen wrote: sniper Tue Jan 28 05:55:36 2003 EDT Modified files: /php4/ext/dba config.m4 Log: Fix configure. (typo?) It didn't notice that...it's from my test version where i could need some help but currently i am not at all knowing the

Re: [PHP-CVS] cvs: php4 /ext/dba config.m4

2003-01-29 Thread Marcus Börger
At 00:04 30.01.2003, Marcus Börger wrote: At 11:55 28.01.2003, Jani Taskinen wrote: sniper Tue Jan 28 05:55:36 2003 EDT Modified files: /php4/ext/dba config.m4 Log: Fix configure. (typo?) It didn't notice that...it's from my test version where i could need some help

Re: [PHP-CVS] cvs: php4 /ext/mime_magic config.m4

2003-01-27 Thread Marcus Börger
At 10:23 27.01.2003, Jani Taskinen wrote: It still looks for '/usr/share/magic' file thus your fix doesn't fix anything. Attached is a bit better version of the config.m4, please let me know if it's ok to commit. --Jani Looks good to me marcus -- PHP CVS Mailing List

Re: [PHP-CVS] cvs: php4 /ext/mime_magic config.m4

2003-01-27 Thread Marcus Börger
At 02:00 28.01.2003, Jani Taskinen wrote: sniper Mon Jan 27 20:00:16 2003 EDT Modified files: /php4/ext/mime_magicconfig.m4 Log: - Cleaned up and made less error-prone - Changed --enable-mime-magic - --with-mime-magic[=FILE] to allow specifying of the file during

Re: [PHP-CVS] cvs: php4 /ext/mime_magic config.m4

2003-01-25 Thread Marcus Börger
At 11:51 25.01.2003, Hartmut Holzgraefe wrote: hholzgraSat Jan 25 05:51:04 2003 EDT Modified files: /php4/ext/mime_magicconfig.m4 Log: suggesting a plain magic file insteat of a mime one is a bad idea Index: php4/ext/mime_magic/config.m4 diff -u

Re: [PHP-CVS] cvs: php4 / configure.in

2003-01-23 Thread Marcus Börger
At 07:42 23.01.2003, Jani Taskinen wrote: sniper Thu Jan 23 01:42:43 2003 EDT Modified files: /php4 configure.in Log: remove this stupid highlight which causes trouble. Which trouble? Other parts of the scripts do exactly the same thing so please revert. regards

Re: [PHP-CVS] cvs: php4 /ext/standard/tests/image getimagesize.phpt

2003-01-18 Thread Marcus Börger
At 00:57 18.01.2003, Ilia Alshanetsky wrote: iliaa Fri Jan 17 18:57:43 2003 EDT Modified files: /php4/ext/standard/tests/image getimagesize.phpt Log: Added missing test result. Thanks - i forgot to commit that one to marcus -- PHP CVS Mailing List

Re: [PHP-CVS] cvs: php4(PHP_4_3) /main SAPI.h

2003-01-18 Thread Marcus Börger
At 11:28 18.01.2003, Andi Gutmans wrote: At 06:42 PM 1/15/2003 +0100, Derick Rethans wrote: On Wed, 15 Jan 2003, Shane Caraveo wrote: Edin Kadribasic wrote: I think that we should relax this contraint a bit on PHP_4_3 due to the fact that head is not likely going to see realeased version

Re: [PHP-CVS] cvs: php4 /ext/exif exif.c

2003-01-18 Thread Marcus Börger
At 19:32 18.01.2003, Ilia Alshanetsky wrote: iliaa Sat Jan 18 13:32:21 2003 EDT Modified files: /php4/ext/exif exif.c Log: Removed the no longer needed memory allocation checks. After my reworked patch - what made you sure EXIF_ERRLOG_FSREALLOC is not needed? marcus

Re: [PHP-CVS] cvs: php4 /ext/swf swf.c

2003-01-18 Thread Marcus Börger
/docref.txt I hope that helps :-) marcus p.s: Wow excluding google bot it was downloaded 300 times...121 times referred from http://www.zend.com/zend/week/week112.php - iguess avin was a bit missleading in his summary. -- -- Marcus

Re: [PHP-CVS] cvs: php4 /ext/swf swf.c

2003-01-18 Thread Marcus Börger
At 21:35 18.01.2003, Marcus Börger wrote: At 21:35 18.01.2003, Ilia A. wrote: My next goal is to remove some 690 php_error() form ext/ and about 100 or so zend_error(). So, if you have any automated tools, they'd be of great help. Ilia I meant the php_error thing and for that i have a script

RE: [PHP-CVS] cvs: php4 /ext/com .cvsignore COM.c CREDITS TODO VARIANT.c com.h conversion.c conversion.h dispatch.c php_COM.h php_VARIANT.h variant.h

2003-01-11 Thread Marcus Börger
At 09:57 11.01.2003, Harald Radi wrote: Removed files: /php4/ext/com the ZE2 version is located in ext/rpc/com so what's wrong ? ok my fault - i just missread the mail sorry marcus -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/overload .cvsignore CREDITS README config.m4 overload.c overload.dsp php_overload.h

2003-01-10 Thread Marcus Börger
At 00:40 11.01.2003, Harald Radi wrote: phanto Fri Jan 10 18:40:13 2003 EDT Removed files: /php4/ext/overload .cvsignore config.m4 CREDITS overload.c overload.dsp php_overload.h README Log: this is now implemented by the engine itself But now you

Re: [PHP-CVS] cvs: php4 / NEWS

2003-01-04 Thread Marcus Börger
At 01:06 03.01.2003, Jani Taskinen wrote: sniper Thu Jan 2 19:06:24 2003 EDT Modified files: /php4 NEWS Log: - Removed entries that are going to 4.3.1 - Grouped the entries a bit. Index: php4/NEWS diff -u php4/NEWS:1.1297 php4/NEWS:1.1298 --- php4/NEWS:1.1297Mon

Re: [PHP-CVS] cvs: php4(PHP_4_3) /ext/openssl openssl.c

2002-12-12 Thread Marcus Börger
At 14:38 12.12.2002, Edin Kadribasic wrote: Don't you thinks its a bit late (after RC3) for this large patch? Edin I don't think whitespace and php_error_docref changes are problematic. marcus - Original Message - From: Marcus Boerger [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent:

Re: [PHP-CVS] cvs: php4(PHP_4_3) /ext/openssl openssl.c

2002-12-12 Thread Marcus Börger
Thanks for noticing marcus At 15:07 12.12.2002, Derick Rethans wrote: On Thu, 12 Dec 2002, Marcus Börger wrote: At 14:38 12.12.2002, Edin Kadribasic wrote: Don't you thinks its a bit late (after RC3) for this large patch? Edin I don't think whitespace and php_error_docref changes

Re: [PHP-CVS] cvs: php4 /ext/cpdf config.m4

2002-12-11 Thread Marcus Börger
Once again i ask before commiting this to the branch. This and the last patch for cpdf add the necessary checks for the required libraries to avoid missleading error messages from configure in other modules. For me i search some time for configure problems in dba until noticing it was actually a

Re: [PHP-CVS] cvs: php4 /ext/dba dba.c

2002-12-09 Thread Marcus Börger
At 19:38 09.12.2002, Sascha Schumann wrote: On Mon, 9 Dec 2002, Marcus Boerger wrote: helly Mon Dec 9 13:03:01 2002 EDT Modified files: /php4/ext/dba dba.c Log: Recheckin as unix # *** sorry ** a new diff tool converted it to dos before last comit *** sorry ***

Re: [PHP-CVS] cvs: php4 /ext/oci8 config.m4 oci8.c php_oci8.h

2002-12-06 Thread Marcus Börger
In oci_do_connect() you simply changed the number of allowed parameters. What about guarding the 4th parameter by a define and emit a warning or error when using this with a version that does not support this parameter (e.g. 9)? And you could use zend_parse_parameters() to have better code.

Re: [PHP-CVS] cvs: php4 /ext/gd/tests conv_test.gif conv_test.jpeg conv_test.png conv_test.xpm gif2gd.phpt gif2jpg.phpt gif2png.phpt jpeg2png.phpt jpg2gd.phpt png2gd.phpt xpm2gd.phpt xpm2jpg.phpt xpm2png.phpt

2002-12-05 Thread Marcus Börger
Hi Ilia, when testing conversion to gd2 you do not test for gd2 existance (imagegd2() function) instead you assume that the tests fail if one uses an external gd lib (what makes the function check needless of cause). But why is that so? And why not print out an error then? Maybe we direct the

Re: [PHP-CVS] cvs: php4 /ext/standard base64.c dl.c exec.c http_fopen_wrapper.c incomplete_class.c levenshtein.c link.c math.c pack.c reg.c scanf.c uniqid.c url.c var.c

2002-12-05 Thread Marcus Börger
At 22:01 05.12.2002, Derick Rethans wrote: On Thu, 5 Dec 2002, Marcus Boerger wrote: helly Thu Dec 5 15:59:50 2002 EDT Modified files: /php4/ext/standardbase64.c dl.c exec.c http_fopen_wrapper.c incomplete_class.c levenshtein.c link.c

Re: [PHP-CVS] cvs: php4 / TODO /ext/bz2 bz2.c /ext/sockets sockets.c

2002-12-02 Thread Marcus Börger
At 23:15 01.12.2002, Sterling Hughes wrote: sterlingSun Dec 1 17:15:41 2002 EDT Modified files: /php4 TODO /php4/ext/bz2 bz2.c /php4/ext/sockets sockets.c Log: TODO: Cleanup elements that have happened, or most likely won't happen. There is

Re: [PHP-CVS] cvs: php4 /ext/overload config.m4

2002-12-01 Thread Marcus Börger
I hate autoconf :-) But i will move to another check tonight (no time now). marcus At 14:06 01.12.2002, Derick Rethans wrote: On Sun, 1 Dec 2002, Marcus Boerger wrote: helly Sat Nov 30 19:38:31 2002 EDT Modified files: /php4/ext/overloadconfig.m4 Log: Skip

Re: [PHP-CVS] cvs: php4 /ext/overload config.m4

2002-12-01 Thread Marcus Börger
Oh great - you already did it while i was training :-))) thanks marcus At 18:24 01.12.2002, Jani Taskinen wrote: sniper Sun Dec 1 12:24:01 2002 EDT Modified files: /php4/ext/overload config.m4 Log: fix build.. Index: php4/ext/overload/config.m4 diff -u

Re: [PHP-CVS] cvs: php4 /main fopen_wrappers.c

2002-12-01 Thread Marcus Börger
Why not simply change from E_ERROR to E_WARNING? marcus At 22:28 01.12.2002, Shane Caraveo wrote: shane Sun Dec 1 16:28:28 2002 EDT Modified files: /php4/main fopen_wrappers.c Log: php_error_docref aborts cgi. This broke using php as cgi under apache/mod_cgi with the

[PHP-CVS] ZE2 question

2002-11-28 Thread Marcus Börger
This is may be a nice token name, but i do not understand it. When trying to execute: $c = parent::function() I receive: Parse error: parse error, unexpected T_PAAMAYIM_NEKUDOTAYIM in /usr/src/ph marcus -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit:

Re: [PHP-CVS] ZE2 question

2002-11-28 Thread Marcus Börger
Ups - wrong list and wrong example - reposting to php-dev sorry ! At 17:16 28.11.2002, Marcus Börger wrote: This is may be a nice token name, but i do not understand it. When trying to execute: $c = parent::function() I receive: Parse error: parse error, unexpected T_PAAMAYIM_NEKUDOTAYIM

Re: [PHP-CVS] cvs: php4 /ext/exif exif.c

2002-11-26 Thread Marcus Börger
Thats waht i thought, too. At 04:03 27.11.2002, Jani Taskinen wrote: Any added code that does not fix any bugs are not supposed to be MFH'd. --Jani On Wed, 27 Nov 2002, Marcus Börger wrote: Would you agree adding magic_quotes_runtime support is new functionality or commit

Re: [PHP-CVS] cvs: php4 /ext/pgsql pgsql.c

2002-11-24 Thread Marcus Börger
At 08:45 24.11.2002, Yasuo Ohgaki wrote: yohgaki Sun Nov 24 02:45:27 2002 EDT Modified files: /php4/ext/pgsql pgsql.c Log: Added missing '\0' Index: php4/ext/pgsql/pgsql.c diff -u php4/ext/pgsql/pgsql.c:1.244 php4/ext/pgsql/pgsql.c:1.245 --- php4/ext/pgsql/pgsql.c:1.244

Re: [PHP-CVS] cvs: php4 /ext/standard basic_functions.c config.m4 dns.c dns.h

2002-11-19 Thread Marcus Börger
No - go on - marcus At 07:35 19.11.2002, Derick Rethans wrote: On Tue, 19 Nov 2002, Marcus Boerger wrote: helly Mon Nov 18 21:34:14 2002 EDT Modified files: /php4/ext/standardbasic_functions.c config.m4 dns.c dns.h Log: -rename checkdnsrr to dns_check_record,

Re: [PHP-CVS] cvs: php4 /ext/standard image.c

2002-11-18 Thread Marcus Börger
Yes i thought also i think we should have one that has the bit 7 set for width and height and it should have one bit more set in the second byte. And width and height should be different. This would lead us to an image of (256+128) * (256+128+1) = 384 * 385 pixels in size. As most images are

Re: [PHP-CVS] cvs: php4 / configure.in /ext/db config.m4

2002-11-15 Thread Marcus Börger
Is this ok to be MFHed? marcus At 12:49 15.11.2002, Marcus Boerger wrote: helly Fri Nov 15 06:49:58 2002 EDT Modified files: /php4/ext/dbconfig.m4 /php4 configure.in Log: db is deprecated now Index: php4/ext/db/config.m4 diff -u

Re: [PHP-CVS] cvs: php4 /ext/domxml/tests domxml002.phpt

2002-11-15 Thread Marcus Börger
But we do not have a memleak any longer there. So it shouldn't crash nor report a memleak. marcus At 13:16 15.11.2002, Derick Rethans wrote: On Fri, 15 Nov 2002, Marcus Boerger wrote: helly Fri Nov 15 06:55:57 2002 EDT Modified files: /php4/ext/domxml/testsdomxml002.phpt

Re: [PHP-CVS] cvs: php4 /ext/gd/tests bug19366.phpt

2002-11-15 Thread Marcus Börger
?????? there is no ini section any longer since it was empty At 16:33 15.11.2002, Derick Rethans wrote: On Fri, 15 Nov 2002, Marcus Boerger wrote: helly Fri Nov 15 10:22:07 2002 EDT Modified files: /php4/ext/gd/testsbug19366.phpt Log: Simplify and show skip

Re: [PHP-CVS] cvs: php4 /ext/gd/tests imagefilter.phpt test.png

2002-11-15 Thread Marcus Börger
The tests fails for me in lines 10 and 16. Maybe it would be much better to make an include file for the test blocks and then call it for each filter from a different .phpt file. marcus At 21:04 13.11.2002, Ilia Alshanetsky wrote: iliaa Wed Nov 13 15:04:00 2002 EDT Added files:

Re: [PHP-CVS] cvs: php4 /ext/mbstring mbstring.h

2002-11-14 Thread Marcus Börger
I just worked on the branch for the same problem :-) marcus At 13:06 14.11.2002, Wez Furlong wrote: wez Thu Nov 14 07:06:02 2002 EDT Modified files: /php4/ext/mbstring mbstring.h Log: Fix build for unix. Not sure if this needs merging to the branch (haven't got that

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2002-11-14 Thread Marcus Börger
Plase make sure you are using a TSRM build while developing. [marcuszaphod PHP_4_3_0]$ ./configure --help|grep tsrm --with-tsrm-pth[=pth-config]Use GNU Pth. --with-tsrm-st --with-tsrm-pthreadsUse POSIX threads (default) marcus At 16:09 14.11.2002, Marcus Boerger wrote: helly

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2002-11-14 Thread Marcus Börger
Ups - Sorry - i missed that one of cause...thanks At 16:25 14.11.2002, Derick Rethans wrote: On Thu, 14 Nov 2002, Marcus Börger wrote: Plase make sure you are using a TSRM build while developing. [marcuszaphod PHP_4_3_0]$ ./configure --help|grep tsrm --with-tsrm-pth[=pth-config]Use

Re: [PHP-CVS] cvs: php4 /ext/gd/libgd gd.c

2002-11-14 Thread Marcus Börger
I always compile with all warnings enabled and fix warnings for linux and windows builds. I am mostly using gcc -Wall -Wconversion -ggdb [marcuszaphod PHP_4_3_0]$ gcc -v Reading specs from /usr/lib/gcc-lib/i586-mandrake-linux-gnu/2.96/specs gcc version 2.96 2731 (Mandrake Linux 8.2

Re: [PHP-CVS] cvs: php4 /ext/gd/libgd gd.c

2002-11-14 Thread Marcus Börger
At 16:51 14.11.2002, Ilia A. wrote: On November 14, 2002 10:45 am, Marcus Börger wrote: I always compile with all warnings enabled and fix warnings for linux and windows builds. I am mostly using gcc -Wall -Wconversion -ggdb Thanks, I'll add -Wconversion to my CFLAGS. [marcuszaphod

Re: [PHP-CVS] cvs: php4(PHP_4_3) / configure.in /main php_version.h

2002-11-14 Thread Marcus Börger
As far as i understood this should be EXTRA_VERSION=RC1, shouldn't it? marcus At 17:47 14.11.2002, you wrote: andrei Thu Nov 14 11:47:03 2002 EDT Modified files: (Branch: PHP_4_3) /php4 configure.in /php4/main php_version.h Log: Go for RC1. Index:

Re: [PHP-CVS] cvs: php4(PHP_4_3) / run-tests.php

2002-11-14 Thread Marcus Börger
Will we have extra safe_mode tests then? marcus At 19:38 14.11.2002, Ilia Alshanetsky wrote: iliaa Thu Nov 14 13:38:25 2002 EDT Modified files: (Branch: PHP_4_3) /php4 run-tests.php Log: MFH (disable safe_mode for test). Index: php4/run-tests.php diff

Re: [PHP-CVS] cvs: php4 /ext/dba dba.c dba_cdb.c dba_db2.c dba_db3.c dba_dbm.c dba_flatfile.c dba_gdbm.c dba_ndbm.c

2002-11-13 Thread Marcus Börger
At 18:59 06.11.2002, Sascha Schumann wrote: sas Wed Nov 6 12:59:04 2002 EDT Modified files: /php4/ext/dba dba.c dba_cdb.c dba_db2.c dba_db3.c dba_dbm.c dba_flatfile.c dba_gdbm.c dba_ndbm.c Log: emalloc never returns 0, so we can simplify the

Re: [PHP-CVS] cvs: php4 /ext/dba dba.c dba_cdb.c dba_db2.c dba_db3.c dba_dbm.c dba_flatfile.c dba_gdbm.c dba_ndbm.c

2002-11-13 Thread Marcus Börger
At 13:37 13.11.2002, Sascha Schumann wrote: On Wed, 13 Nov 2002, Marcus Börger wrote: At 18:59 06.11.2002, Sascha Schumann wrote: sas Wed Nov 6 12:59:04 2002 EDT Modified files: /php4/ext/dba dba.c dba_cdb.c dba_db2.c dba_db3.c dba_dbm.c

Re: [PHP-CVS] cvs: php4 /ext/dba dba.c dba_cdb.c dba_db2.c dba_db3.c dba_dbm.c dba_flatfile.c dba_gdbm.c dba_ndbm.c

2002-11-13 Thread Marcus Börger
At 14:14 13.11.2002, Sascha Schumann wrote: You're right the compiler knows the size in the caller function but not in ecalloc of cause. Shouldn't then ecalloc be a compiler define? #define ecalloc(num, size) \ memset( emalloc(num*size), 0, num*size) It was like that until Aug 18th.

Re: [PHP-CVS] cvs: php4 /ext/ming ming.c

2002-11-12 Thread Marcus Börger
Hm i have a tsrm build but it compiled - thanks anyway. marcus At 15:18 12.11.2002, Ilia Alshanetsky wrote: iliaa Tue Nov 12 09:18:24 2002 EDT Modified files: /php4/ext/ming ming.c Log: Fixed compile error. Index: php4/ext/ming/ming.c diff -u

Re: [PHP-CVS] cvs: php4 /ext/standard string.c

2002-11-12 Thread Marcus Börger
. Why don't you take over it once you're there :) -- Maxim Maletsky [EMAIL PROTECTED] On Thu, 24 Oct 2002 19:11:50 - Marcus Börger [EMAIL PROTECTED] wrote: helly Thu Oct 24 15:11:50 2002 EDT Modified files: /php4/ext/standardstring.c Log: fix compiler warning

Re: [PHP-CVS] cvs: php4 /ext/standard math.c

2002-11-11 Thread Marcus Börger
Why not use php_error_docref which automatically uses new error message format with functionname? marcus At 06:35 11.11.2002, Jason Greene wrote: jason Mon Nov 11 00:35:05 2002 EDT Modified files: /php4/ext/standard math.c Log: Report function name when log() triggers a

Re: [PHP-CVS] cvs: php4 /tests/lang bug17882.phpt

2002-11-10 Thread Marcus Börger
At 19:57 10.11.2002, Derick Rethans wrote: On Sun, 10 Nov 2002, Moriyoshi Koizumi wrote: moriyoshi Sun Nov 10 13:43:19 2002 EDT Added files: /php4/tests/lang bug17882.phpt Log: Added a test case for bug #17882 [snip] --EXPECTF-- Fatal error: Cannot redeclare a()

Re: [PHP-CVS] cvs: php4 /ext/standard/tests/image getimagesize.phpt image_type_to_mime_type.phpt skipif_imagetype.inc

2002-11-08 Thread Marcus Börger
Why remove the IMAGETYPE_SWC check comment here. I wrote it to the list complete, so everyone can see that some types are excluded. Anyway thanks for the swf/swc files and tests! marcus At 03:50 08.11.2002, Ilia Alshanetsky wrote: iliaa Thu Nov 7 21:50:28 2002 EDT Modified files:

Re: [PHP-CVS] cvs: php4 /ext/standard/tests/strings htmlentities06.phpt

2002-11-08 Thread Marcus Börger
Thats clear. My comment had a different background: When there is no error until access to $php_errormsg you will receive your warning then. Thats why i used if($php_errormsg) ... marcus At 18:15 08.11.2002, Ilia A. wrote: We need to set it to NULL because it may be already set by another PHP

[PHP-CVS] cvs: php4 /ext/dba dba_gdbm.c

2002-11-07 Thread Marcus Börger
helly Thu Nov 7 08:00:38 2002 EDT Modified files: /php4/ext/dba dba_gdbm.c Log: remove debug output and use php_error_docref instead Index: php4/ext/dba/dba_gdbm.c diff -u php4/ext/dba/dba_gdbm.c:1.15 php4/ext/dba/dba_gdbm.c:1.16 ---

[PHP-CVS] cvs: php4 /ext/dba dba_flatfile.c /ext/dba/libflatfile flatfile.c flatfile.h

2002-11-07 Thread Marcus Börger
helly Thu Nov 7 18:03:16 2002 EDT Modified files: /php4/ext/dba dba_flatfile.c /php4/ext/dba/libflatfile flatfile.c flatfile.h Log: -rename anything to flatfile_xxx/FLATFILE_xxx -fix update function -add warnings for update function

[PHP-CVS] cvs: php4 /ext/db/tests 003.phpt

2002-11-07 Thread Marcus Börger
helly Thu Nov 7 18:03:59 2002 EDT Modified files: /php4/ext/db/tests 003.phpt Log: expand test: see if another insert fails Index: php4/ext/db/tests/003.phpt diff -u php4/ext/db/tests/003.phpt:1.3 php4/ext/db/tests/003.phpt:1.4 ---

[PHP-CVS] cvs: php4 /ext/dba config.m4 dba.c dba_flatfile.c dba_flatile.c /ext/dba/libflatfile flatfile.c flatfile.h

2002-11-06 Thread Marcus Börger
helly Wed Nov 6 04:17:51 2002 EDT Added files: /php4/ext/dba dba_flatfile.c Removed files: /php4/ext/dba dba_flatile.c Modified files: /php4/ext/dba config.m4 dba.c /php4/ext/dba/libflatfile

[PHP-CVS] cvs: php4 /ext/dba config.m4

2002-11-06 Thread Marcus Börger
helly Wed Nov 6 05:08:38 2002 EDT Modified files: /php4/ext/dba config.m4 Log: There shall never be an external library for this (hopefully). Index: php4/ext/dba/config.m4 diff -u php4/ext/dba/config.m4:1.27 php4/ext/dba/config.m4:1.28 ---

[PHP-CVS] cvs: php4 /ext/dba dba_flatfile.c

2002-11-06 Thread Marcus Börger
helly Wed Nov 6 05:43:41 2002 EDT Modified files: /php4/ext/dba dba_flatfile.c Log: fix locks and reading #i will extend the tests to guard on such failures Index: php4/ext/dba/dba_flatfile.c diff -u php4/ext/dba/dba_flatfile.c:1.1

[PHP-CVS] cvs: php4 /ext/dba/tests skipif.inc

2002-11-06 Thread Marcus Börger
helly Wed Nov 6 06:59:14 2002 EDT Modified files: /php4/ext/dba/tests skipif.inc Log: -convert from dos to unix file -disallow cdb_make Index: php4/ext/dba/tests/skipif.inc diff -u php4/ext/dba/tests/skipif.inc:1.2 php4/ext/dba/tests/skipif.inc:1.3 ---

[PHP-CVS] cvs: php4 /ext/dba/tests dba_handler.inc test.inc

2002-11-06 Thread Marcus Börger
helly Wed Nov 6 07:01:38 2002 EDT Modified files: /php4/ext/dba/tests dba_handler.inc test.inc Log: -convert from dos to unix file Index: php4/ext/dba/tests/dba_handler.inc diff -u php4/ext/dba/tests/dba_handler.inc:1.2

[PHP-CVS] cvs: php4 /ext/dbx/tests 005.phpt

2002-11-06 Thread Marcus Börger
helly Wed Nov 6 11:56:44 2002 EDT Modified files: /php4/ext/dbx/tests 005.phpt Log: added missing magic_quotes_runtime=0 Index: php4/ext/dbx/tests/005.phpt diff -u php4/ext/dbx/tests/005.phpt:1.8 php4/ext/dbx/tests/005.phpt:1.9 ---

  1   2   >