[PHP-CVS] Re: cvs: php-src(PHP_5_2) / NEWS /ext/mysqli mysqli.c

2006-07-10 Thread Michael Wallner
Dmitry Stogov wrote: Hi Michael, Seems I was wrong and your patch was correct. It just didn't handle error case. I committed another fix. Please review it. Yes, this seems to work fine now. Thanks, -- Michael -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.ph

[PHP-CVS] RE: cvs: php-src(PHP_5_2) / NEWS /ext/mysqli mysqli.c

2006-07-10 Thread Dmitry Stogov
Hi Michael, Seems I was wrong and your patch was correct. It just didn't handle error case. I committed another fix. Please review it. Dmitry. > -Original Message- > From: Dmitry Stogov [mailto:[EMAIL PROTECTED] > Sent: Monday, July 10, 2006 4:01 PM > To: 'Michael Wallner' > Cc: 'php-c

[PHP-CVS] RE: cvs: php-src(PHP_5_2) / NEWS /ext/mysqli mysqli.c

2006-07-10 Thread Dmitry Stogov
Hi Michael, I see. :( Tony alredy pointed me into this crash. I understood the reason of crash in #36949. It is the "invalid" order of destructors calls. Your fix was invalid too. It caused SIGSEGV in #38003. But probably it was good-enough workaround. You can revert my patch. I'll think about

[PHP-CVS] Re: cvs: php-src(PHP_5_2) / NEWS /ext/mysqli mysqli.c

2006-07-10 Thread Michael Wallner
Dmitry Stogov wrote: dmitry Mon Jul 10 10:05:20 2006 UTC Modified files: (Branch: PHP_5_2) /php-src NEWS /php-src/ext/mysqli mysqli.c Log: Fixed bug #38019 (segfault extending mysqli class) Hi Dmitry, you basically reverted my patch to fix #36949 which se