[PHP-CVS] Re: cvs: php-src /ext/pdo_sqlite sqlite_statement.c

2009-04-01 Thread Alexey Zakhlestin
2009/4/1 Scott MacVicar : > It's valid to discard the const qualifier, add_assoc_string runs > estrndup to take a copy of the return value anyway. > > You've also made the code less readable and introduced a memory leak for > str. > > So unless I've missed something can you revert this please. don

[PHP-CVS] Re: cvs: php-src /ext/pdo_sqlite sqlite_statement.c

2009-04-01 Thread Scott MacVicar
It's valid to discard the const qualifier, add_assoc_string runs estrndup to take a copy of the return value anyway. You've also made the code less readable and introduced a memory leak for str. So unless I've missed something can you revert this please. Scott Alexey Zakhlestin wrote: > indeyet