Re: [PHP-CVS] com php-src: These need to be volatile in order to prevent leaking after the longjmp in the error handler: ext/gd/libgd/gd_png.c

2012-11-07 Thread Rasmus Lerdorf
On 11/06/2012 12:06 PM, Nuno Lopes wrote: While I won't oppose this patch since it has no performance impact, I believe this is a bug in the compiler and not in the code below. The compiler should know about setjmp(). glibc, for example, marks that function with __attribute__((returns_twice)).

Re: [PHP-CVS] com php-src: These need to be volatile in order to prevent leaking after the longjmp in the error handler: ext/gd/libgd/gd_png.c

2012-11-06 Thread Nuno Lopes
While I won't oppose this patch since it has no performance impact, I believe this is a bug in the compiler and not in the code below. The compiler should know about setjmp(). glibc, for example, marks that function with __attribute__((returns_twice)). Nuno - Original Message - From:

[PHP-CVS] com php-src: These need to be volatile in order to prevent leaking after the longjmp in the error handler: ext/gd/libgd/gd_png.c

2012-11-05 Thread Rasmus Lerdorf
Commit:f452b9056e89aa1bf18d6c0828ba709c0f8df854 Author:Rasmus Lerdorf ras...@php.net Mon, 5 Nov 2012 20:56:19 -0800 Parents: 153bfada90b0733943c31e9d7e2bee57c5e7bcac Branches: PHP-5.4 Link:

[PHP-CVS] com php-src: These need to be volatile in order to prevent leaking after the longjmp in the error handler: ext/gd/libgd/gd_png.c

2012-11-05 Thread Rasmus Lerdorf
Commit:261e32f6236429fcccf61e80262c9df9589d494c Author:Rasmus Lerdorf ras...@php.net Mon, 5 Nov 2012 20:56:19 -0800 Parents: 7bcb8780e0ed042888f88c78919b7726be9ea931 Branches: master Link:

[PHP-CVS] com php-src: These need to be volatile in order to prevent leaking after the longjmp in the error handler: ext/gd/libgd/gd_png.c

2012-11-05 Thread Rasmus Lerdorf
Commit:f8c280d85a3fc5b02e9b19f4e23ddac233abf1e4 Author:Rasmus Lerdorf ras...@php.net Mon, 5 Nov 2012 20:56:19 -0800 Parents: 90bd54c46e0195f65a1a49ac0c01f139915a2dd3 Branches: PHP-5.3 Link: