[PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2005-05-22 Thread Antony Dovgal
tony2001Sun May 22 08:59:30 2005 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: MFH: fix compile warning http://cvs.php.net/diff.php/php-src/ext/session/session.c?r1=1.336.2.52&r2=1.336.2.53&ty=u Index: php-src/ext/ses

[PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2005-02-13 Thread Jani Taskinen
sniper Sun Feb 13 12:51:33 2005 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: MFH: - Added the alias session_commit() (more intuitive name for session_write_close()) MFH: - Partial sync of the file by adding macro SESSION_CHECK

[PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2005-01-21 Thread Stefan Esser
sesser Fri Jan 21 11:04:54 2005 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: MFH http://cvs.php.net/diff.php/php-src/ext/session/session.c?r1=1.336.2.48&r2=1.336.2.49&ty=u Index: php-src/ext/session/session.c diff -u php

[PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2005-01-09 Thread Antony Dovgal
tony2001Sun Jan 9 12:57:51 2005 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: MFH: fix bug #31454 http://cvs.php.net/diff.php/php-src/ext/session/session.c?r1=1.336.2.47&r2=1.336.2.48&ty=u Index: php-src/ext/session/

[PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2004-12-09 Thread Antony Dovgal
tony2001Thu Dec 9 12:16:58 2004 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: CS changes http://cvs.php.net/diff.php/php-src/ext/session/session.c?r1=1.336.2.46&r2=1.336.2.47&ty=u Index: php-src/ext/session/session.c

[PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2004-12-09 Thread Antony Dovgal
tony2001Thu Dec 9 09:21:13 2004 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: MFH: fix segfault in session_module_name() when session.save_handler is empty http://cvs.php.net/diff.php/php-src/ext/session/session.c?r1

[PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2004-09-30 Thread Antony Dovgal
tony2001Thu Sep 30 10:18:25 2004 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: MFH: fix segfaults and bug #30282 and suppress compile warnings http://cvs.php.net/diff.php/php-src/ext/session/session.c?r1=1.336.2.42&r2

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2004-09-04 Thread Masaki Fujimoto
Hello, this seems rather old commit anyway, may I ask why this is not merged into php-5 trees? I think without this, some scripts will misbehave in php 5. for instance: (php.ini) ...snip... session.use_cookies = 1 session.cookie_lifetime = 0 ...snip... (foo.php) if (!empty($_COOKIE[$session_na

[PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2004-09-02 Thread Ilia Alshanetsky
iliaa Thu Sep 2 20:53:47 2004 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: MFH: Fixed bug #29925 (Added a check to prevent illegal characters in session key). http://cvs.php.net/diff.php/php-src/ext/session/session.c?r

[PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2004-06-23 Thread Sascha Schumann
sas Wed Jun 23 12:29:17 2004 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: - fix logic. if the client already sent us the cookie, we don't need to send it again. if the id has been changed, we need to update the client

[PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2004-02-18 Thread Jani Taskinen
sniper Wed Feb 18 21:13:41 2004 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: MFH: emalloc -> safe_emalloc http://cvs.php.net/diff.php/php-src/ext/session/session.c?r1=1.336.2.32&r2=1.336.2.33&ty=u Index: php-src/ext/session/se

[PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2004-02-18 Thread Jani Taskinen
sniper Wed Feb 18 20:54:45 2004 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: MFH: improve error message http://cvs.php.net/diff.php/php-src/ext/session/session.c?r1=1.336.2.31&r2=1.336.2.32&ty=u Index: php-src/ext/session/sess

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-12-08 Thread Jani Taskinen
Oops? :) (thanks for fixing it) --Jani On Mon, 8 Dec 2003, Ard Biesheuvel wrote: >abies Mon Dec 8 05:01:12 2003 EDT > > Modified files: (Branch: PHP_4_3) >/php-src/ext/session session.c > Log: > Fix build > > >Index: php-s

[PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-12-08 Thread Ard Biesheuvel
abies Mon Dec 8 05:01:12 2003 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: Fix build Index: php-src/ext/session/session.c diff -u php-src/ext/session/session.c:1.336.2.30 php-src/ext/session/session.c:1.336.2.31 --- php-

[PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-08-29 Thread Sascha Schumann
sas Fri Aug 29 08:35:15 2003 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: MFH Fix a segfault which occured when using a storage format not capable of expressing references (e.g. WDDX) and deserializing a session variabl

[PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-08-28 Thread Andrey Hristov
andrey Thu Aug 28 16:26:33 2003 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: \n at the end of the message is not needed Index: php-src/ext/session/session.c diff -u php-src/ext/session/session.c:1.336.2.26 php-src/ext/session

[PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-08-28 Thread Sascha Schumann
sas Thu Aug 28 13:34:31 2003 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: format string fix Index: php-src/ext/session/session.c diff -u php-src/ext/session/session.c:1.336.2.25 php-src/ext/session/session.c:1.336.2.26 ---

[PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-08-26 Thread Jani Taskinen
sniper Mon Aug 25 22:16:24 2003 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: More crap from previous commits Index: php-src/ext/session/session.c diff -u php-src/ext/session/session.c:1.336.2.24 php-src/ext/session/session.c:

[PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-08-26 Thread Jani Taskinen
sniper Mon Aug 25 22:15:20 2003 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: Fix typo Index: php-src/ext/session/session.c diff -u php-src/ext/session/session.c:1.336.2.23 php-src/ext/session/session.c:1.336.2.24 --- php-src/

[PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-08-26 Thread Jani Taskinen
sniper Mon Aug 25 22:05:54 2003 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: MFH: - Fixed crash bug when non-existing save/serializer handler is used Index: php-src/ext/session/session.c diff -u php-src/ext/session/session.c:1

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-07-22 Thread Zeev Suraski
At 14:56 22/07/2003, Sascha Schumann wrote: > Can you give me a concrete example of when you think this macro doesn't > behave properly? If it's correct, I'll try to fix it. Note that the last > time you had problems with this (and other) macros these were actually bugs > in the session module.

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-07-22 Thread Sascha Schumann
> Can you give me a concrete example of when you think this macro doesn't > behave properly? If it's correct, I'll try to fix it. Note that the last > time you had problems with this (and other) macros these were actually bugs > in the session module. That was another instance showing the in

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-07-22 Thread Zeev Suraski
At 13:49 22/07/2003, Sascha Schumann wrote: On Tue, 22 Jul 2003, Zeev Suraski wrote: > At 12:22 22/07/2003, Sascha Schumann wrote: > > If it is not irregular, the engine code should be able to > > deal with it correctly. Right now, it falls over itself > > quickly and dies ungracefull

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-07-22 Thread Zeev Suraski
At 13:46 22/07/2003, Sascha Schumann wrote: On Tue, 22 Jul 2003, Zeev Suraski wrote: > At 12:22 22/07/2003, Sascha Schumann wrote: > > If it is not irregular, the engine code should be able to > > deal with it correctly. Right now, it falls over itself > > quickly and dies ungracefull

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-07-22 Thread Sascha Schumann
On Tue, 22 Jul 2003, Zeev Suraski wrote: > At 12:22 22/07/2003, Sascha Schumann wrote: > > If it is not irregular, the engine code should be able to > > deal with it correctly. Right now, it falls over itself > > quickly and dies ungracefully. > > Then ZEND_SET_SYMBOL_WITH_LENGTH shou

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-07-22 Thread Sascha Schumann
On Tue, 22 Jul 2003, Zeev Suraski wrote: > At 12:22 22/07/2003, Sascha Schumann wrote: > > If it is not irregular, the engine code should be able to > > deal with it correctly. Right now, it falls over itself > > quickly and dies ungracefully. > > Then ZEND_SET_SYMBOL_WITH_LENGTH shou

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-07-22 Thread Zeev Suraski
At 12:22 22/07/2003, Sascha Schumann wrote: If it is not irregular, the engine code should be able to deal with it correctly. Right now, it falls over itself quickly and dies ungracefully. Then ZEND_SET_SYMBOL_WITH_LENGTH should be fixed. I'm not sure who wrote it, but it wasn't Andi

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-07-22 Thread Sascha Schumann
On Tue, 22 Jul 2003, Zeev Suraski wrote: > At 04:10 22/07/2003, Sascha Schumann wrote: > >sas Mon Jul 21 21:10:31 2003 EDT > > > > Modified files: (Branch: PHP_4_3) > > /php-src/ext/sessionsession.c > > Log: > > Proper fix for #24592 > > > > The core is

Re: [PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-07-22 Thread Zeev Suraski
At 04:10 22/07/2003, Sascha Schumann wrote: sas Mon Jul 21 21:10:31 2003 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: Proper fix for #24592 The core issue is that undefined variables are refcounted (refcount != 0) while is_

[PHP-CVS] cvs: php-src(PHP_4_3) /ext/session session.c

2003-07-21 Thread Sascha Schumann
sas Mon Jul 21 21:10:31 2003 EDT Modified files: (Branch: PHP_4_3) /php-src/ext/sessionsession.c Log: Proper fix for #24592 The core issue is that undefined variables are refcounted (refcount != 0) while is_ref is still set to 0. I don't know whe