Antony Dovgal wrote:
Tony,
why do you set reconnect as default? If someone needs to reconnect, he
should set mysqli.reconnect.
Your change will break BC: mysql_ping now tries to reconnect
automatically which has bad side effects: Several values of the
connection are reset and the php
On 04/23/2007 11:59 AM, Georg Richter wrote:
Antony Dovgal wrote:
Tony,
why do you set reconnect as default? If someone needs to reconnect, he
should set mysqli.reconnect.
Your change will break BC: mysql_ping now tries to reconnect
automatically which has bad side effects: Several values of
Antony Dovgal wrote:
No, my change was supposed to make the function behave as documented.
The BC has been broken long before, in MySQL API.
This change is documented in mysql api documentation - however we need
to update PHP docs.
/Georg
--
Georg Richter, Development Manager - Connectors
Privet,
Antony Dovgal wrote:
On 04/15/2007 12:11 AM, Andrey Hristov wrote:
http://php.net/mysqli_ping
mysqli_ping, mysqli-ping()  Pings a server connection, or
*tries to
reconnect if the connection has gone down*
Then the fix is wrong, it should set reconnect only for the
tony2001Sat Apr 14 10:35:05 2007 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/mysqli mysqli_nonapi.c
Log:
MFH
http://cvs.php.net/viewvc.cgi/php-src/ext/mysqli/mysqli_nonapi.c?r1=1.54.2.7.2.2r2=1.54.2.7.2.3diff_format=u
Index:
Hi Tony,
Antony Dovgal wrote:
tony2001 Sat Apr 14 10:35:05 2007 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/mysqli mysqli_nonapi.c
Log:
MFH
On 04/14/2007 07:30 PM, Andrey Hristov wrote:
doing this is definitely bad. Probably it makes mysql_ping() to work but
having reconnect being disabled has its reasons.
http://php.net/mysqli_ping
mysqli_ping, mysqli-ping() — Pings a server connection, or *tries to reconnect
if the connection
Hi,
Antony Dovgal wrote:
On 04/14/2007 07:30 PM, Andrey Hristov wrote:
doing this is definitely bad. Probably it makes mysql_ping() to work but
having reconnect being disabled has its reasons.
http://php.net/mysqli_ping
mysqli_ping, mysqli-ping() — Pings a server connection, or *tries
On 04/15/2007 12:11 AM, Andrey Hristov wrote:
http://php.net/mysqli_ping
mysqli_ping, mysqli-ping() — Pings a server connection, or *tries to
reconnect if the connection has gone down*
Then the fix is wrong, it should set reconnect only for the mysql_ping
call, if reconnect is off.
Could
