[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c

2009-05-01 Thread Antony Dovgal
tony2001Fri May 1 09:22:16 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c Log: initialize ext_len http://cvs.php.net/viewvc.cgi/php-src/ext/phar/phar.c?r1=1.370.2.60&r2=1.370.2.61&diff_format=u Index: php-src/ext/phar/phar.c dif

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar_internal.h phar_object.c tar.c util.c zip.c

2009-04-29 Thread Arnaud Le Blanc
Hi, On Wed, 2009-04-29 at 13:18 -0500, Greg Beaver wrote: > I can get a backtrace using gdb, but no valgrind for > the apache crash, although I haven't tried running the server via > valgrind. Does anyone know if this is even possible to do with a > forking server? Yes, you can try with "valgrin

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar_internal.h phar_object.c tar.c util.c zip.c

2009-04-29 Thread Greg Beaver
Antony Dovgal wrote: > On 29.04.2009 17:50, Greg Beaver wrote: > >> Oh good - you can reproduce it! The segfault is not related to the >> commit, as you can see from the line in question (line 315 of >> phar_file_action is a zval_ptr_dtor of EG(return_value_ptr_ptr), which >> has nothing to do

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar_internal.h phar_object.c tar.c util.c zip.c

2009-04-29 Thread Antony Dovgal
On 29.04.2009 17:50, Greg Beaver wrote: > Oh good - you can reproduce it! The segfault is not related to the > commit, as you can see from the line in question (line 315 of > phar_file_action is a zval_ptr_dtor of EG(return_value_ptr_ptr), which > has nothing to do with streams). Well, I don't re

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar_internal.h phar_object.c tar.c util.c zip.c

2009-04-29 Thread Greg Beaver
Antony Dovgal wrote: > On 29.04.2009 07:24, Greg Beaver wrote: > >> cellog Wed Apr 29 03:24:27 2009 UTC >> >> Modified files: (Branch: PHP_5_3) >> /php-src/ext/pharphar.c phar_internal.h phar_object.c tar.c >> util.c >> zip.

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar_internal.h phar_object.c tar.c util.c zip.c

2009-04-29 Thread Antony Dovgal
On 29.04.2009 07:24, Greg Beaver wrote: > cellogWed Apr 29 03:24:27 2009 UTC > > Modified files: (Branch: PHP_5_3) > /php-src/ext/phar phar.c phar_internal.h phar_object.c tar.c util.c > zip.c > Log: > MFPECL: fix PECL bug #16338, php_

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar_internal.h phar_object.c tar.c util.c zip.c

2009-04-29 Thread Antony Dovgal
On 29.04.2009 07:24, Greg Beaver wrote: > cellogWed Apr 29 03:24:27 2009 UTC > > Modified files: (Branch: PHP_5_3) > /php-src/ext/phar phar.c phar_internal.h phar_object.c tar.c util.c > zip.c > Log: > MFPECL: fix PECL bug #16338, php_

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar_internal.h phar_object.c tar.c util.c zip.c

2009-04-28 Thread Greg Beaver
cellog Wed Apr 29 03:24:27 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c phar_internal.h phar_object.c tar.c util.c zip.c Log: MFPECL: fix PECL bug #16338, php_stream_copy_to_stream{,_ex}() http://cvs.php.net/viewv

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c pharzip.h zip.c

2009-02-19 Thread Greg Beaver
cellog Fri Feb 20 05:06:37 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c pharzip.h zip.c Log: fix zip access to work in all compilers, present and future, and on all arches without potential for bus errors. This removes PHAR_ZIP_PACK in fa

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c zip.c

2009-02-15 Thread Greg Beaver
cellog Sun Feb 15 20:29:13 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c zip.c Log: fix remaining big-endian issues with phar http://cvs.php.net/viewvc.cgi/php-src/ext/phar/phar.c?r1=1.370.2.56&r2=1.370.2.57&diff_format=u Index: php-src/e

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c

2009-01-02 Thread Ilia Alshanetsky
iliaa Fri Jan 2 20:43:41 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c Log: Fixed a possible crash when phar_create_signature() fails http://cvs.php.net/viewvc.cgi/php-src/ext/phar/phar.c?r1=1.370.2.55&r2=1.370.2.56&diff_format=u Ind

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c

2008-11-04 Thread Marcus Boerger
helly Tue Nov 4 13:33:15 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c Log: - MFH Add hash dependency at module source level http://cvs.php.net/viewvc.cgi/php-src/ext/phar/phar.c?r1=1.370.2.52&r2=1.370.2.53&diff_format=u Index: php-src/

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c

2008-11-04 Thread Marcus Boerger
helly Tue Nov 4 14:04:30 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c Log: - MFH We only rely on hash if it is built-in http://cvs.php.net/viewvc.cgi/php-src/ext/phar/phar.c?r1=1.370.2.53&r2=1.370.2.54&diff_format=u Index: php-src/ext/

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar_object.c util.c

2008-10-25 Thread Greg Beaver
cellog Sun Oct 26 05:49:10 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c phar_object.c util.c Log: fix several errors found by valgrind 1 - entry metadata not properly processed or retrieved from cached phars 2 - copy on write was using

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c tar.c zip.c

2008-10-12 Thread Antony Dovgal
tony2001Sun Oct 12 21:09:22 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c tar.c zip.c Log: MFH: fix ZTS build http://cvs.php.net/viewvc.cgi/php-src/ext/phar/phar.c?r1=1.370.2.50&r2=1.370.2.51&diff_format=u Index: php-src/ext/pha

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c stream.c

2008-09-30 Thread Antony Dovgal
On 27.09.2008 03:34, Greg Beaver wrote: > cellogFri Sep 26 23:34:57 2008 UTC > > Modified files: (Branch: PHP_5_3) > /php-src/ext/phar phar.c stream.c > Log: > fix 017.phpt in streams.c, and very dangerous intercepting of file > functions in all cases intro

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c

2008-09-29 Thread Greg Beaver
cellog Tue Sep 30 02:40:17 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c Log: fix Bug #46194: SIGSEGV when requested file is not found http://cvs.php.net/viewvc.cgi/php-src/ext/phar/phar.c?r1=1.370.2.47&r2=1.370.2.48&diff_format=u Index:

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c stream.c

2008-09-26 Thread Greg Beaver
cellog Fri Sep 26 23:34:57 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c stream.c Log: fix 017.phpt in streams.c, and very dangerous intercepting of file functions in all cases introduced in multi-threaded fix http://cvs.php.net/viewvc.c

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c /ext/phar/tests bug46178.phpt

2008-09-26 Thread Greg Beaver
cellog Fri Sep 26 16:29:44 2008 UTC Added files: (Branch: PHP_5_3) /php-src/ext/phar/tests bug46178.phpt Modified files: /php-src/ext/phar phar.c Log: fix bug #46178: memory leak in ext/phar http://cvs.php.net/viewvc.cgi/php-src/ex

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar.phar

2008-08-30 Thread Greg Beaver
cellog Sun Aug 31 06:28:01 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c phar.phar Log: remove superfluous double variable declaration, merge from pecl/phar http://cvs.php.net/viewvc.cgi/php-src/ext/phar/phar.c?r1=1.370.2.42&r2=1.370.2.43

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar.phar

2008-08-30 Thread Greg Beaver
cellog Sun Aug 31 06:13:42 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c phar.phar Log: remove orphaned code, merge from pecl/phar http://cvs.php.net/viewvc.cgi/php-src/ext/phar/phar.c?r1=1.370.2.41&r2=1.370.2.42&diff_format=u Index: php-

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c

2008-08-30 Thread Greg Beaver
cellog Sun Aug 31 06:09:38 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c Log: remove unused variables, merge from pecl/phar http://cvs.php.net/viewvc.cgi/php-src/ext/phar/phar.c?r1=1.370.2.40&r2=1.370.2.41&diff_format=u Index: php-src/ext

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar.phar phar_internal.h stream.c stream.h util.c zip.c /ext/phar/tests/zip bzip2.phpt /ext/phar/tests/zip/files bzip2.zip

2008-08-20 Thread Greg Beaver
cellog Thu Aug 21 05:17:29 2008 UTC Added files: (Branch: PHP_5_3) /php-src/ext/phar/tests/zip bzip2.phpt /php-src/ext/phar/tests/zip/files bzip2.zip Modified files: /php-src/ext/phar phar.c phar.phar phar_internal.h stream.c

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar_internal.h phar_object.c /ext/phar/tests frontcontroller11.phpt /ext/phar/tests/cache_list frontcontroller11.phpt /ext/phar/tests/cache_list/fi

2008-07-22 Thread Dmitry Stogov
dmitry Tue Jul 22 07:03:01 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c phar_internal.h phar_object.c /php-src/ext/phar/tests frontcontroller11.phpt /php-src/ext/phar/tests/cache_list frontcontroller11.phpt /php-src/ext/phar/

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c

2008-07-17 Thread Dmitry Stogov
dmitry Thu Jul 17 14:05:08 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c Log: Fixed search on uninitialized data http://cvs.php.net/viewvc.cgi/php-src/ext/phar/phar.c?r1=1.370.2.33&r2=1.370.2.34&diff_format=u Index: php-src/ext/phar/ph

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c zip.c

2008-07-17 Thread Dmitry Stogov
dmitry Thu Jul 17 13:22:33 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c zip.c Log: Fixed wrong arguments order http://cvs.php.net/viewvc.cgi/php-src/ext/phar/phar.c?r1=1.370.2.32&r2=1.370.2.33&diff_format=u Index: php-src/ext/phar/pha

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c

2008-07-09 Thread Antony Dovgal
tony2001Wed Jul 9 14:15:41 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c Log: add zero-terminator to the delimiter (and make valgrind happy) http://cvs.php.net/viewvc.cgi/php-src/ext/phar/phar.c?r1=1.370.2.30&r2=1.370.2.31&diff

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c

2008-06-21 Thread Greg Beaver
cellog Sat Jun 21 17:05:18 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c Log: PHP 5.2 fixes to direct include of compressed archives http://cvs.php.net/viewvc.cgi/php-src/ext/phar/phar.c?r1=1.370.2.25&r2=1.370.2.26&diff_format=u Index: ph

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c

2008-06-20 Thread Steph Fox
sfoxFri Jun 20 12:21:33 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c Log: The only reason that particular 'real solution' wasn't applied in the first place was that it also breaks the shared build Maybe we don't need to call a non-exi

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c

2008-06-19 Thread Greg Beaver
cellog Fri Jun 20 04:50:11 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c Log: revert really bad solution to the zend_init_rsrc_list/zend_destroy_rsrc_list problem, replace with real solution http://cvs.php.net/viewvc.cgi/php-src/ext/phar

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c tar.c zip.c /ext/phar/tests cached_manifest_1.phpt

2008-06-18 Thread Steph Fox
sfoxWed Jun 18 15:06:50 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c tar.c zip.c /php-src/ext/phar/tests cached_manifest_1.phpt Log: - Kill 10 MSVC compiler warnings due to type conflict - Make cached manifest test platform ag

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar.phar phar_internal.h tar.c zip.c /ext/phar/tests phpinfo_001.phpt phpinfo_002.phpt phpinfo_003.phpt phpinfo_004.phpt

2008-06-18 Thread Steph Fox
reg Beaver" <[EMAIL PROTECTED]> To: ; <[EMAIL PROTECTED]> Sent: Thursday, June 12, 2008 7:56 PM Subject: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar.phar phar_internal.h tar.c zip.c /ext/phar/tests phpinfo_001.phpt phpinfo_002.phpt phpinfo_003.phpt phpinfo_004.phpt

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar.phar

2008-06-15 Thread Greg Beaver
cellog Mon Jun 16 04:10:53 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c phar.phar Log: remove unused variables in phar_fix_filepath copy virtual_dirs to avoid segfault on multi-process fix metadata reading for phar.cache_list initiali

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar.phar

2008-06-15 Thread Greg Beaver
cellog Sun Jun 15 23:00:47 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c phar.phar Log: minor performance improvement http://cvs.php.net/viewvc.cgi/php-src/ext/phar/phar.c?r1=1.370.2.18&r2=1.370.2.19&diff_format=u Index: php-src/ext/phar/

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar.phar phar_internal.h phar_object.c stream.c tar.c zip.c

2008-06-15 Thread Greg Beaver
cellog Sun Jun 15 21:42:20 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c phar.phar phar_internal.h phar_object.c stream.c tar.c zip.c Log: another optimization - move inode hash to initial manifest parsing, improves

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar.phar phar_internal.h phar_object.c

2008-06-15 Thread Greg Beaver
cellog Sun Jun 15 21:15:29 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c phar.phar phar_internal.h phar_object.c Log: minor optimization http://cvs.php.net/viewvc.cgi/php-src/ext/phar/phar.c?r1=1.370.2.16&r2=1.370.2.17&diff_format=u Index

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar.phar phar_internal.h phar_object.c util.c

2008-06-13 Thread Greg Beaver
cellog Fri Jun 13 20:15:19 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c phar.phar phar_internal.h phar_object.c util.c Log: full refactor of signatures complete - now to implement them for tar as a starting point

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c util.c

2008-06-13 Thread Felipe Pena
felipe Fri Jun 13 13:06:46 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c util.c Log: - Fix build (ZTS) http://cvs.php.net/viewvc.cgi/php-src/ext/phar/phar.c?r1=1.370.2.13&r2=1.370.2.14&diff_format=u Index: php-src/ext/phar/phar.c diff

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar.phar phar_internal.h util.c

2008-06-12 Thread Greg Beaver
cellog Fri Jun 13 06:34:41 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c phar.phar phar_internal.h util.c Log: partial refactor - move signature verification into its own function, in preparation for tar/zip signature support. next is sig

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar.phar phar_internal.h tar.c zip.c /ext/phar/tests phpinfo_001.phpt phpinfo_002.phpt phpinfo_003.phpt phpinfo_004.phpt

2008-06-12 Thread Greg Beaver
cellog Thu Jun 12 18:56:23 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c phar.phar phar_internal.h tar.c zip.c /php-src/ext/phar/tests phpinfo_001.phpt phpinfo_002.phpt phpinfo_003.phpt phpinfo_004.phpt

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar.phar

2008-06-09 Thread Greg Beaver
cellog Mon Jun 9 16:07:19 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c phar.phar Log: fix compile warnings if openssl is enabled statically. fix dangerous use of wrong length var in openssl signature verification http://cvs.php.net/vi

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c /ext/phar/tests/zip/files frontcontroller.phar.zip frontcontroller10.phar.zip frontcontroller11.phar.zip frontcontroller12.phar.zip frontcontroller2.p

2008-05-30 Thread Greg Beaver
cellog Fri May 30 22:49:33 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c /php-src/ext/phar/tests/zip/files frontcontroller.phar.zip frontcontroller10.phar.zip

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c /ext/phar/tests/zip unixzip.phpt

2008-05-29 Thread Greg Beaver
cellog Thu May 29 17:34:50 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c /php-src/ext/phar/tests/zip unixzip.phpt Log: fix PECL bug #13981: Third-party zips fail entry interrogation http://cvs.php.net/viewvc.cgi/php-src/ext/phar/phar

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c

2008-05-28 Thread Stanislav Malyshev
stasWed May 28 21:42:21 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c Log: Fix code path in phar_open_compiled_file() that tries to open not-yet-loaded phar and fails on compressed files # By Gregory's request # Sorry, can't find h

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar_object.c tar.c util.c zip.c

2008-05-21 Thread Greg Beaver
cellog Thu May 22 06:33:09 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c phar_object.c tar.c util.c zip.c Log: major fixes * found felipe's segfault in util.c and fixed the segfault (3 tests fail due to odd behavior of . and .. on this m

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c phar_internal.h phar_object.c tar.c

2008-05-21 Thread Greg Beaver
cellog Wed May 21 22:00:43 2008 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/phar phar.c phar_internal.h phar_object.c tar.c Log: fix offset detection in tar files http://cvs.php.net/viewvc.cgi/php-src/ext/phar/phar.c?r1=1.370.2.3&r2=1.370.2.4&diff_forma

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar phar.c /ext/phar/tests phar_dotted_path.phpt

2008-05-13 Thread Steph Fox
sfoxTue May 13 14:11:24 2008 UTC Added files: (Branch: PHP_5_3) /php-src/ext/phar/tests phar_dotted_path.phpt Modified files: /php-src/ext/phar phar.c Log: - Allow broken.dirnames to use phar too - Add test - Kill MSVC compiler