felipe Mon Jun 22 11:37:31 2009 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c
Log:
- Fixed bug #48641 (tmpfile() uses old parameter parsing)
iliaa Sun May 24 16:01:48 2009 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c
/php-src/ext/standard/tests/filefgetcsv_variation14.phpt
fgetcsv_variation21.phpt
Log:
MFB: Improve fix
janiThu May 21 02:15:03 2009 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c
Log:
MFH: ws
http://cvs.php.net/viewvc.cgi/php-src/ext/standard/file.c?r1=1.409.2.6.2.28.2.33r2=1.409.2.6.2.28.2.34diff_format=u
Index:
Yes, the code indeed is very different. I suggest you look in the mirror to find
out who to blame. And then do a diff -u between file.c on PHP_5_2, PHP_5_3 and
HEAD. Make your life easier and sync the files between branches before you
commit any more fixes..
--Jani
p.s. I found 1 other bug
iliaa Mon May 18 18:45:30 2009 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c
Log:
Fixed bug #48313 (fgetcsv() does not return null for empty rows)
What about HEAD?
--Jani
Ilia Alshanetsky kirjoitti:
iliaa Mon May 18 18:45:30 2009 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c
Log:
Fixed bug #48313 (fgetcsv() does not return null for empty rows)
Work in progress, the code is very different there and the patch will
be very different.
Ilia Alshanetsky
On 18-May-09, at 5:19 PM, Jani Taskinen wrote:
What about HEAD?
--Jani
Ilia Alshanetsky kirjoitti:
iliaa Mon May 18 18:45:30 2009 UTC
Modified files:
lbarnaudFri May 8 09:44:18 2009 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c
Log:
Fix invalid read
http://cvs.php.net/viewvc.cgi/php-src/ext/standard/file.c?r1=1.409.2.6.2.28.2.31r2=1.409.2.6.2.28.2.32diff_format=u
Index:
lbarnaudSun Apr 19 17:10:35 2009 UTC
Modified files: (Branch: PHP_5_3)
/php-src/main php_streams.h
/php-src/main/streams cast.c streams.c
/php-src/ext/standard file.c streamsfuncs.c
Log:
MFH: Better fix for #47997
pajoye Tue Jan 20 01:40:07 2009 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c
/php-src/ext/standard/tests/filefnmatch_basic.phpt
fnmatch_error.phpt
lstrojnySat Dec 13 15:06:20 2008 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c
Log:
One len variable is enough here, we can reuse it
bjori Fri Dec 12 12:44:49 2008 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c
/php-src/ext/standard/tests/filemkdir_variation1.phpt
mkdir_variation1-win32.phpt
lbarnaudWed Nov 26 04:19:20 2008 UTC
Added files: (Branch: PHP_5_3)
/php-src/ext/standard/tests/fileuserstreams_004.phpt
Modified files:
/php-src/ext/standard file.c flock_compat.h
/php-src/main/streams userspace.c
felipe Fri Sep 12 01:14:14 2008 UTC
Added files: (Branch: PHP_5_3)
/php-src/ext/standard/tests/filefputcsv_002.phpt
Modified files:
/php-src/ext/standard file.c
Log:
- MFH: Fixed unexpected zval changes
felipe Tue Aug 12 19:38:55 2008 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c
/php-src/ext/standard/tests/filefscanf.phpt fscanf_error.phpt
Log:
- New parameter parsing API (for fscanf)
Hello Felipe,
Tuesday, August 12, 2008, 9:38:55 PM, you wrote:
felipe Tue Aug 12 19:38:55 2008 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c
/php-src/ext/standard/tests/filefscanf.phpt fscanf_error.phpt
Log:
- New
Em Ter, 2008-08-12 às 21:46 +0200, Marcus Boerger escreveu:
Hello Felipe,
Tuesday, August 12, 2008, 9:38:55 PM, you wrote:
-Warning: fscanf(): %d is not a valid File-Handle resource in %s on line %d
+Warning: fscanf(): 6 is not a valid File-Handle resource in %s on line %d
Verifying
pajoye Mon Aug 11 13:11:31 2008 UTC
Removed files: (Branch: PHP_5_3)
/php-src/ext/standard/tests/filecopy_variation4-win32.phpt
Modified files:
/php-src/ext/standard file.c
/php-src/ext/standard/tests/filecopy_variation4.phpt
felipe Tue Jul 22 14:09:24 2008 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c fsock.c proc_open.c streamsfuncs.c
/php-src/ext/standard/tests/filefscanf_variation10.phpt
fscanf_variation16.phpt
janiMon Jul 21 11:46:18 2008 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c
Log:
- Forward compatibility.
# @DOC@, [DOC], *DOC*: Added FILE_TEXT and FILE_BINARY constants for forward
compatibility.
ohill Thu Jul 3 20:19:27 2008 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c
/php-src/ext/standard/tests/file007_error.phpt fflush_error.phpt
fgetc_error.phpt
felipe Fri May 16 12:44:11 2008 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c
Log:
- Changed 'Z' to 's' (parameter parsing), the code didn't check if the
parameter is a string.
iliaa Sun Mar 30 15:05:49 2008 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c
Log:
Added a warning message
http://cvs.php.net/viewvc.cgi/php-src/ext/standard/file.c?r1=1.409.2.6.2.28.2.10r2=1.409.2.6.2.28.2.11diff_format=u
Index:
Can't you check with php_stream_supports_lock here wether the stream-
wrapper supports locking?
regards,
Benjamin
On 27.03.2008, at 00:06, Ilia Alshanetsky wrote:
iliaa Wed Mar 26 23:06:48 2008 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard
On 27.03.2008 10:15, Benjamin Schulz wrote:
Can't you check with php_stream_supports_lock here wether the stream-
wrapper supports locking?
I agree, that would make much more sense.
--
Wbr,
Antony Dovgal
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit:
Can't you check with php_stream_supports_lock here wether the
stream-wrapper supports locking?
That requires an open stream.
And why don't you raise the warning after opening the stream? There is
this check anyway:
if (flags LOCK_EX (!php_stream_supports_lock(stream) ||
iliaa Wed Mar 26 23:06:48 2008 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c
Log:
Fixed bug #44501 (LOCK_EX mode in file_put_contents() is impropertly
handled in combination with url wrappers)
felipe Sun Feb 24 11:45:55 2008 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c
Log:
Removed internal warning
http://cvs.php.net/viewvc.cgi/php-src/ext/standard/file.c?r1=1.409.2.6.2.28.2.8r2=1.409.2.6.2.28.2.9diff_format=u
Index:
tony2001Tue Nov 13 10:31:25 2007 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c
Log:
fix typo (nice catch, Nuno!)
Thanks for the typo catch fix.
On 13-Nov-07, at 5:31 AM, Antony Dovgal wrote:
tony2001Tue Nov 13 10:31:25 2007 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standardfile.c
Log:
fix typo (nice catch, Nuno!)
iliaa Mon Nov 12 18:44:18 2007 UTC
Modified files: (Branch: PHP_5_3)
/php-src/main/streams plain_wrapper.c
/php-src/ext/standard file.c
Log:
Fixed bug #43182 (file_put_contents() LOCK_EX does not work properly on file
truncation).
Hi Ilia,
+ char mode[3] = wb;
+ if (flags PHP_FILE_APPEND) {
+ mode[0] = 'a';
+ } else if (flags LOCK_EX) {
+ mode[0] = 'c';
uhm, I think this assignment isn't needed, as the variable should already
contain the '\0' from the initilization above.
+ mode[2] = '\0';
probably you meant
dmitry Fri Nov 9 11:08:23 2007 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c
Log:
Conditions optimization
http://cvs.php.net/viewvc.cgi/php-src/ext/standard/file.c?r1=1.409.2.6.2.28.2.3r2=1.409.2.6.2.28.2.4diff_format=u
Index:
janiTue Nov 6 17:11:57 2007 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c link.c
/php-src/ext/standard/tests/filefgetc_variation2.phpt
readlink_realpath_error.phpt
janiMon Nov 5 17:43:05 2007 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/standard file.c
Log:
MFH: Sync
[DOC]: note
[DOC] -/* {{{ proto bool copy(string source_file, string destination_file)
[DOC] +/* {{{ proto bool copy(string source_file,
35 matches
Mail list logo
